[Reporting] Fix reporting for non-default spaces#62226
Merged
tsullivan merged 6 commits intoelastic:masterfrom Apr 4, 2020
Merged
[Reporting] Fix reporting for non-default spaces#62226tsullivan merged 6 commits intoelastic:masterfrom
tsullivan merged 6 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
Member
Author
|
@elasticmachine merge upstream |
flash1293
approved these changes
Apr 2, 2020
Contributor
flash1293
left a comment
There was a problem hiding this comment.
Tested in chrome and works as expected, created png/pdf/print-optimized pdf reports of a dashboard in a custom space and all were created successfully. LGTM 👍
Did not do a thorough code review.
Member
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
poffdeluxe
approved these changes
Apr 3, 2020
Contributor
poffdeluxe
left a comment
There was a problem hiding this comment.
Canvas changes look good
This was referenced Apr 4, 2020
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Apr 4, 2020
* [Reporting] Fix URLs in job params when basePath includes namespace suffix * canvas fix * cleanup * update snapshots in tests Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Apr 4, 2020
* [Reporting] Fix URLs in job params when basePath includes namespace suffix * canvas fix * cleanup * update snapshots in tests Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
tsullivan
added a commit
that referenced
this pull request
Apr 4, 2020
* [Reporting] Fix URLs in job params when basePath includes namespace suffix * canvas fix * cleanup * update snapshots in tests Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
tsullivan
added a commit
that referenced
this pull request
Apr 5, 2020
* [Reporting] Fix URLs in job params when basePath includes namespace suffix * canvas fix * cleanup * update snapshots in tests Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 6, 2020
…into event-log/query-support * 'event-log/query-support' of github.com:gmmorris/kibana: (41 commits) [jenkins] refer to sizes in most pipeline code (elastic#62082) skip flaky suite (elastic#60470) [Discover] Fix flaky FT in field visualize (elastic#62418) [ML] Data Frame Analytics: Fix feature importance (elastic#61761) [Reporting] Use a shim for server config (elastic#62086) [Reporting] Fix reporting for non-default spaces (elastic#62226) Fix bug that coerced empty scaled float value to 0 (elastic#62251) [SIEM] [Detection Engine] Remove has manage api keys requireme… (elastic#62446) [Maps] Safely handle empty string and invalid strings from EuiColorPicker (elastic#62507) Reporting/bug more blacklisted headers (elastic#62389) [SIEM] Prevent undefined behavior in our ML popover (elastic#62498) [SIEM] [Detection Engine] remove all unknowns from all rules t… (elastic#62327) base changes for active/current node styling (elastic#62007) [kbn/ui-shared-deps] expand and split (elastic#62364) [ML] DF Analytics - ensure destination index pattern created (elastic#62450) Mark rule run as failure if there was an error (elastic#62383) Add docs for metric explorer alerts (elastic#62314) skip flaky suite (elastic#62281) [SIEM][Detection Engine] Fixes export of single rule and the icons fixes flakiness (elastic#62406) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #61813
Checklist
Test cases:
Generate a report from a button, and from sending a request to the copied POST URL
Delete any items that are not applicable to this PR.
[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibility[ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser[ ] This was checked for cross-browser compatibility, including a check against IE11For maintainers