[Alerting] add alerting privileges for uptime and metrics#61113
Merged
pmuellr merged 3 commits intoelastic:masterfrom Apr 1, 2020
Merged
[Alerting] add alerting privileges for uptime and metrics#61113pmuellr merged 3 commits intoelastic:masterfrom
pmuellr merged 3 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
resolves elastic#60135 See the reference issue for how to configure Kibana to test this manually. There are no automated tests for this ATM. The basic test scenario is to create a role with just the Uptime space privilege, make sure it get to the Alerts and Actions management app, make sure you can create an action (server log), and alert (index threshold), and that the alert and action run successfully. Then repeat with just the Metrics space privilege.
4cdf1e1 to
daf35f9
Compare
mikecote
approved these changes
Mar 24, 2020
Contributor
mikecote
left a comment
There was a problem hiding this comment.
LGTM thanks for tackling this 🙏 It looks like APM may need a few adjustments as well https://github.com/elastic/kibana/blob/master/x-pack/legacy/plugins/apm/index.ts#L108-L133 probably in a follow up PR.
pmuellr
added a commit
to pmuellr/kibana
that referenced
this pull request
Mar 24, 2020
Based on a [review comment of a related PR][1], the apm feature definition has been changed to supply all the alerting/action privs for both read and all apm privs. [1] elastic#61113 (review)
Contributor
|
@elasticmachine merge upstream |
pmuellr
added a commit
that referenced
this pull request
Mar 31, 2020
Based on a [review comment of a related PR[1], the apm feature definition has been changed to supply all the alerting/action privs for both read and all apm privs. [1] #61113 (review)
pmuellr
added a commit
to pmuellr/kibana
that referenced
this pull request
Mar 31, 2020
…#61159) Based on a [review comment of a related PR[1], the apm feature definition has been changed to supply all the alerting/action privs for both read and all apm privs. [1] elastic#61113 (review)
pmuellr
added a commit
to pmuellr/kibana
that referenced
this pull request
Mar 31, 2020
…#61159) Based on a [review comment of a related PR[1], the apm feature definition has been changed to supply all the alerting/action privs for both read and all apm privs. [1] elastic#61113 (review)
pmuellr
added a commit
that referenced
this pull request
Mar 31, 2020
…#61923) Based on a [review comment of a related PR[1], the apm feature definition has been changed to supply all the alerting/action privs for both read and all apm privs. [1] #61113 (review)
pmuellr
added a commit
that referenced
this pull request
Mar 31, 2020
…#61922) Based on a [review comment of a related PR[1], the apm feature definition has been changed to supply all the alerting/action privs for both read and all apm privs. [1] #61113 (review)
phillipb
approved these changes
Mar 31, 2020
Contributor
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
shahzad31
approved these changes
Apr 1, 2020
Contributor
shahzad31
left a comment
There was a problem hiding this comment.
Looks good for uptime.
pmuellr
added a commit
to pmuellr/kibana
that referenced
this pull request
Apr 1, 2020
) resolves elastic#60135 See the reference issue for how to configure Kibana to test this manually. There are no automated tests for this ATM. The basic test scenario is to create a role with just the Uptime space privilege, make sure it get to the Alerts and Actions management app, make sure you can create an action (server log), and alert (index threshold), and that the alert and action run successfully. Then repeat with just the Metrics space privilege.
pmuellr
added a commit
to pmuellr/kibana
that referenced
this pull request
Apr 1, 2020
) resolves elastic#60135 See the reference issue for how to configure Kibana to test this manually. There are no automated tests for this ATM. The basic test scenario is to create a role with just the Uptime space privilege, make sure it get to the Alerts and Actions management app, make sure you can create an action (server log), and alert (index threshold), and that the alert and action run successfully. Then repeat with just the Metrics space privilege.
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 1, 2020
* master: (44 commits) [Alerting] add alerting privileges for uptime and metrics (elastic#61113) Update percy agent to latest version (elastic#62089) [APM] Update central configuration text (elastic#61556) [Fleet] Ouput api key do not need metricbeat* access (elastic#60319) Document new `xpack.security.authc.*` settings and related 8.0.0 breaking changes. (elastic#61443) Migrate test plugins ⇒ NP (kbn_tp_sample_panel_action) (elastic#60749) [Alerting] Add "Start trial" button for connectors (elastic#61774) [ML] Transforms: Fix handling of default and advanced search on step summary view. (elastic#61799) [Task Manager] Change info message "ran out Available Workers" to debug (elastic#62083) [Maps] Highlight selected layer in TOC (elastic#61510) ensure pageIndex is set correclty in analytics list (elastic#62041) [ML] Functional API tests - fix mml request bodies (elastic#62116) Fix validation for index threshold when selecting an index (elastic#61615) [SIEM][Detection Engine] Adds release notes link and updates one UI section [backport] Bump to 5.1.2 (elastic#62117) [APM] .apm-agent-configuration is not created if Kibana is started while ES is not ready (elastic#61610) [Fleet] Enrollment list page (elastic#61346) [ML] Fix maximum default enabled columns for data grid. (elastic#62005) [Home][Tutorial] Add Oracle data UI (elastic#61595) [APM] Ensure telemetry data matches SO/telemetry mapping (elastic#61957) ...
pmuellr
added a commit
that referenced
this pull request
Apr 1, 2020
…62188) resolves #60135 See the reference issue for how to configure Kibana to test this manually. There are no automated tests for this ATM. The basic test scenario is to create a role with just the Uptime space privilege, make sure it get to the Alerts and Actions management app, make sure you can create an action (server log), and alert (index threshold), and that the alert and action run successfully. Then repeat with just the Metrics space privilege.
pmuellr
added a commit
that referenced
this pull request
Apr 1, 2020
…62189) resolves #60135 See the reference issue for how to configure Kibana to test this manually. There are no automated tests for this ATM. The basic test scenario is to create a role with just the Uptime space privilege, make sure it get to the Alerts and Actions management app, make sure you can create an action (server log), and alert (index threshold), and that the alert and action run successfully. Then repeat with just the Metrics space privilege.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #60135
See the reference issue for how to configure Kibana to test this manually.
There are no automated tests for this ATM.
The basic test scenario is to create a role with just the Uptime space
privilege, make sure it get to the Alerts and Actions management app,
make sure you can create an action (server log), and alert (index threshold),
and that the alert and action run successfully.
Then repeat with just the Metrics space privilege.