[Alerting] add complete alerting/action privs to apm feature#61159
Merged
pmuellr merged 3 commits intoelastic:masterfrom Mar 31, 2020
Merged
[Alerting] add complete alerting/action privs to apm feature#61159pmuellr merged 3 commits intoelastic:masterfrom
pmuellr merged 3 commits intoelastic:masterfrom
Conversation
Based on a [review comment of a related PR][1], the apm feature definition has been changed to supply all the alerting/action privs for both read and all apm privs. [1] elastic#61113 (review)
Contributor
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
dgieselaar
reviewed
Mar 24, 2020
Comment on lines
+136
to
+139
| 'actions-read', | ||
| 'actions-all', | ||
| 'alerting-read', | ||
| 'alerting-all' |
Contributor
There was a problem hiding this comment.
this means that our read users can create alerts as well, is that intended/necessary?
Contributor
There was a problem hiding this comment.
We're recommending solution teams to use an all or nothing approach from the privileges perspective until we have proper support for feature controls (#43994). It opens up weird cases if we allow granular control. A user would just need all in APM, Uptime, Metrics or SIEM to undermine a read level alerting access. We could remove this code for readonly APM users, would that make sense?
Contributor
There was a problem hiding this comment.
Ah, it's fine then AFAIC to use all-or-nothing.
dgieselaar
approved these changes
Mar 27, 2020
Contributor
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
pmuellr
added a commit
to pmuellr/kibana
that referenced
this pull request
Mar 31, 2020
…#61159) Based on a [review comment of a related PR[1], the apm feature definition has been changed to supply all the alerting/action privs for both read and all apm privs. [1] elastic#61113 (review)
This was referenced Mar 31, 2020
pmuellr
added a commit
to pmuellr/kibana
that referenced
this pull request
Mar 31, 2020
…#61159) Based on a [review comment of a related PR[1], the apm feature definition has been changed to supply all the alerting/action privs for both read and all apm privs. [1] elastic#61113 (review)
pmuellr
added a commit
that referenced
this pull request
Mar 31, 2020
…#61923) Based on a [review comment of a related PR[1], the apm feature definition has been changed to supply all the alerting/action privs for both read and all apm privs. [1] #61113 (review)
pmuellr
added a commit
that referenced
this pull request
Mar 31, 2020
…#61922) Based on a [review comment of a related PR[1], the apm feature definition has been changed to supply all the alerting/action privs for both read and all apm privs. [1] #61113 (review)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on a review comment of a related PR, the apm feature definition
has been changed to supply all the alerting/action privs for both read
and all apm privs.