Skip to content

[APM] Update central configuration text#61556

Merged
bmorelli25 merged 5 commits intoelastic:masterfrom
bmorelli25:update-central-config-text
Apr 1, 2020
Merged

[APM] Update central configuration text#61556
bmorelli25 merged 5 commits intoelastic:masterfrom
bmorelli25:update-central-config-text

Conversation

@bmorelli25
Copy link
Copy Markdown
Member

@bmorelli25 bmorelli25 commented Mar 26, 2020

Summary

This PR updates the APM central configuration text. Specifically, it:

  • Removes asciidoctor links, both external (https://...) and internal (<<some-link>>).
  • Removes \n that don't do anything.
  • Removes duplication of default values. Example:

Screen Shot 2020-03-26 at 4 20 28 PM

Screenshot

Not sure if this is helpful, but here's a screenshot:
config-changes

Related Issues

Closes #62171.

@bmorelli25 bmorelli25 added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Mar 26, 2020
@bmorelli25 bmorelli25 requested a review from a team March 26, 2020 23:23
@bmorelli25 bmorelli25 self-assigned this Mar 26, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/apm-ui (Team:apm)

@bmorelli25
Copy link
Copy Markdown
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@bmorelli25
Copy link
Copy Markdown
Member Author

Bump @elastic/apm-ui. Can I get a review on this please

Copy link
Copy Markdown
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmorelli25 bmorelli25 merged commit e4ee030 into elastic:master Apr 1, 2020
@bmorelli25 bmorelli25 deleted the update-central-config-text branch April 1, 2020 15:24
bmorelli25 added a commit to bmorelli25/kibana that referenced this pull request Apr 1, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 1, 2020
* master: (44 commits)
  [Alerting] add alerting privileges for uptime and metrics (elastic#61113)
  Update percy agent to latest version (elastic#62089)
  [APM] Update central configuration text (elastic#61556)
  [Fleet] Ouput api key do not need metricbeat* access (elastic#60319)
  Document new `xpack.security.authc.*` settings and related 8.0.0 breaking changes. (elastic#61443)
  Migrate test plugins ⇒ NP (kbn_tp_sample_panel_action) (elastic#60749)
  [Alerting] Add "Start trial" button for connectors (elastic#61774)
  [ML] Transforms: Fix handling of default and advanced search on step summary view. (elastic#61799)
  [Task Manager] Change info message "ran out Available Workers" to debug (elastic#62083)
  [Maps] Highlight selected layer in TOC (elastic#61510)
  ensure pageIndex is set correclty in analytics list (elastic#62041)
  [ML] Functional API tests - fix mml request bodies (elastic#62116)
  Fix validation for index threshold when selecting an index (elastic#61615)
  [SIEM][Detection Engine] Adds release notes link and updates one UI section
  [backport] Bump to 5.1.2 (elastic#62117)
  [APM] .apm-agent-configuration is not created if Kibana is started while ES is not ready (elastic#61610)
  [Fleet] Enrollment list page (elastic#61346)
  [ML] Fix maximum default enabled columns for data grid. (elastic#62005)
  [Home][Tutorial] Add Oracle data UI (elastic#61595)
  [APM] Ensure telemetry data matches SO/telemetry mapping (elastic#61957)
  ...
@smith smith added apm-test-plan-7.7.0 apm:test-plan-done Pull request that was successfully tested during the test plan labels Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apm:test-plan-done Pull request that was successfully tested during the test plan release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.7.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[APM] Agent remote configuration: fix external and internal links in config option description

5 participants