[ML] DF Analytics job list: ensure filter works as expected#62041
Merged
alvarezmelissa87 merged 1 commit intoelastic:masterfrom Apr 1, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/ml-ui (:ml) |
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
walterra
approved these changes
Apr 1, 2020
Contributor
walterra
left a comment
There was a problem hiding this comment.
LGTM, also did a local test.
| if (pageStart >= filtered.length && filtered.length !== 0) { | ||
| // if the page start is larger than the number of items due to | ||
| // filters being applied, calculate a new page start | ||
| pageStart = Math.floor((filtered.length - 1) / pageSize) * pageSize; |
Contributor
There was a problem hiding this comment.
Nit: You could name this const updatedPageStart = ..., this would allow the upper let pageStart to become const pageStart.
alvarezmelissa87
added a commit
to alvarezmelissa87/kibana
that referenced
this pull request
Apr 1, 2020
alvarezmelissa87
added a commit
to alvarezmelissa87/kibana
that referenced
this pull request
Apr 1, 2020
alvarezmelissa87
added a commit
that referenced
this pull request
Apr 1, 2020
alvarezmelissa87
added a commit
that referenced
this pull request
Apr 1, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 1, 2020
* master: (44 commits) [Alerting] add alerting privileges for uptime and metrics (elastic#61113) Update percy agent to latest version (elastic#62089) [APM] Update central configuration text (elastic#61556) [Fleet] Ouput api key do not need metricbeat* access (elastic#60319) Document new `xpack.security.authc.*` settings and related 8.0.0 breaking changes. (elastic#61443) Migrate test plugins ⇒ NP (kbn_tp_sample_panel_action) (elastic#60749) [Alerting] Add "Start trial" button for connectors (elastic#61774) [ML] Transforms: Fix handling of default and advanced search on step summary view. (elastic#61799) [Task Manager] Change info message "ran out Available Workers" to debug (elastic#62083) [Maps] Highlight selected layer in TOC (elastic#61510) ensure pageIndex is set correclty in analytics list (elastic#62041) [ML] Functional API tests - fix mml request bodies (elastic#62116) Fix validation for index threshold when selecting an index (elastic#61615) [SIEM][Detection Engine] Adds release notes link and updates one UI section [backport] Bump to 5.1.2 (elastic#62117) [APM] .apm-agent-configuration is not created if Kibana is started while ES is not ready (elastic#61610) [Fleet] Enrollment list page (elastic#61346) [ML] Fix maximum default enabled columns for data grid. (elastic#62005) [Home][Tutorial] Add Oracle data UI (elastic#61595) [APM] Ensure telemetry data matches SO/telemetry mapping (elastic#61957) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #61932
Updates pageIndex when filter is applied to ensure filtered items show up.
Checklist
Delete any items that are not applicable to this PR.