Add addInfo toast to core notifications service by lizozom · Pull Request #60574 · elastic/kibana

lizozom · 2020-03-18T22:32:40Z

Summary

Add addInfo toast to core notifications service

Going to be used for the async search notifications.

Dev Docs

Added an Info toast to the core notifications service.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility, including a check against IE11

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2020-03-18T22:32:42Z

Pinging @elastic/kibana-platform (Team:Platform)

joshdover · 2020-03-18T23:03:20Z

src/core/public/notifications/toasts/toasts_api.tsx

+   * @param toastLifeTimeMs - a {@link number}
+   * @returns a {@link Toast}
+   */
+  public addInfo(toastOrTitle: ToastInput, toastLifeTimeMs?: number) {


toastLifeTimeMs isn't an option for any other method here. For consistency, I think we should either add it to all methods or simply require that the plugin dismiss it with a setTimeout.

If you do decide it to all, can we add it as an options object to make future extension easier:

public addInfo(toastOrTitle: ToastInput, options: { toastLifeTimeMs?: number } = {})

src/core/public/notifications/toasts/toasts_api.test.ts

lukasolson

LGTM!

lukasolson · 2020-03-19T18:27:38Z

@elasticmachine merge upstream

…-notifications

…na into platform/info-notifications

kibanamachine · 2020-03-19T23:49:36Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 6a5167d

History

💚 Build #34637 succeeded b1584f3
💔 Build #34462 failed 697c3e3
💔 Build #34366 failed 372525e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

pgayvallet

LGTM for platform changes

* addInfo toast * md files * fis types * Added options to toast methods * Export ToastOptions * Export ToastOptions * added test Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* addInfo toast * md files * fis types * Added options to toast methods * Export ToastOptions * Export ToastOptions * added test Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* master: (52 commits) [SIEM] Fix types in rules tests (elastic#60736) [Alerting] prevent flickering when fields are updated in an alert (elastic#60666) License checks for actions plugin (elastic#59070) Implemented ability to clear and properly validate alert interval (elastic#60571) WebElementWrapper: add findByTestSubject/findAllByTestSubject to search with data-test-subj (elastic#60568) [Maps] Update layer dependencies to NP (elastic#59585) [Discover] Remove StateManagementConfigProvider (elastic#60221) [ML] Listing all categorization wizard checks (elastic#60502) [Upgrade Assistant] First iteration of batch reindex docs (elastic#59887) [SIEM] Export timeline (elastic#58368) [SIEM] Add support for actions and throttle in Rules (elastic#59641) Fix ace a11y listener (elastic#60639) Add addInfo toast to core notifications service (elastic#60574) fix test description (elastic#60638) [SIEM] Cypress screenshots upload to google cloud (elastic#60556) [canvas/shareable_runtime] sync sass loaders with kbn/optimizer (elastic#60653) [SIEM] Fixes Modification of ML Rules (elastic#60662) [SIEM] [Case] Bulk status update, add comment avatar, id => title in breadcrumbs (elastic#60410) [Alerting] add functional tests for index threshold alertType (elastic#60597) [Ingest]EMT-248: add post action request handler and resources (elastic#60581) ...

* master: (55 commits) Update dependency @elastic/charts to v18.1.0 (elastic#60578) Only set timezone when user setting is a valid timezone (elastic#57850) [NP] Remove `ui/agg_types` dependencies and move paginated table to kibana_legacy (elastic#60276) [SIEM] Fix types in rules tests (elastic#60736) [Alerting] prevent flickering when fields are updated in an alert (elastic#60666) License checks for actions plugin (elastic#59070) Implemented ability to clear and properly validate alert interval (elastic#60571) WebElementWrapper: add findByTestSubject/findAllByTestSubject to search with data-test-subj (elastic#60568) [Maps] Update layer dependencies to NP (elastic#59585) [Discover] Remove StateManagementConfigProvider (elastic#60221) [ML] Listing all categorization wizard checks (elastic#60502) [Upgrade Assistant] First iteration of batch reindex docs (elastic#59887) [SIEM] Export timeline (elastic#58368) [SIEM] Add support for actions and throttle in Rules (elastic#59641) Fix ace a11y listener (elastic#60639) Add addInfo toast to core notifications service (elastic#60574) fix test description (elastic#60638) [SIEM] Cypress screenshots upload to google cloud (elastic#60556) [canvas/shareable_runtime] sync sass loaders with kbn/optimizer (elastic#60653) [SIEM] Fixes Modification of ML Rules (elastic#60662) ...

…o alerting/tls-warning * 'alerting/tls-warning' of github.com:gmmorris/kibana: (32 commits) [ML] Listing all categorization wizard checks (elastic#60502) [Upgrade Assistant] First iteration of batch reindex docs (elastic#59887) [SIEM] Export timeline (elastic#58368) [SIEM] Add support for actions and throttle in Rules (elastic#59641) Fix ace a11y listener (elastic#60639) Add addInfo toast to core notifications service (elastic#60574) fix test description (elastic#60638) [SIEM] Cypress screenshots upload to google cloud (elastic#60556) [canvas/shareable_runtime] sync sass loaders with kbn/optimizer (elastic#60653) [SIEM] Fixes Modification of ML Rules (elastic#60662) [SIEM] [Case] Bulk status update, add comment avatar, id => title in breadcrumbs (elastic#60410) [Alerting] add functional tests for index threshold alertType (elastic#60597) [Ingest]EMT-248: add post action request handler and resources (elastic#60581) Return incident's url (elastic#60617) [Endpoint] TEST: GET alert details - boundary test for first alert retrieval (elastic#60320) [ML] Transforms: Fix pivot preview table mapping. (elastic#60609) [Endpoint] Log random seed for sample data CLI to console (elastic#60646) Use common event model for determining if event is v0 or v1 (elastic#60667) Disables PR Project Assigner workflow [Reporting] Allow reports to be deleted in Management > Kibana > Reporting (elastic#60077) ...

Liza K added 2 commits March 19, 2020 00:26

addInfo toast

1d1bd9b

md files

372525e

lizozom added Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v8.0.0 v7.7.0 labels Mar 18, 2020

lizozom requested a review from a team as a code owner March 18, 2020 22:32

lizozom self-assigned this Mar 18, 2020

lizozom requested a review from lukasolson March 18, 2020 22:34

lizozom added the release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. label Mar 18, 2020

lukasolson mentioned this pull request Mar 18, 2020

UI for proactively canceling long-running queries #46370

Closed

6 tasks

joshdover reviewed Mar 18, 2020

View reviewed changes

Liza K added 4 commits March 19, 2020 11:52

fis types

f7df4e7

Added options to toast methods

685b69c

Export ToastOptions

4f25318

Export ToastOptions

697c3e3

lizozom requested a review from joshdover March 19, 2020 10:28

pgayvallet reviewed Mar 19, 2020

View reviewed changes

src/core/public/notifications/toasts/toasts_api.test.ts Show resolved Hide resolved

lukasolson approved these changes Mar 19, 2020

View reviewed changes

elasticmachine and others added 3 commits March 19, 2020 14:27

Merge branch 'master' into platform/info-notifications

b1584f3

Merge branch 'master' of github.com:elastic/kibana into platform/info…

5b8dacb

…-notifications

added test

e63a233

lizozom requested a review from pgayvallet March 19, 2020 22:05

Merge branch 'platform/info-notifications' of github.com:lizozom/kiba…

6a5167d

…na into platform/info-notifications

lizozom mentioned this pull request Mar 19, 2020

Add async search notification #60706

Merged

7 tasks

pgayvallet approved these changes Mar 20, 2020

View reviewed changes

lizozom merged commit ef0935f into elastic:master Mar 20, 2020

lizozom mentioned this pull request Mar 20, 2020

[7.x] Add addInfo toast to core notifications service (#60574) #60724

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add addInfo toast to core notifications service#60574

Add addInfo toast to core notifications service#60574
lizozom merged 10 commits intoelastic:masterfrom
lizozom:platform/info-notifications

lizozom commented Mar 18, 2020 •

edited

Loading

Uh oh!

elasticmachine commented Mar 18, 2020

Uh oh!

joshdover Mar 18, 2020

Uh oh!

lizozom Mar 19, 2020

Uh oh!

Uh oh!

lukasolson left a comment

Uh oh!

lukasolson commented Mar 19, 2020

Uh oh!

kibanamachine commented Mar 19, 2020

Uh oh!

pgayvallet left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

lizozom commented Mar 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Dev Docs

Checklist

For maintainers

Uh oh!

elasticmachine commented Mar 18, 2020

Uh oh!

joshdover Mar 18, 2020

Choose a reason for hiding this comment

Uh oh!

lizozom Mar 19, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lukasolson left a comment

Choose a reason for hiding this comment

Uh oh!

lukasolson commented Mar 19, 2020

Uh oh!

kibanamachine commented Mar 19, 2020

💚 Build Succeeded

History

Uh oh!

pgayvallet left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

lizozom commented Mar 18, 2020 •

edited

Loading