[SIEM] [Case] Bulk status update, add comment avatar, id => title in breadcrumbs by stephmilovic · Pull Request #60410 · elastic/kibana

stephmilovic · 2020-03-17T16:37:24Z

Summary

This PR resolves the following All Cases issues from #59041:

implement bulk open/close

This PR resolves the following Case View issues from #58526:

make the user avatar the currentUser for update mode on description/comments and also on new comments
change the breadcrumbs to display Case Title instead of Case Id

elasticmachine · 2020-03-17T16:37:27Z

Pinging @elastic/siem (Team:SIEM)

x-pack/legacy/plugins/siem/public/utils/route/spy_routes.tsx

x-pack/legacy/plugins/siem/public/containers/case/api.ts

cnasikas · 2020-03-18T12:27:00Z

x-pack/legacy/plugins/siem/public/pages/case/components/bulk_actions/index.tsx

        icon="magnet"
-        disabled={true} // TO DO
-        onClick={async () => {
+        onClick={() => {


Better to use useCallback to avoid unnecessary re-renders

I'm not in a react component here. FWIW the actions passed here are in their own useCallbacks

I am not sure given that EuiContextMenuItem is a component. @patrykkopycinski ?

I think @stephmilovic is right, but to be sure you can always use why-did-you-render or Profiler :)

cnasikas · 2020-03-18T12:27:33Z

x-pack/legacy/plugins/siem/public/pages/case/components/bulk_actions/index.tsx

      key={i18n.BULK_ACTION_DELETE_SELECTED}
      icon="trash"
-      onClick={async () => {
+      onClick={() => {


Better to use useCallback to avoid unnecessary re-renders

I'm not in a react component here. FWIW the actions passed here are in their own useCallbacks

x-pack/legacy/plugins/siem/public/pages/case/components/case_view/index.tsx

cnasikas · 2020-03-18T14:17:48Z

I noticed that when you open a case the title is the ID of the case. After that, it's change to the case's name. I understand why this is happening. Is that ok to leave it like that or is it better to have it empty until the case is loaded?

x-pack/legacy/plugins/siem/public/pages/case/components/all_cases/index.tsx

angorayc · 2020-03-18T15:23:51Z

x-pack/legacy/plugins/siem/public/pages/case/components/bulk_actions/index.tsx

+  updateCaseStatus,
 }: GetBulkItems) => {
  return [
    caseStatus === 'open' ? (


I think it would be nice if we have a type of all the caseStatus defined.

yes i agree. i can do this in a follow up PR, i have another one up that deals a lot with status right now

stephmilovic · 2020-03-18T19:25:41Z

I noticed that when you open a case the title is the ID of the case. After that, it's change to the case's name. I understand why this is happening. Is that ok to leave it like that or is it better to have it empty until the case is loaded?

better empty, i made this change. thanks 👍

x-pack/legacy/plugins/siem/public/pages/case/components/user_action_tree/index.tsx

rylnd · 2020-03-19T18:17:32Z

x-pack/legacy/plugins/siem/public/plugin.tsx

  inspector: InspectorStart;
  newsfeed?: NewsfeedStart;
-  uiActions: UiActionsStart;
+  security: SecurityPluginSetup;


This should be the Start contract, SecurityPluginStart

SecurityPluginStart does not have the authc we need. It is only in setup. thats why we needed to add it explicitly in the object https://github.com/elastic/kibana/blob/master/x-pack/plugins/security/public/plugin.tsx#L137

Ohhh, I get it now. We're doing some similar stuff on the server, but the basic idea is: store dependencies in setup() to use later in start(). This should be fine for now, but I'll follow up with platform and change it in the NP migration if necessary. 👍

kibanamachine · 2020-03-19T19:43:35Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 6707e91

History

💔 Build #34541 failed b36b4fb
💔 Build #34315 failed 36a7570

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…breadcrumbs (elastic#60410)

…breadcrumbs (#60410) (#60709)

* master: (52 commits) [SIEM] Fix types in rules tests (elastic#60736) [Alerting] prevent flickering when fields are updated in an alert (elastic#60666) License checks for actions plugin (elastic#59070) Implemented ability to clear and properly validate alert interval (elastic#60571) WebElementWrapper: add findByTestSubject/findAllByTestSubject to search with data-test-subj (elastic#60568) [Maps] Update layer dependencies to NP (elastic#59585) [Discover] Remove StateManagementConfigProvider (elastic#60221) [ML] Listing all categorization wizard checks (elastic#60502) [Upgrade Assistant] First iteration of batch reindex docs (elastic#59887) [SIEM] Export timeline (elastic#58368) [SIEM] Add support for actions and throttle in Rules (elastic#59641) Fix ace a11y listener (elastic#60639) Add addInfo toast to core notifications service (elastic#60574) fix test description (elastic#60638) [SIEM] Cypress screenshots upload to google cloud (elastic#60556) [canvas/shareable_runtime] sync sass loaders with kbn/optimizer (elastic#60653) [SIEM] Fixes Modification of ML Rules (elastic#60662) [SIEM] [Case] Bulk status update, add comment avatar, id => title in breadcrumbs (elastic#60410) [Alerting] add functional tests for index threshold alertType (elastic#60597) [Ingest]EMT-248: add post action request handler and resources (elastic#60581) ...

…o alerting/tls-warning * 'alerting/tls-warning' of github.com:gmmorris/kibana: (32 commits) [ML] Listing all categorization wizard checks (elastic#60502) [Upgrade Assistant] First iteration of batch reindex docs (elastic#59887) [SIEM] Export timeline (elastic#58368) [SIEM] Add support for actions and throttle in Rules (elastic#59641) Fix ace a11y listener (elastic#60639) Add addInfo toast to core notifications service (elastic#60574) fix test description (elastic#60638) [SIEM] Cypress screenshots upload to google cloud (elastic#60556) [canvas/shareable_runtime] sync sass loaders with kbn/optimizer (elastic#60653) [SIEM] Fixes Modification of ML Rules (elastic#60662) [SIEM] [Case] Bulk status update, add comment avatar, id => title in breadcrumbs (elastic#60410) [Alerting] add functional tests for index threshold alertType (elastic#60597) [Ingest]EMT-248: add post action request handler and resources (elastic#60581) Return incident's url (elastic#60617) [Endpoint] TEST: GET alert details - boundary test for first alert retrieval (elastic#60320) [ML] Transforms: Fix pivot preview table mapping. (elastic#60609) [Endpoint] Log random seed for sample data CLI to console (elastic#60646) Use common event model for determining if event is v0 or v1 (elastic#60667) Disables PR Project Assigner workflow [Reporting] Allow reports to be deleted in Management > Kibana > Reporting (elastic#60077) ...

stephmilovic added 3 commits March 16, 2020 12:23

breadcrumb w case name

865807e

get user and bulk update

a7ef4bc

merge master

98b7e91

stephmilovic added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Mar 17, 2020

This was referenced Mar 17, 2020

[SIEM] [Case] Remaining Case View issues #58526

Closed

[SIEM] [Case] Remaining All Cases View issues #59041

Closed

add tests

1de036c

stephmilovic mentioned this pull request Mar 17, 2020

[SIEM] [Cases] Shell scripts and unit tests #60183

Merged

stephmilovic changed the title ~~[SIEM] [Case] [skip-ci] Bulk status update, add comment avatar, id => title in breadcrumbs~~ [SIEM] [Case] Bulk status update, add comment avatar, id => title in breadcrumbs Mar 17, 2020

stephmilovic marked this pull request as ready for review March 17, 2020 19:44

stephmilovic commented Mar 17, 2020

View reviewed changes

x-pack/legacy/plugins/siem/public/utils/route/spy_routes.tsx Show resolved Hide resolved

stephmilovic mentioned this pull request Mar 18, 2020

[SIEM] [Cases] Case closed and add user email #60463

Merged

3 tasks

cnasikas reviewed Mar 18, 2020

View reviewed changes

x-pack/legacy/plugins/siem/public/containers/case/api.ts Outdated Show resolved Hide resolved

cnasikas reviewed Mar 18, 2020

View reviewed changes

x-pack/legacy/plugins/siem/public/pages/case/components/case_view/index.tsx Outdated Show resolved Hide resolved

angorayc reviewed Mar 18, 2020

View reviewed changes

x-pack/legacy/plugins/siem/public/pages/case/components/all_cases/index.tsx Outdated Show resolved Hide resolved

angorayc reviewed Mar 18, 2020

View reviewed changes

merge master, pr changes

98f71a6

stephmilovic added 2 commits March 18, 2020 13:32

add state one more place

36a7570

Merge branch 'master' into moar-case-ui

b329dcb

stephmilovic commented Mar 18, 2020

View reviewed changes

x-pack/legacy/plugins/siem/public/pages/case/components/user_action_tree/index.tsx Outdated Show resolved Hide resolved

stephmilovic added 2 commits March 19, 2020 07:52

Merge branch 'master' into moar-case-ui

06694d8

omg jest passes

b36b4fb

stephmilovic added 2 commits March 19, 2020 10:47

fix type

11150da

fixer up

6707e91

rylnd reviewed Mar 19, 2020

View reviewed changes

angorayc approved these changes Mar 19, 2020

View reviewed changes

stephmilovic merged commit 0163a71 into elastic:master Mar 19, 2020

stephmilovic deleted the moar-case-ui branch March 19, 2020 23:08

stephmilovic added a commit to stephmilovic/kibana that referenced this pull request Mar 19, 2020

[SIEM] [Case] Bulk status update, add comment avatar, id => title in …

b7f5115

…breadcrumbs (elastic#60410)

stephmilovic mentioned this pull request Mar 19, 2020

[7.x] [SIEM] [Case] Bulk status update, add comment avatar, id => title in breadcrumbs (#60410) #60709

Merged

stephmilovic added a commit that referenced this pull request Mar 20, 2020

[SIEM] [Case] Bulk status update, add comment avatar, id => title in …

7a95a8a

…breadcrumbs (#60410) (#60709)

Conversation

stephmilovic commented Mar 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

elasticmachine commented Mar 17, 2020

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cnasikas commented Mar 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stephmilovic commented Mar 18, 2020

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Mar 19, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

stephmilovic commented Mar 17, 2020 •

edited

Loading

cnasikas commented Mar 18, 2020 •

edited

Loading