[Endpoint] TEST: GET alert details - boundary test for first alert retrieval#60320
Merged
EricDavisX merged 7 commits intoelastic:masterfrom Mar 19, 2020
Merged
[Endpoint] TEST: GET alert details - boundary test for first alert retrieval#60320EricDavisX merged 7 commits intoelastic:masterfrom
EricDavisX merged 7 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/endpoint-response (Team:Endpoint Response) |
Contributor
|
Pinging @elastic/endpoint-app-team (Feature:Endpoint) |
oatkiller
approved these changes
Mar 17, 2020
peluja1012
requested changes
Mar 17, 2020
| const nextPrevPrefix = `${nextPrevPrefixQuery}&${nextPrevPrefixDateRange}&${nextPrevPrefixSort}&${nextPrevPrefixOrder}&${nextPrevPrefixPageSize}`; | ||
|
|
||
| describe('Endpoint alert API', () => { | ||
| describe.only('Endpoint alert API', () => { |
Contributor
There was a problem hiding this comment.
Don't forget to remove the only
Contributor
Author
There was a problem hiding this comment.
yah, i thought it would have been caught in linting before the commit was successful, how did that even happen?
Contributor
Author
There was a problem hiding this comment.
pushed it up righter, now. i think i mis-understood the git processing I did... it didn't push the latest change after the commit passed, I see the mistake now tho I don't truly 'get' git in this regard, lol. thanks P.
peluja1012
approved these changes
Mar 17, 2020
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
EricDavisX
added a commit
to EricDavisX/kibana
that referenced
this pull request
Mar 20, 2020
…trieval (elastic#60320) * boundary test for first alert retrieval * boundary test for first alert retrieval cleaned up * redo merge conflict resolving for api test * redo merge conflict resolving for api test try 2 * updating to current dataset expectations Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
EricDavisX
added a commit
that referenced
this pull request
Mar 20, 2020
…trieval (#60320) (#60718) * boundary test for first alert retrieval * boundary test for first alert retrieval cleaned up * redo merge conflict resolving for api test * redo merge conflict resolving for api test try 2 * updating to current dataset expectations Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 20, 2020
…o alerting/tls-warning * 'alerting/tls-warning' of github.com:gmmorris/kibana: (32 commits) [ML] Listing all categorization wizard checks (elastic#60502) [Upgrade Assistant] First iteration of batch reindex docs (elastic#59887) [SIEM] Export timeline (elastic#58368) [SIEM] Add support for actions and throttle in Rules (elastic#59641) Fix ace a11y listener (elastic#60639) Add addInfo toast to core notifications service (elastic#60574) fix test description (elastic#60638) [SIEM] Cypress screenshots upload to google cloud (elastic#60556) [canvas/shareable_runtime] sync sass loaders with kbn/optimizer (elastic#60653) [SIEM] Fixes Modification of ML Rules (elastic#60662) [SIEM] [Case] Bulk status update, add comment avatar, id => title in breadcrumbs (elastic#60410) [Alerting] add functional tests for index threshold alertType (elastic#60597) [Ingest]EMT-248: add post action request handler and resources (elastic#60581) Return incident's url (elastic#60617) [Endpoint] TEST: GET alert details - boundary test for first alert retrieval (elastic#60320) [ML] Transforms: Fix pivot preview table mapping. (elastic#60609) [Endpoint] Log random seed for sample data CLI to console (elastic#60646) Use common event model for determining if event is v0 or v1 (elastic#60667) Disables PR Project Assigner workflow [Reporting] Allow reports to be deleted in Management > Kibana > Reporting (elastic#60077) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
copy of an existing api test which was GET'ing and asserting against the last alert in the index. This tests the first, and therefore we can assert against the 'prev' link is null and and that the 'next' alert is some valid id.
Testrail case was added for this new api test:
https://elastic.testrail.io/index.php?/cases/view/655
Checklist
n/a
For maintainers
n/a