[Reporting] Allow reports to be deleted in Management > Kibana > Reporting#60077
Merged
tsullivan merged 11 commits intoelastic:masterfrom Mar 19, 2020
Merged
Conversation
3af1f6a to
dcdb6dd
Compare
fc676e8 to
0f772f8
Compare
0f772f8 to
c1e6e3e
Compare
tsullivan
commented
Mar 17, 2020
|
|
||
| let response = await jobResponseHandler( | ||
| let response = await downloadResponseHandler( | ||
| request.pre.management.jobTypes, |
Member
Author
There was a problem hiding this comment.
Note: this block of code is pretty much duplicated below. I'm not sure if it's worth adding a helper yet, though.
Contributor
There was a problem hiding this comment.
I'm ok with dupes, might be refactoring for np later anways
tsullivan
commented
Mar 17, 2020
| }; | ||
| } | ||
|
|
||
| export function deleteJobResponseHandlerFactory( |
Member
Author
There was a problem hiding this comment.
This is essentially duplicated as the downloadJobResponseHanderFactory code, but it uses async/await
Contributor
|
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
7 tasks
| const { intl, jobsToDelete } = this.props; | ||
|
|
||
| const title = | ||
| jobsToDelete.length > 1 |
Contributor
There was a problem hiding this comment.
Nice work on multi-delete 👍
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Mar 19, 2020
…rting (elastic#60077) * [Reporting] Feature Delete Button in Job Listing * refactor listing buttons * multi-delete * confirm modal * remove unused * fix test * mock the id generator for snapshotting * simplify * add search bar above table * fix types errors
Contributor
|
Thank you very much for this feature! |
tsullivan
added a commit
that referenced
this pull request
Mar 20, 2020
…> Reporting (#60077) (#60684) * [Reporting] Allow reports to be deleted in Management > Kibana > Reporting (#60077) * [Reporting] Feature Delete Button in Job Listing * refactor listing buttons * multi-delete * confirm modal * remove unused * fix test * mock the id generator for snapshotting * simplify * add search bar above table * fix types errors * fix objecttype for 7.x
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 20, 2020
…o alerting/tls-warning * 'alerting/tls-warning' of github.com:gmmorris/kibana: (32 commits) [ML] Listing all categorization wizard checks (elastic#60502) [Upgrade Assistant] First iteration of batch reindex docs (elastic#59887) [SIEM] Export timeline (elastic#58368) [SIEM] Add support for actions and throttle in Rules (elastic#59641) Fix ace a11y listener (elastic#60639) Add addInfo toast to core notifications service (elastic#60574) fix test description (elastic#60638) [SIEM] Cypress screenshots upload to google cloud (elastic#60556) [canvas/shareable_runtime] sync sass loaders with kbn/optimizer (elastic#60653) [SIEM] Fixes Modification of ML Rules (elastic#60662) [SIEM] [Case] Bulk status update, add comment avatar, id => title in breadcrumbs (elastic#60410) [Alerting] add functional tests for index threshold alertType (elastic#60597) [Ingest]EMT-248: add post action request handler and resources (elastic#60581) Return incident's url (elastic#60617) [Endpoint] TEST: GET alert details - boundary test for first alert retrieval (elastic#60320) [ML] Transforms: Fix pivot preview table mapping. (elastic#60609) [Endpoint] Log random seed for sample data CLI to console (elastic#60646) Use common event model for determining if event is v0 or v1 (elastic#60667) Disables PR Project Assigner workflow [Reporting] Allow reports to be deleted in Management > Kibana > Reporting (elastic#60077) ...
Contributor
💔 Build FailedTest FailuresKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/transform/creation_index_pattern·ts.transform creation_index_pattern batch transform with terms+date_histogram groups and avg agg adds the aggregation entriesStandard OutStack TraceKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/transform/creation_index_pattern·ts.transform creation_index_pattern batch transform with terms+date_histogram groups and avg agg adds the aggregation entriesStandard OutStack TraceHistory
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds delete controls and a search bar to the Reporting listing.
Closes #26725
Release note: Added the ability to search and delete historical reports in Management > Kibana > Reporting.
Testing Note: we were not able to do proper IE11 testing due to current standing IE11 bugs. We'll test this feature with IE11 in early 7.7 builds.
Checklist
Delete any items that are not applicable to this PR.
[ ] Documentation was added for features that require explanation or tutorialsFor maintainers