[SIEM][Case] Merge header components by cnasikas · Pull Request #57816 · elastic/kibana

cnasikas · 2020-02-17T17:23:21Z

Summary

This PR merges the header_page_new and header_page component and creates a reusable editable title component. Many thanks to @patrykkopycinski for his amazing contribution and guidance.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility, including a check against IE11

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2020-02-17T17:52:18Z

Pinging @elastic/siem (Team:SIEM)

cnasikas · 2020-02-17T18:42:45Z

@elasticmachine merge upstream

x-pack/legacy/plugins/siem/public/pages/case/components/case_view/index.tsx

x-pack/legacy/plugins/siem/public/components/header_page/editable_title.tsx

x-pack/legacy/plugins/siem/public/components/header_page/editable_title.test.tsx

x-pack/legacy/plugins/siem/public/components/header_page/editable_title.tsx

XavierM

LGTM, good job on your first PR!!! 🚀

stephmilovic

Great work on this PR, especially unit tests @cnasikas! LGTM

cnasikas · 2020-02-19T17:04:34Z

@elasticmachine merge upstream

kibanamachine · 2020-02-19T19:06:37Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: d6c7dbb

History

💔 Build #27590 failed 09558b2c4e105dff7ed0070e782888e2fbca8805
💚 Build #27440 succeeded c3aba93
💚 Build #27224 succeeded 41e0444
💚 Build #27215 succeeded 5685597
💔 Build #27205 failed d63ee51

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Create edit node component * Accept EditNodeComponent * Switch to old header * test * Remove iconType * Remove isEditTitle * Move translations * Delete header_page_new component * Move editable title component to different folder * Update jest snapshot * Rename prop * Make EditableTitleComponent more generic * useCallback instead of inline functions in props * Hardcode titles * Move UI state inside EditableTitleComponent * Seperate title's tests * Create tests for EditableTitleComponent * useCallbacks on EditableTitle component * Create translation for aria-label in edit icon * Check if switched to edit mode after pressing submit * Test title when canceled Co-authored-by: patrykkopycinski <contact@patrykkopycinski.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* Create edit node component * Accept EditNodeComponent * Switch to old header * test * Remove iconType * Remove isEditTitle * Move translations * Delete header_page_new component * Move editable title component to different folder * Update jest snapshot * Rename prop * Make EditableTitleComponent more generic * useCallback instead of inline functions in props * Hardcode titles * Move UI state inside EditableTitleComponent * Seperate title's tests * Create tests for EditableTitleComponent * useCallbacks on EditableTitle component * Create translation for aria-label in edit icon * Check if switched to edit mode after pressing submit * Test title when canceled Co-authored-by: patrykkopycinski <contact@patrykkopycinski.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: patrykkopycinski <contact@patrykkopycinski.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* master: (136 commits) [Visualize] Remove legacy appState in visualize (elastic#57330) Use static time for tsvb rollup test (elastic#57701) [SIEM] Fix ResizeObserver polyfill (elastic#58046) [SIEM][Detection Engine] Fixes return codes where some were rule_id instead of id skip flaky suite (elastic#56816) skip flaky suite (elastic#58059) skip flaky suite (elastic#45348) migrates notification server routes to NP (elastic#57906) Moved all of the show/hide toggles outside of ordered lists. (elastic#57163) [APM] NP Migration - Moves plugin server files out of legacy (elastic#57532) [Maps][Telemetry] Migrate Maps telemetry to NP (elastic#55055) Embeddable add panel examples (elastic#57319) Fix useRequest to support query change (elastic#57723) Allow custom paths in plugin generator (elastic#57766) [SIEM][Case] Merge header components (elastic#57816) [ML] New Platform server shim: update job audit messages routes (elastic#57925) [kbn/optimizer] emit success event from reducer when all bundles cached (elastic#57945) [APM] Don’t include UI filters when fetching a specific transaction (elastic#57934) Upgrade yargs (elastic#57720) skip flaky suite (elastic#57762) (elastic#57997) (elastic#57998) ... # Conflicts: # src/plugins/advanced_settings/public/management_app/components/field/__snapshots__/field.test.tsx.snap # src/plugins/advanced_settings/public/management_app/components/field/field.tsx # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json

cnasikas and others added 9 commits February 17, 2020 19:13

Create edit node component

8316efc

Accept EditNodeComponent

3463281

Switch to old header

5186d4e

test

4b7ce66

Remove iconType

8ab31e7

Remove isEditTitle

5102907

Move translations

658440b

Delete header_page_new component

bdf0280

Move editable title component to different folder

d63ee51

cnasikas marked this pull request as ready for review February 17, 2020 17:50

cnasikas requested review from XavierM, patrykkopycinski and stephmilovic and removed request for XavierM and patrykkopycinski February 17, 2020 17:50

cnasikas added Team:SIEM v7.7.0 v8.0.0 labels Feb 17, 2020

cnasikas added the release_note:skip Skip the PR/issue when compiling release notes label Feb 17, 2020

cnasikas requested a review from XavierM February 17, 2020 17:54

Update jest snapshot

cf0a988

elasticmachine and others added 3 commits February 17, 2020 12:42

Merge branch 'master' into merge_headers

5685597

Rename prop

53f56d4

Make EditableTitleComponent more generic

41e0444

cnasikas force-pushed the merge_headers branch from ea33994 to 41e0444 Compare February 17, 2020 20:26

patrykkopycinski reviewed Feb 18, 2020

View reviewed changes

x-pack/legacy/plugins/siem/public/pages/case/components/case_view/index.tsx Outdated Show resolved Hide resolved

x-pack/legacy/plugins/siem/public/components/header_page/editable_title.tsx Outdated Show resolved Hide resolved

XavierM reviewed Feb 18, 2020

View reviewed changes

x-pack/legacy/plugins/siem/public/components/header_page/editable_title.tsx Outdated Show resolved Hide resolved

useCallback instead of inline functions in props

254475e

stephmilovic mentioned this pull request Feb 18, 2020

[SIEM] [Case] To dos #57861

Closed

cnasikas added 5 commits February 18, 2020 18:47

Hardcode titles

e65f1f9

Move UI state inside EditableTitleComponent

9651122

Seperate title's tests

0ef005d

Create tests for EditableTitleComponent

9d0a696

useCallbacks on EditableTitle component

c3aba93

XavierM reviewed Feb 18, 2020

View reviewed changes

x-pack/legacy/plugins/siem/public/components/header_page/editable_title.test.tsx Show resolved Hide resolved

XavierM reviewed Feb 18, 2020

View reviewed changes

x-pack/legacy/plugins/siem/public/components/header_page/editable_title.test.tsx Show resolved Hide resolved

XavierM reviewed Feb 18, 2020

View reviewed changes

x-pack/legacy/plugins/siem/public/components/header_page/editable_title.tsx Outdated Show resolved Hide resolved

cnasikas added 2 commits February 19, 2020 13:46

Create translation for aria-label in edit icon

4ed8b69

Check if switched to edit mode after pressing submit

9bd3547

cnasikas force-pushed the merge_headers branch from 09558b2 to 9bd3547 Compare February 19, 2020 13:34

Test title when canceled

4d940bd

XavierM approved these changes Feb 19, 2020

View reviewed changes

stephmilovic approved these changes Feb 19, 2020

View reviewed changes

Merge branch 'master' into merge_headers

d6c7dbb

cnasikas merged commit ff0d2d9 into elastic:master Feb 19, 2020

cnasikas deleted the merge_headers branch February 19, 2020 19:08

cnasikas mentioned this pull request Feb 19, 2020

[7.x] [SIEM][Case] Merge header components (#57816) #58043

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SIEM][Case] Merge header components#57816

[SIEM][Case] Merge header components#57816
cnasikas merged 23 commits intoelastic:masterfrom
cnasikas:merge_headers

cnasikas commented Feb 17, 2020 •

edited

Loading

Uh oh!

elasticmachine commented Feb 17, 2020

Uh oh!

cnasikas commented Feb 17, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

XavierM left a comment

Uh oh!

stephmilovic left a comment

Uh oh!

cnasikas commented Feb 19, 2020

Uh oh!

kibanamachine commented Feb 19, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

cnasikas commented Feb 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Feb 17, 2020

Uh oh!

cnasikas commented Feb 17, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

XavierM left a comment

Choose a reason for hiding this comment

Uh oh!

stephmilovic left a comment

Choose a reason for hiding this comment

Uh oh!

cnasikas commented Feb 19, 2020

Uh oh!

kibanamachine commented Feb 19, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

cnasikas commented Feb 17, 2020 •

edited

Loading