Moved all of the show/hide toggles outside of ordered lists.#57163
Merged
cuff-links merged 18 commits intoelastic:masterfrom Feb 19, 2020
Merged
Moved all of the show/hide toggles outside of ordered lists.#57163cuff-links merged 18 commits intoelastic:masterfrom
cuff-links merged 18 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
Contributor
|
Could you please add screenshots? |
Contributor
There was a problem hiding this comment.
@cuff-links thanks for addressing this issue! I have a couple UX suggestions for the toggle link.
- I don't think
EuiTitleis necessary around the link anymore. - I think it might look a little nicer if we reduce the bottom margin on the
<ul>so there is not as much of a gap between the list and the toggle link.
Current:
Proposed:
Contributor
Author
|
@elasticmachine merge upstream |
alisonelizabeth
requested changes
Feb 12, 2020
Contributor
alisonelizabeth
left a comment
There was a problem hiding this comment.
@cuff-links The link looks better now, but I still see the gap between the list and the link. I also noticed a regression, when I hit click "Show x more indices", the full list renders but the bullet points are no longer present.
added 3 commits
February 13, 2020 19:01
…e_Indices_Outside_List
…-links/kibana into Move_Show_Hide_Indices_Outside_List
Contributor
Author
|
This isn't done. I am coming across an error and I am really having a hard time tracking it down: |
…d implemented the general component in the pages. Also made conditional for the i18n tags.
Contributor
Author
|
@alisonelizabeth I found the issue with the error and resolved it. Please take a look at this implementation as I have never built out a component in this fashion before. The regression you mentioned above has also been addressed as there is only one implementation of the list now. |
Contributor
alisonelizabeth
left a comment
There was a problem hiding this comment.
@cuff-links this is a great start! Thanks for building out a common component.
I left a couple comments in the code. I also noticed while testing that the bullet points in the list are missing. Can you take a look?
x-pack/legacy/plugins/snapshot_restore/public/app/components/show_hide_indices.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/snapshot_restore/public/app/components/show_hide_indices.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/snapshot_restore/public/app/components/show_hide_indices.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/snapshot_restore/public/app/components/show_hide_indices.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/snapshot_restore/public/app/components/show_hide_indices.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/snapshot_restore/public/app/components/show_hide_indices.tsx
Outdated
Show resolved
Hide resolved
added 2 commits
February 14, 2020 16:48
…e_Indices_Outside_List
…the bullet points. Updated the i18n tags to be more generic. Created 2 components for formatted message.
Contributor
Author
|
@elasticmachine merge upstream |
…e_Indices_Outside_List
…-links/kibana into Move_Show_Hide_Indices_Outside_List
alisonelizabeth
approved these changes
Feb 18, 2020
Contributor
alisonelizabeth
left a comment
There was a problem hiding this comment.
Great work @cuff-links! Latest changes LGTM.
I noticed the i18n check is failing due to some unused translations. You should be able to run node scripts/i18n_check --fix to resolve this.
…e_Indices_Outside_List
Contributor
|
@elasticmachine merge upstream |
…e_Indices_Outside_List
…-links/kibana into Move_Show_Hide_Indices_Outside_List
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
cuff-links
pushed a commit
to cuff-links/kibana
that referenced
this pull request
Feb 19, 2020
…#57163) * Moved all of the show/hide toggles outside of ordered lists. * Fixed styling issues for indice list. * Fixed i10n tag that I accidentally changed. * Added component to show/hide indices. * Abstracted out some of the common parts of the Show Hide component and implemented the general component in the pages. Also made conditional for the i18n tags. * Fixed changes per comments. Restored <EuiText> to fix the issue with the bullet points. Updated the i18n tags to be more generic. Created 2 components for formatted message. * Fixed internalization issues.. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Feb 20, 2020
* master: (136 commits) [Visualize] Remove legacy appState in visualize (elastic#57330) Use static time for tsvb rollup test (elastic#57701) [SIEM] Fix ResizeObserver polyfill (elastic#58046) [SIEM][Detection Engine] Fixes return codes where some were rule_id instead of id skip flaky suite (elastic#56816) skip flaky suite (elastic#58059) skip flaky suite (elastic#45348) migrates notification server routes to NP (elastic#57906) Moved all of the show/hide toggles outside of ordered lists. (elastic#57163) [APM] NP Migration - Moves plugin server files out of legacy (elastic#57532) [Maps][Telemetry] Migrate Maps telemetry to NP (elastic#55055) Embeddable add panel examples (elastic#57319) Fix useRequest to support query change (elastic#57723) Allow custom paths in plugin generator (elastic#57766) [SIEM][Case] Merge header components (elastic#57816) [ML] New Platform server shim: update job audit messages routes (elastic#57925) [kbn/optimizer] emit success event from reducer when all bundles cached (elastic#57945) [APM] Don’t include UI filters when fetching a specific transaction (elastic#57934) Upgrade yargs (elastic#57720) skip flaky suite (elastic#57762) (elastic#57997) (elastic#57998) ... # Conflicts: # src/plugins/advanced_settings/public/management_app/components/field/__snapshots__/field.test.tsx.snap # src/plugins/advanced_settings/public/management_app/components/field/field.tsx # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json
Contributor
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
cuff-links
pushed a commit
that referenced
this pull request
Feb 21, 2020
…#58063) * Moved all of the show/hide toggles outside of ordered lists. * Fixed styling issues for indice list. * Fixed i10n tag that I accidentally changed. * Added component to show/hide indices. * Abstracted out some of the common parts of the Show Hide component and implemented the general component in the pages. Also made conditional for the i18n tags. * Fixed changes per comments. Restored <EuiText> to fix the issue with the bullet points. Updated the i18n tags to be more generic. Created 2 components for formatted message. * Fixed internalization issues.. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #44036