[Maps][Telemetry] Migrate Maps telemetry to NP by kindsun · Pull Request #55055 · elastic/kibana

kindsun · 2020-01-16T15:34:55Z

Summary

Migrates Maps telemetry to NP and typescriptifies a few files.

Testing

The easiest way to test this locally is to:

Start Kibana and check the stats endpoint: http://localhost:5601/<your prepended basepath if in dev>/api/stats?extended=true
In a separate tab, go to the Maps app, create a map with 1 or 2 layers and save it
Go back to the stats endpoint tab and refresh. maps_telemetry > maps_total_count should have increased by one. Depending on what other maps you have saved, the other metrics with min, max, avg will likely also have changed

…elemetry

elasticmachine · 2020-01-16T15:34:57Z

Pinging @elastic/kibana-gis (Team:Geo)

…elemetry

elasticmachine · 2020-02-06T20:02:59Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 1a273a9e9b8f8ee6ebbe9f69422ef3ca377c84ae

History

💔 Build #20856 failed ab92610

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

elasticmachine · 2020-02-06T22:29:19Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: b3bcc3c

History

💔 Build #25015 failed 1a273a9e9b8f8ee6ebbe9f69422ef3ca377c84ae
💔 Build #20856 failed ab92610

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Bamieh

LGTM

Bamieh · 2020-02-10T12:36:42Z

@elasticmachine merge upstream

thomasneirynck

thanks @aaronjcaldwell

Most comments are wrt adding types for that introduction of the TypeScript module.

x-pack/legacy/plugins/maps/index.js

x-pack/legacy/plugins/maps/server/maps_telemetry/collectors/register.ts

x-pack/legacy/plugins/maps/server/maps_telemetry/maps_telemetry.ts

…elemetry

…/kibana into np-migrate-maps-telemetry

…elemetry

…peCount. Set return type on reduce function

…ndex pattern saved objects

…elemetry

thomasneirynck

awesome! Thanks for making the effort and typing all the interaction points.

Some minor suggestion wrt organizing the definitions.

x-pack/legacy/plugins/maps/common/descriptor_types.d.ts

x-pack/legacy/plugins/maps/server/maps_telemetry/maps_telemetry.ts

kibanamachine · 2020-02-19T20:29:31Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 3e416ce

History

💔 Build #27517 failed 51e47fe
💚 Build #27499 succeeded 3bf9c38
💚 Build #25546 succeeded 1ac70b9
💚 Build #25078 succeeded b3bcc3c
💔 Build #25015 failed 1a273a9e9b8f8ee6ebbe9f69422ef3ca377c84ae

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Move maps telemetry to NP. Some clean-up, some ts conversion * Update naming & org to be more in-line with guidelines * Get TELEMETRY_TYPE from constants * Ignore ts error importing from js file * Set original array type passed into the function to array of ILayerTypeCount. Set return type on reduce function * Remove unneeded 'any' types where used. Add in interfaces for map & index pattern saved objects * Review feedback. Add layer, source, map saved object types and use * Review feedback. Updates based on type check Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* Move maps telemetry to NP. Some clean-up, some ts conversion * Update naming & org to be more in-line with guidelines * Get TELEMETRY_TYPE from constants * Ignore ts error importing from js file * Set original array type passed into the function to array of ILayerTypeCount. Set return type on reduce function * Remove unneeded 'any' types where used. Add in interfaces for map & index pattern saved objects * Review feedback. Add layer, source, map saved object types and use * Review feedback. Updates based on type check Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* master: (136 commits) [Visualize] Remove legacy appState in visualize (elastic#57330) Use static time for tsvb rollup test (elastic#57701) [SIEM] Fix ResizeObserver polyfill (elastic#58046) [SIEM][Detection Engine] Fixes return codes where some were rule_id instead of id skip flaky suite (elastic#56816) skip flaky suite (elastic#58059) skip flaky suite (elastic#45348) migrates notification server routes to NP (elastic#57906) Moved all of the show/hide toggles outside of ordered lists. (elastic#57163) [APM] NP Migration - Moves plugin server files out of legacy (elastic#57532) [Maps][Telemetry] Migrate Maps telemetry to NP (elastic#55055) Embeddable add panel examples (elastic#57319) Fix useRequest to support query change (elastic#57723) Allow custom paths in plugin generator (elastic#57766) [SIEM][Case] Merge header components (elastic#57816) [ML] New Platform server shim: update job audit messages routes (elastic#57925) [kbn/optimizer] emit success event from reducer when all bundles cached (elastic#57945) [APM] Don’t include UI filters when fetching a specific transaction (elastic#57934) Upgrade yargs (elastic#57720) skip flaky suite (elastic#57762) (elastic#57997) (elastic#57998) ... # Conflicts: # src/plugins/advanced_settings/public/management_app/components/field/__snapshots__/field.test.tsx.snap # src/plugins/advanced_settings/public/management_app/components/field/field.tsx # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json

Aaron Caldwell added 3 commits January 16, 2020 08:16

Move maps telemetry to NP. Some clean-up, some ts conversion

6101b54

Update naming & org to be more in-line with guidelines

e66d312

Merge remote-tracking branch 'upstream/master' into np-migrate-maps-t…

ab92610

…elemetry

kindsun added Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:Telemetry v8.0.0 Feature:NP Migration v7.6.0 labels Jan 16, 2020

kindsun added v7.7.0 and removed v7.6.0 labels Jan 22, 2020

Aaron Caldwell added 2 commits February 6, 2020 08:52

Merge remote-tracking branch 'upstream/master' into np-migrate-maps-t…

9468f9b

…elemetry

Get TELEMETRY_TYPE from constants

69c5378

kindsun marked this pull request as ready for review February 6, 2020 16:30

kindsun requested a review from a team as a code owner February 6, 2020 16:30

kindsun requested review from Bamieh and thomasneirynck February 6, 2020 16:31

kindsun added the release_note:skip Skip the PR/issue when compiling release notes label Feb 6, 2020

elastic deleted a comment from kibanamachine Feb 6, 2020

Ignore ts error importing from js file

b3bcc3c

kindsun force-pushed the np-migrate-maps-telemetry branch from 1a273a9 to b3bcc3c Compare February 6, 2020 21:10

Bamieh approved these changes Feb 10, 2020

View reviewed changes

Merge branch 'master' into np-migrate-maps-telemetry

1ac70b9

thomasneirynck reviewed Feb 12, 2020

View reviewed changes

Aaron Caldwell added 3 commits February 13, 2020 15:58

Merge remote-tracking branch 'upstream/master' into np-migrate-maps-t…

4317db1

…elemetry

Merge branch 'np-migrate-maps-telemetry' of github.com:aaronjcaldwell…

4e9282b

…/kibana into np-migrate-maps-telemetry

Merge remote-tracking branch 'upstream/master' into np-migrate-maps-t…

01ae457

…elemetry

Aaron Caldwell added 4 commits February 18, 2020 15:01

Set original array type passed into the function to array of ILayerTy…

3bf9c38

…peCount. Set return type on reduce function

Remove unneeded 'any' types where used. Add in interfaces for map & i…

51e47fe

…ndex pattern saved objects

Review feedback. Add layer, source, map saved object types and use

f59c79c

Merge remote-tracking branch 'upstream/master' into np-migrate-maps-t…

9faee3b

…elemetry

kindsun requested a review from thomasneirynck February 19, 2020 15:49

thomasneirynck approved these changes Feb 19, 2020

View reviewed changes

x-pack/legacy/plugins/maps/common/descriptor_types.d.ts Outdated Show resolved Hide resolved

x-pack/legacy/plugins/maps/server/maps_telemetry/maps_telemetry.ts Outdated Show resolved Hide resolved

Review feedback. Updates based on type check

3e416ce

kindsun merged commit ef15653 into elastic:master Feb 19, 2020

kindsun mentioned this pull request Feb 19, 2020

[7.x] [Maps][Telemetry] Migrate Maps telemetry to NP (#55055) #58052

Merged

thomasneirynck mentioned this pull request May 29, 2020

[Maps][File upload] Migrate Maps team apps to new platform #33514

Closed

26 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Maps][Telemetry] Migrate Maps telemetry to NP#55055

[Maps][Telemetry] Migrate Maps telemetry to NP#55055
kindsun merged 15 commits intoelastic:masterfrom
kindsun:np-migrate-maps-telemetry

kindsun commented Jan 16, 2020 •

edited

Loading

Uh oh!

elasticmachine commented Jan 16, 2020

Uh oh!

elasticmachine commented Feb 6, 2020

Uh oh!

elasticmachine commented Feb 6, 2020

Uh oh!

Bamieh left a comment

Uh oh!

Bamieh commented Feb 10, 2020

Uh oh!

thomasneirynck left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thomasneirynck left a comment

Uh oh!

Uh oh!

Uh oh!

kibanamachine commented Feb 19, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

kindsun commented Jan 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Uh oh!

elasticmachine commented Jan 16, 2020

Uh oh!

elasticmachine commented Feb 6, 2020

💔 Build Failed

History

Uh oh!

elasticmachine commented Feb 6, 2020

💚 Build Succeeded

History

Uh oh!

Bamieh left a comment

Choose a reason for hiding this comment

Uh oh!

Bamieh commented Feb 10, 2020

Uh oh!

thomasneirynck left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thomasneirynck left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kibanamachine commented Feb 19, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kindsun commented Jan 16, 2020 •

edited

Loading