[7.x] [SIEM][Case] Merge header components (#57816)#58043
Merged
cnasikas merged 1 commit intoelastic:7.xfrom Feb 19, 2020
Merged
[7.x] [SIEM][Case] Merge header components (#57816)#58043cnasikas merged 1 commit intoelastic:7.xfrom
cnasikas merged 1 commit intoelastic:7.xfrom
Conversation
* Create edit node component * Accept EditNodeComponent * Switch to old header * test * Remove iconType * Remove isEditTitle * Move translations * Delete header_page_new component * Move editable title component to different folder * Update jest snapshot * Rename prop * Make EditableTitleComponent more generic * useCallback instead of inline functions in props * Hardcode titles * Move UI state inside EditableTitleComponent * Seperate title's tests * Create tests for EditableTitleComponent * useCallbacks on EditableTitle component * Create translation for aria-label in edit icon * Check if switched to edit mode after pressing submit * Test title when canceled Co-authored-by: patrykkopycinski <contact@patrykkopycinski.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Contributor
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/discover/feature_controls/discover_security·ts.discover feature controls security global discover all privileges allow saving via the saved query management component popover with no query loadedStandard OutStack TraceTo update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: