[SIEM] [Detection Engine] Update status on rule details page by dhurley14 · Pull Request #55201 · elastic/kibana

dhurley14 · 2020-01-17T17:18:03Z

Summary

Fixes duplicated most recent failure appearing on failures tab when less than five failures present. Updates the status on rule details page automatically when user clicks enabled / disabled switch. Also adds refresh button to get new status on demand.

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
~~- [ ] Documentation was added for features that require explanation or tutorials~~
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

…om enabled to disabled and vice versa.

… failures

elasticmachine · 2020-01-17T17:19:17Z

Pinging @elastic/siem (Team:SIEM)

FrankHassanabad · 2020-01-17T17:30:16Z

x-pack/legacy/plugins/siem/server/lib/detection_engine/rules/update_rules.ts

+      search: rule.id,
+      searchFields: ['alertId'],
+    });
+  }


nit:

Edit, wrong operator, sorry, deleted that and added this:

const ruleCurrentStatus = savedObjectsClient != null ? await savedObjectsClient.find<IRuleSavedAttributesSavedObjectAttributes>({ type: ruleStatusSavedObjectType, perPage: 1, sortField: 'statusDate', sortOrder: 'desc', search: rule.id, searchFields: ['alertId'], }) : null;

This will remove the let

ahh nice thank you. I'll update that.

Per conversations:

Make it mandatory in TypeScript and then add it everywhere else and remove the null check altogether

…port rules route.

…ll or undefined to object' if passed null

FrankHassanabad · 2020-01-17T19:43:33Z

...ck/legacy/plugins/siem/public/pages/detection_engine/rules/components/rule_status/helpers.ts

+    ? 'danger'
+    : status === 'executing' || status === 'going to run'
+    ? 'warning'
+    : 'subdued';


nit: This would really read much cleaner with a case statement, some switch statements , and an assert never through TypeScript.

Agreed. I'll update this. Gracias.

FrankHassanabad

LGTM

…e (different situation)

FrankHassanabad · 2020-01-18T01:45:56Z

x-pack/legacy/plugins/siem/public/containers/detection_engine/signals/use_privilege_user.tsx

Nice! Thank you 👍

…ager exits because of api key error it won't write the error status so the actual status is 'going to run' on the next interval. This is more accurate than being stuck on 'executing' because of an error we don't control and can't write a status for.

…-update

kibanamachine · 2020-01-18T17:40:06Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: b76b5eb

History

💚 Build #21270 succeeded 410ea921d7b9b0b25d02e4d26041c20da65beb44
💔 Build #21264 failed 9f608cc3dc5ff8ecfb884d835980bbd68c699fa8
💚 Build #21239 succeeded 1f88860
💔 Build #21236 failed 7b84bcb
💚 Build #21143 succeeded 6a91090

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…#55201) * adds logic for returning / updating status when a rule is switched from enabled to disabled and vice versa. * update response for find rules statuses to include current status and failures * update status on demand and on enable/disable * adds ternary to allow removal of 'let' * adds savedObjectsClient to the add and upate prepackaged rules and import rules route. * fix bug where convertToSnakeCase would throw error 'cannot convert null or undefined to object' if passed null * genericize snake_case converter and updates isAuthorized to snake_case (different situation) * renaming to 'going to run' instead of executing because when task manager exits because of api key error it won't write the error status so the actual status is 'going to run' on the next interval. This is more accurate than being stuck on 'executing' because of an error we don't control and can't write a status for. * fix missed merge conflict Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>

…#55277) * adds logic for returning / updating status when a rule is switched from enabled to disabled and vice versa. * update response for find rules statuses to include current status and failures * update status on demand and on enable/disable * adds ternary to allow removal of 'let' * adds savedObjectsClient to the add and upate prepackaged rules and import rules route. * fix bug where convertToSnakeCase would throw error 'cannot convert null or undefined to object' if passed null * genericize snake_case converter and updates isAuthorized to snake_case (different situation) * renaming to 'going to run' instead of executing because when task manager exits because of api key error it won't write the error status so the actual status is 'going to run' on the next interval. This is more accurate than being stuck on 'executing' because of an error we don't control and can't write a status for. * fix missed merge conflict Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com> Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>

…#55276) * adds logic for returning / updating status when a rule is switched from enabled to disabled and vice versa. * update response for find rules statuses to include current status and failures * update status on demand and on enable/disable * adds ternary to allow removal of 'let' * adds savedObjectsClient to the add and upate prepackaged rules and import rules route. * fix bug where convertToSnakeCase would throw error 'cannot convert null or undefined to object' if passed null * genericize snake_case converter and updates isAuthorized to snake_case (different situation) * renaming to 'going to run' instead of executing because when task manager exits because of api key error it won't write the error status so the actual status is 'going to run' on the next interval. This is more accurate than being stuck on 'executing' because of an error we don't control and can't write a status for. * fix missed merge conflict Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com> Co-authored-by: Xavier Mouligneau <189600+XavierM@users.noreply.github.com>

* upstream/master: (24 commits) Show error page when accessing unavailable app (elastic#54656) [ML] Improving job wizards with datafeed aggregations (elastic#55180) remove flaly assetion. a license presence tested anyway (elastic#55289) fix commonly used ranges uptime (elastic#54930) [SIEM] Use proper icons on Detections view (elastic#55215) Fix: invalid translation referenced (elastic#54901) [State Management] Remove AppState from edit_index_pattern page (elastic#54104) Implements `getStartServices` on server-side (elastic#55156) Move vis_vega_type/data_model tests to jest (elastic#55186) [SIEM] [Detection Engine] Update status on rule details page (elastic#55201) Fix KQL value suggestions for nested fields (elastic#54820) Enforce camelCase format for a plugin id (elastic#53759) [SIEM] Detection engine cleanup for rule details/creation/edit page (elastic#55069) Remove nested root from index pattern (elastic#54978) [Reporting/Migration] ReportingSetup, LegacySetup (elastic#54198) [SIEM] [Detection Engine] Fixes duplicate rule action (elastic#55252) [SIEM] Detections add alert & signal tab (elastic#55127) Management API - redirect on disabled app path (elastic#55136) [SIEM][Detection Engine] Fixes critical regression on the backend with immutable and tags update local (elastic#55177) ...

* master: (108 commits) [ML] Single Metric Viewer: Fix job check. (elastic#55191) Show error page when accessing unavailable app (elastic#54656) [ML] Improving job wizards with datafeed aggregations (elastic#55180) remove flaly assetion. a license presence tested anyway (elastic#55289) fix commonly used ranges uptime (elastic#54930) [SIEM] Use proper icons on Detections view (elastic#55215) Fix: invalid translation referenced (elastic#54901) [State Management] Remove AppState from edit_index_pattern page (elastic#54104) Implements `getStartServices` on server-side (elastic#55156) Move vis_vega_type/data_model tests to jest (elastic#55186) [SIEM] [Detection Engine] Update status on rule details page (elastic#55201) Fix KQL value suggestions for nested fields (elastic#54820) Enforce camelCase format for a plugin id (elastic#53759) [SIEM] Detection engine cleanup for rule details/creation/edit page (elastic#55069) Remove nested root from index pattern (elastic#54978) [Reporting/Migration] ReportingSetup, LegacySetup (elastic#54198) [SIEM] [Detection Engine] Fixes duplicate rule action (elastic#55252) [SIEM] Detections add alert & signal tab (elastic#55127) Management API - redirect on disabled app path (elastic#55136) [SIEM][Detection Engine] Fixes critical regression on the backend with immutable and tags ...

dhurley14 and others added 3 commits January 17, 2020 09:45

adds logic for returning / updating status when a rule is switched fr…

324560d

…om enabled to disabled and vice versa.

update response for find rules statuses to include current status and…

e682ec4

… failures

update status on demand and on enable/disable

635d795

dhurley14 self-assigned this Jan 17, 2020

dhurley14 added Team:SIEM v7.6.0 v7.7.0 v8.0.0 labels Jan 17, 2020

dhurley14 added the release_note:skip Skip the PR/issue when compiling release notes label Jan 17, 2020

FrankHassanabad reviewed Jan 17, 2020

View reviewed changes

dhurley14 added 4 commits January 17, 2020 12:38

adds ternary to allow removal of 'let'

dadefe7

adds savedObjectsClient to the add and upate prepackaged rules and im…

6fb3b35

…port rules route.

fix bug where convertToSnakeCase would throw error 'cannot convert nu…

6a91090

…ll or undefined to object' if passed null

Merge remote-tracking branch 'upstream/master' into fix-status-on-update

343065f

FrankHassanabad reviewed Jan 17, 2020

View reviewed changes

FrankHassanabad approved these changes Jan 17, 2020

View reviewed changes

genericize snake_case converter and updates isAuthorized to snake_cas…

fa1ab17

…e (different situation)

FrankHassanabad reviewed Jan 18, 2020

View reviewed changes

dhurley14 force-pushed the fix-status-on-update branch from 1378107 to 45971da Compare January 18, 2020 02:12

dhurley14 added 2 commits January 17, 2020 21:17

Merge with master

7b84bcb

fix missed merge conflict

1f88860

dhurley14 requested a review from a team as a code owner January 18, 2020 13:10

Merge branch 'master' of github.com:elastic/kibana into fix-status-on…

b76b5eb

…-update

XavierM force-pushed the fix-status-on-update branch from 410ea92 to b76b5eb Compare January 18, 2020 16:22

XavierM removed the request for review from a team January 18, 2020 16:22

dhurley14 merged commit 9567cca into elastic:master Jan 18, 2020

dhurley14 mentioned this pull request Jan 18, 2020

[7.x] [SIEM] [Detection Engine] Update status on rule details page (#55201) #55276

Merged

dhurley14 mentioned this pull request Jan 18, 2020

[7.6] [SIEM] [Detection Engine] Update status on rule details page (#55201) #55277

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SIEM] [Detection Engine] Update status on rule details page#55201

[SIEM] [Detection Engine] Update status on rule details page#55201
dhurley14 merged 12 commits intoelastic:masterfrom
dhurley14:fix-status-on-update

dhurley14 commented Jan 17, 2020 •

edited

Loading

Uh oh!

elasticmachine commented Jan 17, 2020

Uh oh!

FrankHassanabad Jan 17, 2020 •

edited

Loading

Uh oh!

dhurley14 Jan 17, 2020

Uh oh!

FrankHassanabad Jan 17, 2020 •

edited

Loading

Uh oh!

FrankHassanabad Jan 17, 2020

Uh oh!

dhurley14 Jan 17, 2020

Uh oh!

FrankHassanabad left a comment

Uh oh!

FrankHassanabad Jan 18, 2020

Uh oh!

kibanamachine commented Jan 18, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

dhurley14 commented Jan 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Jan 17, 2020

Uh oh!

FrankHassanabad Jan 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dhurley14 Jan 17, 2020

Choose a reason for hiding this comment

Uh oh!

FrankHassanabad Jan 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FrankHassanabad Jan 17, 2020

Choose a reason for hiding this comment

Uh oh!

dhurley14 Jan 17, 2020

Choose a reason for hiding this comment

Uh oh!

FrankHassanabad left a comment

Choose a reason for hiding this comment

Uh oh!

FrankHassanabad Jan 18, 2020

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Jan 18, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dhurley14 commented Jan 17, 2020 •

edited

Loading

FrankHassanabad Jan 17, 2020 •

edited

Loading

FrankHassanabad Jan 17, 2020 •

edited

Loading