Remove nested root from index pattern#54978
Merged
timroes merged 8 commits intoelastic:masterfrom Jan 18, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
timroes
approved these changes
Jan 17, 2020
Contributor
timroes
left a comment
There was a problem hiding this comment.
Tested on Chrome Linux, works as I would expect (no nested roots show up anymore, checked some applications that no unnecessariy fields show up, and Discover shows correct icon). Left one minor code suggestion (take it or leave it). LGTM
src/legacy/core_plugins/kibana/public/discover/np_ready/components/table/table.tsx
Outdated
Show resolved
Hide resolved
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
This was referenced Jan 18, 2020
timroes
pushed a commit
to timroes/kibana
that referenced
this pull request
Jan 18, 2020
* Revert "Add label and icon to nested fields in the doc table (elastic#54199)" This reverts commit f77b362 * Apply label and icon to nested fields in the doc table * Add nested type to field_icon * Improve nested test and add comment * Fix tests * Always pass the field type
timroes
pushed a commit
to timroes/kibana
that referenced
this pull request
Jan 18, 2020
* Revert "Add label and icon to nested fields in the doc table (elastic#54199)" This reverts commit f77b362 * Apply label and icon to nested fields in the doc table * Add nested type to field_icon * Improve nested test and add comment * Fix tests * Always pass the field type
timroes
pushed a commit
that referenced
this pull request
Jan 18, 2020
* Revert "Add label and icon to nested fields in the doc table (#54199)" This reverts commit f77b362 * Apply label and icon to nested fields in the doc table * Add nested type to field_icon * Improve nested test and add comment * Fix tests * Always pass the field type Co-authored-by: Matt Bargar <mbargar@gmail.com>
timroes
pushed a commit
that referenced
this pull request
Jan 18, 2020
* Revert "Add label and icon to nested fields in the doc table (#54199)" This reverts commit f77b362 * Apply label and icon to nested fields in the doc table * Add nested type to field_icon * Improve nested test and add comment * Fix tests * Always pass the field type Co-authored-by: Matt Bargar <mbargar@gmail.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 20, 2020
* upstream/master: (24 commits) Show error page when accessing unavailable app (elastic#54656) [ML] Improving job wizards with datafeed aggregations (elastic#55180) remove flaly assetion. a license presence tested anyway (elastic#55289) fix commonly used ranges uptime (elastic#54930) [SIEM] Use proper icons on Detections view (elastic#55215) Fix: invalid translation referenced (elastic#54901) [State Management] Remove AppState from edit_index_pattern page (elastic#54104) Implements `getStartServices` on server-side (elastic#55156) Move vis_vega_type/data_model tests to jest (elastic#55186) [SIEM] [Detection Engine] Update status on rule details page (elastic#55201) Fix KQL value suggestions for nested fields (elastic#54820) Enforce camelCase format for a plugin id (elastic#53759) [SIEM] Detection engine cleanup for rule details/creation/edit page (elastic#55069) Remove nested root from index pattern (elastic#54978) [Reporting/Migration] ReportingSetup, LegacySetup (elastic#54198) [SIEM] [Detection Engine] Fixes duplicate rule action (elastic#55252) [SIEM] Detections add alert & signal tab (elastic#55127) Management API - redirect on disabled app path (elastic#55136) [SIEM][Detection Engine] Fixes critical regression on the backend with immutable and tags update local (elastic#55177) ...
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 20, 2020
* master: (108 commits) [ML] Single Metric Viewer: Fix job check. (elastic#55191) Show error page when accessing unavailable app (elastic#54656) [ML] Improving job wizards with datafeed aggregations (elastic#55180) remove flaly assetion. a license presence tested anyway (elastic#55289) fix commonly used ranges uptime (elastic#54930) [SIEM] Use proper icons on Detections view (elastic#55215) Fix: invalid translation referenced (elastic#54901) [State Management] Remove AppState from edit_index_pattern page (elastic#54104) Implements `getStartServices` on server-side (elastic#55156) Move vis_vega_type/data_model tests to jest (elastic#55186) [SIEM] [Detection Engine] Update status on rule details page (elastic#55201) Fix KQL value suggestions for nested fields (elastic#54820) Enforce camelCase format for a plugin id (elastic#53759) [SIEM] Detection engine cleanup for rule details/creation/edit page (elastic#55069) Remove nested root from index pattern (elastic#54978) [Reporting/Migration] ReportingSetup, LegacySetup (elastic#54198) [SIEM] [Detection Engine] Fixes duplicate rule action (elastic#55252) [SIEM] Detections add alert & signal tab (elastic#55127) Management API - redirect on disabled app path (elastic#55136) [SIEM][Detection Engine] Fixes critical regression on the backend with immutable and tags ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We realized the addition of the nested root to the index pattern that I made in #54199 causes issues in some apps that list out all of the index pattern fields in the UI without any filtering, like maps and canvas. This PR removes those root fields. As a result I had to go back to deriving the nested fields from the info that already exists in the index pattern in order to display the icon correctly in Discover. This comes with some edge cases that I tried to explain in a comment in the code. I also filed an issue for a better long term solution that we could pursue post 7.6 #54957
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately