Skip to content

[State Management] Remove AppState from edit_index_pattern page#54104

Merged
Dosant merged 5 commits intoelastic:masterfrom
Dosant:dev/state-managment/state-sync-edit-index-pattern
Jan 20, 2020
Merged

[State Management] Remove AppState from edit_index_pattern page#54104
Dosant merged 5 commits intoelastic:masterfrom
Dosant:dev/state-managment/state-sync-edit-index-pattern

Conversation

@Dosant
Copy link
Copy Markdown
Contributor

@Dosant Dosant commented Jan 7, 2020 •
edited
Loading

Summary

Depends on #53582
Part of #44151
Replaces AppState in edit_index_pattern with state containers and state syncing utils.
In addition makes tab navigation on edit_index_pattern work with browser's undo history

Disclaimer

The edit_index_pattern page was used in our StateManagement POC as the simplest place where AppState was used.
Not sure if we actually need to apply this change or if this should wait for complete de-angularaization of edit_index_pattern.
but if we merge it - this could be an example of how to use new state containers and state syncing utils in legacy angular code.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@Dosant Dosant mentioned this pull request Jan 7, 2020
Merged
2 tasks
@Dosant Dosant force-pushed the dev/state-managment/state-sync-edit-index-pattern branch from 706ccf0 to 43957c8 Compare January 13, 2020 16:19
@Dosant Dosant force-pushed the dev/state-managment/state-sync-edit-index-pattern branch from 43957c8 to 37e01a0 Compare January 13, 2020 16:22
@Dosant Dosant changed the title [WIP][State Management] State syncing utilities - remove AppState from edit_index_pattern page [State Management] Remove AppState from edit_index_pattern page Jan 13, 2020
@Dosant Dosant requested review from a team, lukeelmers, ppisljar and streamich January 13, 2020 16:25
@Dosant Dosant added review release_note:skip Skip the PR/issue when compiling release notes Team:AppArch labels Jan 13, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jan 13, 2020

Pinging @elastic/kibana-app-arch (Team:AppArch)

@Dosant Dosant marked this pull request as ready for review January 13, 2020 16:28
@Dosant
Copy link
Copy Markdown
Contributor Author

Dosant commented Jan 13, 2020

@elasticmachine merge upstream

@streamich streamich mentioned this pull request Jan 15, 2020
Closed
30 tasks
@Dosant Dosant force-pushed the dev/state-managment/state-sync-edit-index-pattern branch from 8961302 to 3ddbe58 Compare January 15, 2020 14:21
lizozom
lizozom reviewed Jan 16, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Added a couple comments

streamich
streamich approved these changes Jan 16, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lizozom
lizozom approved these changes Jan 19, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dosant
Copy link
Copy Markdown
Contributor Author

Dosant commented Jan 20, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jan 20, 2020

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant added the v8.0.0 label Jan 20, 2020
@Dosant Dosant merged commit 940b533 into elastic:master Jan 20, 2020
@Dosant Dosant deleted the dev/state-managment/state-sync-edit-index-pattern branch January 20, 2020 10:40
@Dosant Dosant mentioned this pull request Jan 20, 2020
Merged
Dosant added a commit to Dosant/kibana that referenced this pull request Jan 20, 2020
@Dosant @elasticmachine
[State Management] Remove AppState from edit_index_pattern page (elas…
8724d11 
…tic#54104)

Replaces AppState in edit_index_pattern with state containers and state syncing utils.
In addition makes tab navigation on edit_index_pattern work with browser's undo history

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Dosant added a commit that referenced this pull request Jan 20, 2020
@Dosant
[State Management] Remove AppState from edit_index_pattern page (#54104…
f6c882e 
…) (#55294)

Replaces AppState in edit_index_pattern with state containers and state syncing utils.
In addition makes tab navigation on edit_index_pattern work with browser's undo history
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 20, 2020
@gmmorris
Merge remote-tracking branch 'upstream/master'
946183c 
* upstream/master: (24 commits)
  Show error page when accessing unavailable app (elastic#54656)
  [ML] Improving job wizards with datafeed aggregations (elastic#55180)
  remove flaly assetion. a license presence tested anyway (elastic#55289)
  fix commonly used ranges uptime (elastic#54930)
  [SIEM] Use proper icons on Detections view (elastic#55215)
  Fix: invalid translation referenced (elastic#54901)
  [State Management] Remove AppState from edit_index_pattern page (elastic#54104)
  Implements `getStartServices` on server-side (elastic#55156)
  Move vis_vega_type/data_model tests to jest (elastic#55186)
  [SIEM] [Detection Engine] Update status on rule details page (elastic#55201)
  Fix KQL value suggestions for nested fields (elastic#54820)
  Enforce camelCase format for a plugin id (elastic#53759)
  [SIEM] Detection engine cleanup for rule details/creation/edit page (elastic#55069)
  Remove nested root from index pattern (elastic#54978)
  [Reporting/Migration] ReportingSetup, LegacySetup (elastic#54198)
  [SIEM] [Detection Engine] Fixes duplicate rule action (elastic#55252)
  [SIEM] Detections add alert & signal tab (elastic#55127)
  Management API - redirect on disabled app path (elastic#55136)
  [SIEM][Detection Engine] Fixes critical regression on the backend with immutable and tags
  update local (elastic#55177)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 20, 2020
@gmmorris
Merge branch 'master' into actions/platform
fcb8803 
* master: (108 commits)
  [ML] Single Metric Viewer: Fix job check. (elastic#55191)
  Show error page when accessing unavailable app (elastic#54656)
  [ML] Improving job wizards with datafeed aggregations (elastic#55180)
  remove flaly assetion. a license presence tested anyway (elastic#55289)
  fix commonly used ranges uptime (elastic#54930)
  [SIEM] Use proper icons on Detections view (elastic#55215)
  Fix: invalid translation referenced (elastic#54901)
  [State Management] Remove AppState from edit_index_pattern page (elastic#54104)
  Implements `getStartServices` on server-side (elastic#55156)
  Move vis_vega_type/data_model tests to jest (elastic#55186)
  [SIEM] [Detection Engine] Update status on rule details page (elastic#55201)
  Fix KQL value suggestions for nested fields (elastic#54820)
  Enforce camelCase format for a plugin id (elastic#53759)
  [SIEM] Detection engine cleanup for rule details/creation/edit page (elastic#55069)
  Remove nested root from index pattern (elastic#54978)
  [Reporting/Migration] ReportingSetup, LegacySetup (elastic#54198)
  [SIEM] [Detection Engine] Fixes duplicate rule action (elastic#55252)
  [SIEM] Detections add alert & signal tab (elastic#55127)
  Management API - redirect on disabled app path (elastic#55136)
  [SIEM][Detection Engine] Fixes critical regression on the backend with immutable and tags
  ...
@Dosant Dosant mentioned this pull request Jan 31, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ppisljar ppisljar Awaiting requested review from ppisljar

@lukeelmers lukeelmers Awaiting requested review from lukeelmers

2 more reviewers

@lizozom lizozom lizozom approved these changes

@streamich streamich streamich approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature:StateManagement release_note:skip Skip the PR/issue when compiling release notes review v7.7.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Dosant @elasticmachine @kibanamachine @lizozom @streamich @alexh97