fix bug where convertToSnakeCase would throw error 'cannot convert null or undefined to object' if passed null

dhurley14 · dhurley14 · commit 6a910901e8ba · 2020-01-17T13:47:30.000-05:00
diff --git a/x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/find_rules_status_route.ts b/x-pack/legacy/plugins/siem/server/lib/detection_engine/routes/rules/find_rules_status_route.ts
@@ -68,7 +68,10 @@ export const createFindRulesStatusRoute: Hapi.ServerRoute = {
       return {
         ...(await acc),
         [id]: {
-          current_status: convertToSnakeCase(lastFiveErrorsForId.saved_objects[0].attributes),
+          current_status:
+            lastFiveErrorsForId.saved_objects.length > 0
+              ? convertToSnakeCase(lastFiveErrorsForId.saved_objects[0].attributes)
+              : null,
           failures: lastFiveErrorsForId.saved_objects
             .slice(1)
             .map(errorItem => convertToSnakeCase(errorItem.attributes)),
diff --git a/x-pack/legacy/plugins/siem/server/lib/detection_engine/rules/types.ts b/x-pack/legacy/plugins/siem/server/lib/detection_engine/rules/types.ts
@@ -58,8 +58,8 @@ export interface IRuleStatusAttributes {
 
 export interface RuleStatusResponse {
   [key: string]: {
-    current_status: IRuleStatusAttributes;
-    failures: IRuleStatusAttributes[];
+    current_status: IRuleStatusAttributes | null | undefined;
+    failures: IRuleStatusAttributes[] | null | undefined;
   };
 }
 

Original file line number	Diff line number	Diff line change
`@@ -58,8 +58,8 @@ export interface IRuleStatusAttributes {`
`58`	`58`
`59`	`59`	`export interface RuleStatusResponse {`
`60`	`60`	`[key: string]: {`
`61`		`- current_status: IRuleStatusAttributes;`
`62`		`- failures: IRuleStatusAttributes[];`
	`61`	`+ current_status: IRuleStatusAttributes \| null \| undefined;`
	`62`	`+ failures: IRuleStatusAttributes[] \| null \| undefined;`
`63`	`63`	`};`
`64`	`64`	`}`
`65`	`65`