Deprecate chrome.navlinks.update and add documentation#54893
Merged
pgayvallet merged 7 commits intoelastic:masterfrom Jan 17, 2020
Merged
Deprecate chrome.navlinks.update and add documentation#54893pgayvallet merged 7 commits intoelastic:masterfrom
chrome.navlinks.update and add documentation#54893pgayvallet merged 7 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-platform (Team:Platform) |
Contributor
Author
|
@elasticmachine merge upstream |
This comment has been minimized.
This comment has been minimized.
mshustov
approved these changes
Jan 15, 2020
src/core/MIGRATION_EXAMPLES.md
Outdated
| ```ts | ||
| // inside your plugin's setup function | ||
| export class MyPlugin implements Plugin { | ||
| private appUpdater = new BehaviorSubject<AppUpdater>(() => ({})); |
src/core/MIGRATION_EXAMPLES.md
Outdated
| start() { | ||
| // later, when the navlink needs to be updated | ||
| if(!isAvailable) { | ||
| appUpdater.next(() => { |
Contributor
There was a problem hiding this comment.
optional: probably we should provide updated version of the legacy code from https://github.com/elastic/kibana/pull/54893/files#diff-ca730ff688cc29f7cfb77853005355a1R478-R487 ?
const updater$ = license$.pipe(
map(license => {
const { hidden, disabled } = calcStatusFor(license);
if (hidden) return { navLinkStatus: AppNavLinkStatus.hidden };
if (disabled) return { navLinkStatus: AppNavLinkStatus.disabled };
return { navLinkStatus: AppNavLinkStatus.default };
})
);
Contributor
Author
There was a problem hiding this comment.
Thanks, was looking for that.
chrome.navlinks.update and add documentation [skip-ci]chrome.navlinks.update and add documentation
Contributor
Author
|
@elasticmachine merge upstream |
This comment has been minimized.
This comment has been minimized.
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Jan 17, 2020
* add migration example on application status updater * update example with proper licensing plugin usage * fix line width
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jan 17, 2020
…t-of-legacy * 'master' of github.com:elastic/kibana: (142 commits) [Vis] Move Timelion Vis to vis_type_timelion (elastic#52069) Deprecate `chrome.navlinks.update` and add documentation (elastic#54893) [ML] Single Metric Viewer: Fix time bounds with custom strings. (elastic#55045) [Vis: Default editor] EUIficate and Reactify the sidebar (elastic#49864) [Mappings editor] Fix cannot set boolean value for "null_value" param (elastic#55015) [SIEM] Adds support for apm-* to the network map (elastic#54876) [Reporting] Define shims of legacy dependencies (elastic#54082) Resolver is overflow: hidden to prevent obscured elements from showing up (elastic#55076) Upgraded EUI to 18.2.1 (elastic#55090) [Maps] Support styles on agg fields with _of_ in name (elastic#54965) Remove xpack_main requirement, it's no longer in use (elastic#55060) Fix Snapshots Policies Alignment Issue in IE11 (elastic#54866) first rule cuts (elastic#54990) [DOCS] Adds geocentroid note to coordinate map (elastic#54389) [Canvas] Fixes the Copy Post Url link (elastic#54831) Fixes bugs with full screen filters (elastic#54792) [ML] Fix decoding in the URL state (elastic#54915) Remove redundant `x-pack/typings`. (elastic#55042) [SIEM][Detection Engine] Adds critical missing status route to prepackaged rules Generate legacy vars when rendering all applications (elastic#54768) ... # Conflicts: # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json
pgayvallet
added a commit
that referenced
this pull request
Jan 17, 2020
…5168) * add migration example on application status updater * update example with proper licensing plugin usage * fix line width
jkelastic
pushed a commit
to jkelastic/kibana
that referenced
this pull request
Jan 17, 2020
* add migration example on application status updater * update example with proper licensing plugin usage * fix line width
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 20, 2020
* upstream/master: (83 commits) [Reporting] Fix map tiles not loading by using Chrome's Remote Protocol (elastic#55137) [Data Plugin] combine autocomplete provider and suggestions provider (elastic#54451) resolves elastic#53038 - remove references to specific license levels (elastic#53858) highlighting rules should still know about url parts when in sql state (elastic#55200) [Metric] convert mocha tests to jest (elastic#54054) [skip-ci] Update vector styling docs for 7.6 UI changes and new features (elastic#55087) Fix enable API to schedule task after alert is updated (elastic#55095) chore(NA): add 7.6 branch to the list of backport branches (elastic#54998) Convert tests to jest in vis_type_timeseries/public & common folders (elastic#55023) [ML] Accessibility fix for structural markup on table rows (elastic#55075) [Mappings editor] include/exclude fields only support custom options (elastic#54949) [Vis] Move Timelion Vis to vis_type_timelion (elastic#52069) Deprecate `chrome.navlinks.update` and add documentation (elastic#54893) [ML] Single Metric Viewer: Fix time bounds with custom strings. (elastic#55045) [Vis: Default editor] EUIficate and Reactify the sidebar (elastic#49864) [Mappings editor] Fix cannot set boolean value for "null_value" param (elastic#55015) [SIEM] Adds support for apm-* to the network map (elastic#54876) [Reporting] Define shims of legacy dependencies (elastic#54082) Resolver is overflow: hidden to prevent obscured elements from showing up (elastic#55076) Upgraded EUI to 18.2.1 (elastic#55090) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #45291
chrome.navlinks.updatein favor of usingupdater$when registering an application