[Canvas] Fixes bugs with full screen filters#54792
Merged
crob611 merged 2 commits intoelastic:masterfrom Jan 16, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-canvas (Team:Canvas) |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
poffdeluxe
approved these changes
Jan 15, 2020
Contributor
poffdeluxe
left a comment
There was a problem hiding this comment.
looks good, just one question on it
| to={to} | ||
| onSelect={(...args) => { | ||
| onSelect(...args); | ||
| closePopover(); |
Contributor
There was a problem hiding this comment.
will this change close it whenever some one selects a new date or does it only do it when someone hits "apply" ?
Contributor
Author
There was a problem hiding this comment.
Correct. Just selecting dates on the calendar sets internal state. Not until you click Apply (or one of the quick select dates) does this onSelect get called.
crob611
pushed a commit
to crob611/kibana
that referenced
this pull request
Jan 16, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
crob611
pushed a commit
to crob611/kibana
that referenced
this pull request
Jan 16, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
crob611
pushed a commit
to crob611/kibana
that referenced
this pull request
Jan 16, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jan 17, 2020
…t-of-legacy * 'master' of github.com:elastic/kibana: (142 commits) [Vis] Move Timelion Vis to vis_type_timelion (elastic#52069) Deprecate `chrome.navlinks.update` and add documentation (elastic#54893) [ML] Single Metric Viewer: Fix time bounds with custom strings. (elastic#55045) [Vis: Default editor] EUIficate and Reactify the sidebar (elastic#49864) [Mappings editor] Fix cannot set boolean value for "null_value" param (elastic#55015) [SIEM] Adds support for apm-* to the network map (elastic#54876) [Reporting] Define shims of legacy dependencies (elastic#54082) Resolver is overflow: hidden to prevent obscured elements from showing up (elastic#55076) Upgraded EUI to 18.2.1 (elastic#55090) [Maps] Support styles on agg fields with _of_ in name (elastic#54965) Remove xpack_main requirement, it's no longer in use (elastic#55060) Fix Snapshots Policies Alignment Issue in IE11 (elastic#54866) first rule cuts (elastic#54990) [DOCS] Adds geocentroid note to coordinate map (elastic#54389) [Canvas] Fixes the Copy Post Url link (elastic#54831) Fixes bugs with full screen filters (elastic#54792) [ML] Fix decoding in the URL state (elastic#54915) Remove redundant `x-pack/typings`. (elastic#55042) [SIEM][Detection Engine] Adds critical missing status route to prepackaged rules Generate legacy vars when rendering all applications (elastic#54768) ... # Conflicts: # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json
crob611
pushed a commit
that referenced
this pull request
Jan 17, 2020
crob611
pushed a commit
that referenced
this pull request
Jan 17, 2020
jkelastic
pushed a commit
to jkelastic/kibana
that referenced
this pull request
Jan 17, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #52674
Fixes #43565
This knocks out a few issues around filters.
The ElementWrapper handlers were not being regenerated when the page changes. This means that when trying to find whatever filter is being interacted with, it's using the wrong active page id, so no element is found. This changes the ElementWrapper to update when the element changes, or the activePage changes.
When a new value is selected in a Time Filter, close the popover.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers