[Metric] convert mocha tests to jest by nickofthyme · Pull Request #54054 · elastic/kibana

nickofthyme · 2020-01-06T20:33:57Z

Summary

Convert all mocha tests to jest
Add fixtures/* alias to typescript
Convert remaining javascript files to typescript

Checklist

Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

flash1293

LGTM besides some small open questions

flash1293 · 2020-01-07T16:45:54Z

src/legacy/core_plugins/vis_type_metric/public/components/metric_vis_component.test.ts

  it('should set the metric label and value', function() {
-    const metrics = metricController._processTableGroups({
+    // @ts-ignore
+    const metrics = metricVis.processTableGroups({


It's a bit weird to test react components like this - could we change this to simple enzyme tests with a snapshot assertion instead? Then we don't have to call into the internal method.

flash1293 · 2020-01-07T16:49:12Z

src/legacy/core_plugins/vis_type_metric/public/metric_vis.test.ts

@@ -0,0 +1,106 @@
+/*


Does it make sense to rename this to metric_vis_type.test.ts? Just to have a mapping to the file its logic it is testing.

flash1293 · 2020-01-07T16:54:38Z

src/legacy/core_plugins/vis_type_metric/public/components/metric_vis_component.test.ts


-import expect from '@kbn/expect';
-import { MetricVisComponent } from '../components/metric_vis_controller';
+// @ts-ignore


leftover from the conversion?

flash1293 · 2020-01-07T17:04:37Z

src/legacy/core_plugins/vis_type_metric/public/components/metric_vis_component.tsx

+    const max = last<{ to: number }>(config.colorsRange).to;
+    const colors = this.getColors();
+    const labels = this.getLabels();
+    const metrics: any[] = []; // not yet typed


It's fine to postpone these types, but could you create a "dummy type" for it? export type MetricVisMetric = any and then use MetricVisMetric everywhere. By doing so it will get much easier to propagate the type through your code once it's added.

Great idea!

flash1293 · 2020-01-07T17:06:34Z

tsconfig.json

        "src/test_utils/public/*"
-      ]
+      ],
+      "fixtures/*": ["src/fixtures/*"]


Do we really need this alias? I don't know how much fixtures will be used in the future and IMHO it's better to only introduce these if they are really necessary - just using a relative import seems easier to me. But maybe I'm missing an aspect here.

Yeah, I was questioning whether to add this, but the fixtures files have the fixtures/ aliased paths in them so a relative import still fails. Do you think I should change all the paths in the fixtures files to be relative and get rid of this alias?

Ah good point. @elastic/kibana-operations do you have a suggestion?

IMHO I think we keep this for now until we phase out the fixtures completely. Mainly because I think it's strange to have a path alias in javascript that is not also in typescript.

nickofthyme · 2020-01-10T18:15:16Z

@elasticmachine merge upstream

…pm/metric-mocha-to-jest

nickofthyme · 2020-01-13T14:54:31Z

@elasticmachine merge upstream

flash1293

This LGTM - visualization still works and tests look good.

nickofthyme · 2020-01-16T01:51:13Z

@elastic/kibana-operations & @elastic/kibana-app-arch could I get a review whenever you get a chance? Thanks

lizozom

Code owner changes LGTM

nickofthyme · 2020-01-17T13:58:46Z

Hey @spalger are you ok with the operations codeowner changes?

tylersmalley

LGTM - really not sure how I feel about the fixtures but can't come up with a better solution.

nickofthyme · 2020-01-17T17:58:25Z

@tylersmalley agreed, ideally we phase them out once the mocha tests are gone. Thanks 👍

* Add fixtures/* alias to tsconfig and jest config * Convert metric tests to jest * Convert remaining js files to ts

kibanamachine · 2020-01-17T19:16:57Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: cef03ae

History

💚 Build #20943 succeeded cef03ae
💔 Build #20841 failed 3e8d869
💔 Build #20741 failed 79d9ff0
💚 Build #20674 succeeded 1c53734
💚 Build #19771 succeeded a80f077

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Add fixtures/* alias to tsconfig and jest config * Convert metric tests to jest * Convert remaining js files to ts

* upstream/master: (83 commits) [Reporting] Fix map tiles not loading by using Chrome's Remote Protocol (elastic#55137) [Data Plugin] combine autocomplete provider and suggestions provider (elastic#54451) resolves elastic#53038 - remove references to specific license levels (elastic#53858) highlighting rules should still know about url parts when in sql state (elastic#55200) [Metric] convert mocha tests to jest (elastic#54054) [skip-ci] Update vector styling docs for 7.6 UI changes and new features (elastic#55087) Fix enable API to schedule task after alert is updated (elastic#55095) chore(NA): add 7.6 branch to the list of backport branches (elastic#54998) Convert tests to jest in vis_type_timeseries/public & common folders (elastic#55023) [ML] Accessibility fix for structural markup on table rows (elastic#55075) [Mappings editor] include/exclude fields only support custom options (elastic#54949) [Vis] Move Timelion Vis to vis_type_timelion (elastic#52069) Deprecate `chrome.navlinks.update` and add documentation (elastic#54893) [ML] Single Metric Viewer: Fix time bounds with custom strings. (elastic#55045) [Vis: Default editor] EUIficate and Reactify the sidebar (elastic#49864) [Mappings editor] Fix cannot set boolean value for "null_value" param (elastic#55015) [SIEM] Adds support for apm-* to the network map (elastic#54876) [Reporting] Define shims of legacy dependencies (elastic#54082) Resolver is overflow: hidden to prevent obscured elements from showing up (elastic#55076) Upgraded EUI to 18.2.1 (elastic#55090) ...

nickofthyme added 3 commits January 6, 2020 13:12

Add fixtures/* alias to tsconfig and jest config

ecefd44

Convert metric tests to jest

da50977

Convert remaining js files to ts

8c265b6

nickofthyme requested a review from a team as a code owner January 6, 2020 20:33

nickofthyme added Feature:New Platform v7.6.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Jan 6, 2020

nickofthyme requested a review from a team January 7, 2020 15:06

flash1293 reviewed Jan 7, 2020

View reviewed changes

Address PR comments

0fd87ba

nickofthyme requested a review from a team as a code owner January 9, 2020 20:05

nickofthyme added 2 commits January 9, 2020 14:11

Merge branch 'master' into kpm/metric-mocha-to-jest

773d9c7

Fix ci test failures

deecb22

elasticmachine and others added 4 commits January 10, 2020 12:15

Merge branch 'master' into kpm/metric-mocha-to-jest

5cf78d0

Fix type errors

6da5585

Merge branch 'master' into kpm/metric-mocha-to-jest

b0ae467

Merge remote-tracking branch 'origin/kpm/metric-mocha-to-jest' into k…

9e8f1e6

…pm/metric-mocha-to-jest

nickofthyme added v7.7.0 and removed v7.6.0 labels Jan 13, 2020

Merge branch 'master' into kpm/metric-mocha-to-jest

a80f077

flash1293 approved these changes Jan 13, 2020

View reviewed changes

Merge branch 'master' into kpm/metric-mocha-to-jest

1c53734

nickofthyme added 2 commits January 15, 2020 21:07

Merge branch 'master' into kpm/metric-mocha-to-jest

79d9ff0

Fix type error

3e8d869

lizozom approved these changes Jan 16, 2020

View reviewed changes

Fix jest test error

cef03ae

tylersmalley approved these changes Jan 17, 2020

View reviewed changes

nickofthyme merged commit 119eabe into elastic:master Jan 17, 2020

nickofthyme deleted the kpm/metric-mocha-to-jest branch January 17, 2020 18:00

nickofthyme changed the title ~~Kpm/metric mocha to jest~~ [Metric] convert mocha tests to jest Jan 17, 2020

nickofthyme mentioned this pull request Jan 17, 2020

[7.x] [Metric] convert mocha tests to jest (#54054) #55210

Merged

nickofthyme added a commit to nickofthyme/kibana that referenced this pull request Jan 17, 2020

[Metric] convert mocha tests to jest (elastic#54054)

675c998

* Add fixtures/* alias to tsconfig and jest config * Convert metric tests to jest * Convert remaining js files to ts

nickofthyme added a commit that referenced this pull request Jan 17, 2020

[Metric] convert mocha tests to jest (#54054) (#55210)

dd8eaab

* Add fixtures/* alias to tsconfig and jest config * Convert metric tests to jest * Convert remaining js files to ts

Conversation

nickofthyme commented Jan 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

flash1293 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nickofthyme commented Jan 10, 2020

Uh oh!

nickofthyme commented Jan 13, 2020

Uh oh!

flash1293 left a comment

Choose a reason for hiding this comment

Uh oh!

nickofthyme commented Jan 16, 2020

Uh oh!

lizozom left a comment

Choose a reason for hiding this comment

Uh oh!

nickofthyme commented Jan 17, 2020

Uh oh!

tylersmalley left a comment

Choose a reason for hiding this comment

Uh oh!

nickofthyme commented Jan 17, 2020

Uh oh!

kibanamachine commented Jan 17, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

nickofthyme commented Jan 6, 2020 •

edited

Loading