[ML] Accessibility fix for structural markup on table rows#55075
Merged
peteharverson merged 2 commits intoelastic:masterfrom Jan 17, 2020
Merged
[ML] Accessibility fix for structural markup on table rows#55075peteharverson merged 2 commits intoelastic:masterfrom
peteharverson merged 2 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/ml-ui (:ml) |
darnautov
reviewed
Jan 17, 2020
| render?: RenderFunc; | ||
| footer?: string | ReactElement | FooterFunc; | ||
| textOnly?: boolean; | ||
| scope?: 'col' | 'row' | 'colgroup' | 'rowgroup'; |
Contributor
There was a problem hiding this comment.
is it possible to import this type from eui?
Contributor
There was a problem hiding this comment.
Looks so, it is TableHeaderCellScope
Contributor
Author
There was a problem hiding this comment.
Decided to copy those scope values locally for now. We plan to switch over to using the types which are now available in EUI, hopefully for 7.7.
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Jan 17, 2020
…5075) * [ML] Accessibility fix for structural markup on table rows * [ML] Fix type error on Transforms table cell for scope property
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Jan 17, 2020
…5075) * [ML] Accessibility fix for structural markup on table rows * [ML] Fix type error on Transforms table cell for scope property
jkelastic
pushed a commit
to jkelastic/kibana
that referenced
this pull request
Jan 17, 2020
…5075) * [ML] Accessibility fix for structural markup on table rows * [ML] Fix type error on Transforms table cell for scope property
peteharverson
added a commit
that referenced
this pull request
Jan 17, 2020
peteharverson
added a commit
that referenced
this pull request
Jan 17, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 20, 2020
* upstream/master: (83 commits) [Reporting] Fix map tiles not loading by using Chrome's Remote Protocol (elastic#55137) [Data Plugin] combine autocomplete provider and suggestions provider (elastic#54451) resolves elastic#53038 - remove references to specific license levels (elastic#53858) highlighting rules should still know about url parts when in sql state (elastic#55200) [Metric] convert mocha tests to jest (elastic#54054) [skip-ci] Update vector styling docs for 7.6 UI changes and new features (elastic#55087) Fix enable API to schedule task after alert is updated (elastic#55095) chore(NA): add 7.6 branch to the list of backport branches (elastic#54998) Convert tests to jest in vis_type_timeseries/public & common folders (elastic#55023) [ML] Accessibility fix for structural markup on table rows (elastic#55075) [Mappings editor] include/exclude fields only support custom options (elastic#54949) [Vis] Move Timelion Vis to vis_type_timelion (elastic#52069) Deprecate `chrome.navlinks.update` and add documentation (elastic#54893) [ML] Single Metric Viewer: Fix time bounds with custom strings. (elastic#55045) [Vis: Default editor] EUIficate and Reactify the sidebar (elastic#49864) [Mappings editor] Fix cannot set boolean value for "null_value" param (elastic#55015) [SIEM] Adds support for apm-* to the network map (elastic#54876) [Reporting] Define shims of legacy dependencies (elastic#54082) Resolver is overflow: hidden to prevent obscured elements from showing up (elastic#55076) Upgraded EUI to 18.2.1 (elastic#55090) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #52373, adding structural markup with
scope="row"to identify each table row for assistive technology.Checklist
For maintainers
Fixes #52373