[Logs UI] Refactor log position to hooks#53540
Merged
Zacqary merged 11 commits intoelastic:masterfrom Jan 7, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
d755a10 to
03e0230
Compare
afgomez
reviewed
Dec 27, 2019
Contributor
afgomez
left a comment
There was a problem hiding this comment.
This looks good so far. Thanks!
Let's wait until the other PR is merged before I mark it as approved
x-pack/legacy/plugins/infra/public/containers/logs/log_filter/use_log_filter_url_state.tsx
Outdated
Show resolved
Hide resolved
03e0230 to
6a94a40
Compare
This reverts commit 4e04aa0. # Conflicts: # x-pack/legacy/plugins/infra/public/containers/logs/log_filter/use_log_filter_url_state.tsx # x-pack/legacy/plugins/infra/public/pages/logs/stream/page_providers.tsx
e324628 to
d43ffcb
Compare
afgomez
approved these changes
Jan 7, 2020
Contributor
Author
|
retest |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Zacqary
added a commit
to Zacqary/kibana
that referenced
this pull request
Jan 7, 2020
* Move URL state to hook * Fix log filter URL state infinite loop * Initial refactor of log position to hooks * Simplify and reimplement controlsShouldDisplayTargetPosition * Fix live streaming * Flatten logposition destructuring * Revert "Move URL state to hook" This reverts commit 4e04aa0. # Conflicts: # x-pack/legacy/plugins/infra/public/containers/logs/log_filter/use_log_filter_url_state.tsx # x-pack/legacy/plugins/infra/public/pages/logs/stream/page_providers.tsx * Fix unused imports * Fix link-to test Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 8, 2020
* master: (55 commits) [ui/public/utils] Copy rarely used items to where they are consumed (elastic#53819) set AppArch team as an owner of the search endpoints (elastic#54131) Don't expose Elasticsearch client as Observable (elastic#53824) [SIEM] Cleanup unnecessary use of enzyme-to-json (elastic#53980) fix ui exports doc (elastic#54138) change markdown element title (elastic#54194) [Logs UI] Refactor log position to hooks (elastic#53540) [SIEM] Implement NP Plugin Setup (elastic#54030) [DOCS] Updates ML links (elastic#53613) sort renovate packages in config Spaces - fix flakey api tests (elastic#54154) Remove dependency that was causing effect to re-execute infinitely. (elastic#54160) [dev/run] expose unexpected flags as more than just names (elastic#54080) [DOCS] Moves index pattern doc to Discover (elastic#53347) [SIEM] Cleanup React imports (elastic#53981) Update eslint related packages (elastic#54107) [Uptime] Added date range filter into expanded list query (elastic#52609) [SIEM] Add react/display-name eslint rule (elastic#53107) [SIEM] Enable eslint prefer-template rule (elastic#53983) Elasticsearch snapshots automation (elastic#53706) ...
Zacqary
added a commit
that referenced
this pull request
Jan 8, 2020
* Move URL state to hook * Fix log filter URL state infinite loop * Initial refactor of log position to hooks * Simplify and reimplement controlsShouldDisplayTargetPosition * Fix live streaming * Flatten logposition destructuring * Revert "Move URL state to hook" This reverts commit 4e04aa0. # Conflicts: # x-pack/legacy/plugins/infra/public/containers/logs/log_filter/use_log_filter_url_state.tsx # x-pack/legacy/plugins/infra/public/pages/logs/stream/page_providers.tsx * Fix unused imports * Fix link-to test Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #50398
Rebuilds log position state logic within hooks, and simplifies a great deal of this logic. Also encapsulates live streaming further within the log entries hook, having it call back to the log position hook in order to scroll along with the stream. Scroll locking functionality is now exclusively in the
ScrollableLogTextStreamViewcomponent rather than in the state hook.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers