[7.x] [Logs UI] Refactor log position to hooks (#53540)#54204
Merged
Zacqary merged 1 commit intoelastic:7.xfrom Jan 8, 2020
Merged
[7.x] [Logs UI] Refactor log position to hooks (#53540)#54204Zacqary merged 1 commit intoelastic:7.xfrom
Zacqary merged 1 commit intoelastic:7.xfrom
Conversation
* Move URL state to hook * Fix log filter URL state infinite loop * Initial refactor of log position to hooks * Simplify and reimplement controlsShouldDisplayTargetPosition * Fix live streaming * Flatten logposition destructuring * Revert "Move URL state to hook" This reverts commit 4e04aa0. # Conflicts: # x-pack/legacy/plugins/infra/public/containers/logs/log_filter/use_log_filter_url_state.tsx # x-pack/legacy/plugins/infra/public/pages/logs/stream/page_providers.tsx * Fix unused imports * Fix link-to test Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: