[ui/public/utils] Copy rarely used items to where they are consumed by alexwizp · Pull Request #53819 · elastic/kibana

alexwizp · 2019-12-27T10:55:49Z

Summary

There are a few utils in src/legacy/ui/public/utils that are small and not widely used. Rather than find a "shared" place for them to live, it is probably cleaner to just copy them to the places that rely on them:

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

Closes: elastic#52841

kibanamachine · 2019-12-27T12:14:02Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 96d7ab2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

# Conflicts: # src/legacy/ui/public/vis/editors/config/editor_config_providers.ts

elasticmachine · 2020-01-03T13:56:17Z

Pinging @elastic/kibana-app-arch (Team:AppArch)

src/legacy/core_plugins/tile_map/public/tile_map_type.js

lizozom · 2020-01-05T13:41:34Z

src/legacy/ui/public/utils/collection.ts

 */
 export function move(
-  objs: object[],
+  objs: any[],


Why did you broaden the type here?

Please see tests, looks like that function works fine with primitive types too

lizozom · 2020-01-05T13:44:34Z

src/test_utils/public/simulate_keys.js

 import _ from 'lodash';
 import Bluebird from 'bluebird';
-import { keyMap } from 'ui/utils/key_map';
+import { keyMap } from 'ui/directives/key_map';


From what I'm seeing, key_map is not a directive.
So why move it there?

lizozom

Overall LGTM
Added a couple of minor comments.

alexwizp · 2020-01-06T08:22:32Z

@elasticmachine merge upstream

pgayvallet

LGTM for platform changes

streamich

Code changes LGTM.

src/legacy/ui/public/indexed_array/helpers/organize_by.test.ts

kibanamachine · 2020-01-08T09:41:21Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 8804b1c

History

💔 Build #18533 failed 2c10152b749a0681e9adb5462bfdff78087e9d32
💚 Build #17998 succeeded 867413b
💚 Build #17917 succeeded 9223e07
💔 Build #17778 failed 8f10798
💔 Build #17770 failed 1278a0c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…lastic#53819) * [ui/public/utils] Copy rarely used items to where they are consumed Closes: elastic#52841 * sort_prefix_first 👉x-pack/legacy/plugins/kuery_autocomplete * numeric 👉src/legacy/core_plugins/kibana/public/management * diff_object + tests 👉ui/state_management * function + tests 👉ui/state_management (function.js was removed!) * key_map 👉ui/directives * leastCommonMultiple 👉ui/vis * string_utils 👉ui/saved_objects * collection * parse_interval * it -> test * fix CI * fix PR comments Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* master: (55 commits) [ui/public/utils] Copy rarely used items to where they are consumed (elastic#53819) set AppArch team as an owner of the search endpoints (elastic#54131) Don't expose Elasticsearch client as Observable (elastic#53824) [SIEM] Cleanup unnecessary use of enzyme-to-json (elastic#53980) fix ui exports doc (elastic#54138) change markdown element title (elastic#54194) [Logs UI] Refactor log position to hooks (elastic#53540) [SIEM] Implement NP Plugin Setup (elastic#54030) [DOCS] Updates ML links (elastic#53613) sort renovate packages in config Spaces - fix flakey api tests (elastic#54154) Remove dependency that was causing effect to re-execute infinitely. (elastic#54160) [dev/run] expose unexpected flags as more than just names (elastic#54080) [DOCS] Moves index pattern doc to Discover (elastic#53347) [SIEM] Cleanup React imports (elastic#53981) Update eslint related packages (elastic#54107) [Uptime] Added date range filter into expanded list query (elastic#52609) [SIEM] Add react/display-name eslint rule (elastic#53107) [SIEM] Enable eslint prefer-template rule (elastic#53983) Elasticsearch snapshots automation (elastic#53706) ...

…53819) (#54233) * [ui/public/utils] Copy rarely used items to where they are consumed Closes: #52841 * sort_prefix_first 👉x-pack/legacy/plugins/kuery_autocomplete * numeric 👉src/legacy/core_plugins/kibana/public/management * diff_object + tests 👉ui/state_management * function + tests 👉ui/state_management (function.js was removed!) * key_map 👉ui/directives * leastCommonMultiple 👉ui/vis * string_utils 👉ui/saved_objects * collection * parse_interval * it -> test * fix CI * fix PR comments Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

….com:mbondyra/kibana into IS-50036_show-sum-for-a-field-with-formatter * 'IS-50036_show-sum-for-a-field-with-formatter' of github.com:mbondyra/kibana: [Telemetry] Fix license page crashing on telemetry.enabled: fa… (elastic#54174) [ui/public/utils] Copy rarely used items to where they are consumed (elastic#53819) set AppArch team as an owner of the search endpoints (elastic#54131) Don't expose Elasticsearch client as Observable (elastic#53824) [SIEM] Cleanup unnecessary use of enzyme-to-json (elastic#53980)

[ui/public/utils] Copy rarely used items to where they are consumed

96d7ab2

Closes: elastic#52841

alexwizp added 4 commits December 27, 2019 15:56

sort_prefix_first 👉x-pack/legacy/plugins/kuery_autocomplete

b321ba7

Merge remote-tracking branch 'upstream/master' into 52841

d1fe74e

numeric 👉src/legacy/core_plugins/kibana/public/management

de51dc1

diff_object + tests 👉ui/state_management

76e6f4e

alexwizp force-pushed the 52841 branch from a55bd66 to 76e6f4e Compare January 3, 2020 10:27

alexwizp added 4 commits January 3, 2020 14:49

function + tests 👉ui/state_management (function.js was removed!)

7188702

key_map 👉ui/directives

cbb4f89

leastCommonMultiple 👉ui/vis

3e91385

string_utils 👉ui/saved_objects

5ea7f93

alexwizp mentioned this pull request Jan 3, 2020

[Vis: Default editor] EUIficate and Reactify the sidebar #49864

Merged

16 tasks

alexwizp added 2 commits January 3, 2020 16:49

collection

cf73a86

Merge remote-tracking branch 'upstream/master' into 52841

c6952ab

# Conflicts: # src/legacy/ui/public/vis/editors/config/editor_config_providers.ts

alexwizp self-assigned this Jan 3, 2020

alexwizp added the Team:AppArch label Jan 3, 2020

alexwizp added v7.6.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:NP Migration review labels Jan 3, 2020

alexwizp added 2 commits January 3, 2020 17:06

parse_interval

1278a0c

it -> test

8f10798

alexwizp force-pushed the 52841 branch from ce4b5f0 to 8f10798 Compare January 3, 2020 14:19

alexwizp closed this Jan 4, 2020

alexwizp deleted the 52841 branch January 4, 2020 08:05

alexwizp restored the 52841 branch January 4, 2020 08:05

alexwizp added 2 commits January 4, 2020 11:08

Merge remote-tracking branch 'upstream/master' into 52841

2156666

fix CI

9223e07

alexwizp reopened this Jan 4, 2020

alexwizp marked this pull request as ready for review January 4, 2020 09:56

alexwizp requested review from a team as code owners January 4, 2020 09:56

alexwizp mentioned this pull request Jan 4, 2020

[ui/public/utils] Copy rarely used items to where they are consumed #52841

Closed

19 tasks

lizozom reviewed Jan 5, 2020

View reviewed changes

src/legacy/core_plugins/tile_map/public/tile_map_type.js Outdated Show resolved Hide resolved

lizozom reviewed Jan 5, 2020

View reviewed changes

lizozom approved these changes Jan 5, 2020

View reviewed changes

Merge branch 'master' into 52841

867413b

pgayvallet approved these changes Jan 6, 2020

View reviewed changes

streamich approved these changes Jan 6, 2020

View reviewed changes

src/legacy/ui/public/indexed_array/helpers/organize_by.test.ts Show resolved Hide resolved

alexwizp added 2 commits January 8, 2020 10:48

Merge remote-tracking branch 'upstream/master' into 52841

0e83c0e

fix PR comments

8804b1c

alexwizp force-pushed the 52841 branch from 2c10152 to 8804b1c Compare January 8, 2020 08:16

alexwizp merged commit 71ff2de into elastic:master Jan 8, 2020

alexwizp mentioned this pull request Jan 8, 2020

[7.x] [ui/public/utils] Copy rarely used items to where they are consumed (#53819) #54233

Merged

lukeelmers mentioned this pull request Jan 8, 2020

Dev Docs entry: ui/public & angular cleanup 7.6 #43511

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ui/public/utils] Copy rarely used items to where they are consumed#53819

[ui/public/utils] Copy rarely used items to where they are consumed#53819
alexwizp merged 18 commits intoelastic:masterfrom
alexwizp:52841

alexwizp commented Dec 27, 2019 •

edited

Loading

Uh oh!

kibanamachine commented Dec 27, 2019

Uh oh!

elasticmachine commented Jan 3, 2020

Uh oh!

Uh oh!

lizozom Jan 5, 2020

Uh oh!

alexwizp Jan 8, 2020

Uh oh!

lizozom Jan 5, 2020

Uh oh!

lizozom left a comment

Uh oh!

alexwizp commented Jan 6, 2020

Uh oh!

pgayvallet left a comment

Uh oh!

streamich left a comment

Uh oh!

Uh oh!

kibanamachine commented Jan 8, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

alexwizp commented Dec 27, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

kibanamachine commented Dec 27, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Jan 3, 2020

Uh oh!

Uh oh!

lizozom Jan 5, 2020

Choose a reason for hiding this comment

Uh oh!

alexwizp Jan 8, 2020

Choose a reason for hiding this comment

Uh oh!

lizozom Jan 5, 2020

Choose a reason for hiding this comment

Uh oh!

lizozom left a comment

Choose a reason for hiding this comment

Uh oh!

alexwizp commented Jan 6, 2020

Uh oh!

pgayvallet left a comment

Choose a reason for hiding this comment

Uh oh!

streamich left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kibanamachine commented Jan 8, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

alexwizp commented Dec 27, 2019 •

edited

Loading