Skip to content

[DOCS] Updates ML links#53613

Merged
lcawl merged 8 commits intoelastic:masterfrom
lcawl:fix-ml-links
Jan 7, 2020
Merged

[DOCS] Updates ML links#53613
lcawl merged 8 commits intoelastic:masterfrom
lcawl:fix-ml-links

Conversation

@lcawl
Copy link
Copy Markdown
Contributor

@lcawl lcawl commented Dec 19, 2019 •
edited
Loading

Summary

Related to elastic/stack-docs#777 and #53713

This PR updates links to machine learning content so that they point to the appropriate book (https://www.elastic.co/guide/en/machine-learning/master/index.html instead of https://www.elastic.co/guide/en/elastic-stack-overview/master/index.html).

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@lcawl lcawl requested a review from a team as a code owner December 19, 2019 17:37
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 19, 2019

Pinging @elastic/kibana-docs (Team:Docs)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 19, 2019

Pinging @elastic/ml-ui (:ml)

@lcawl lcawl added the release_note:skip Skip the PR/issue when compiling release notes label Dec 19, 2019
peteharverson
peteharverson reviewed Dec 20, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to edit the link to the job tips page in x-pack/legacy/plugins/ml/public/application/components/validate_job/validate_job_view.js to https://www.elastic.co/guide/en/machine-learning/${metadata.branch}/create-jobs.html#job-tips

x-pack/legacy/plugins/ml/server/models/job_validation/messages.js Outdated
Copy link
Copy Markdown
Contributor

@peteharverson peteharverson Dec 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to rebase against the changes I made in #53576, and edit all the links in this file to the previous Create anomaly detection jobs page. So the createJobsDocsUrl field I added in my PR needs to be amended to https://www.elastic.co/guide/en/machine-learning/{{version}}/create-jobs.html.

Copy link
Copy Markdown
Contributor Author

@lcawl lcawl Dec 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @peteharverson !

@lcawl
Copy link
Copy Markdown
Contributor Author

lcawl commented Dec 20, 2019

@elasticmachine merge upstream

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 20, 2019

💔 Build Failed

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl
Copy link
Copy Markdown
Contributor Author

lcawl commented Jan 6, 2020

@elasticmachine merge upstream

peteharverson
peteharverson approved these changes Jan 7, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jan 7, 2020

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl merged commit ae1fac4 into elastic:master Jan 7, 2020
@lcawl lcawl deleted the fix-ml-links branch January 7, 2020 21:07
@lcawl lcawl mentioned this pull request Jan 7, 2020
Merged
lcawl added a commit to lcawl/kibana that referenced this pull request Jan 7, 2020
@lcawl
[DOCS] Updates ML links (elastic#53613)
6ac5ddb
@lcawl lcawl added the v7.6.0 label Jan 7, 2020
lcawl added a commit that referenced this pull request Jan 8, 2020
@lcawl
[DOCS] Updates ML links (#53613) (#54193)
df2cc4b
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 8, 2020
@gmmorris
Merge branch 'master' into task-manager/schema-config
9e0c028 
* master: (55 commits)
  [ui/public/utils] Copy rarely used items to where they are consumed (elastic#53819)
  set AppArch team as an owner of the search endpoints (elastic#54131)
  Don't expose Elasticsearch client as Observable (elastic#53824)
  [SIEM] Cleanup unnecessary use of enzyme-to-json (elastic#53980)
  fix ui exports doc (elastic#54138)
  change markdown element title (elastic#54194)
  [Logs UI] Refactor log position to hooks (elastic#53540)
  [SIEM] Implement NP Plugin Setup (elastic#54030)
  [DOCS] Updates ML links (elastic#53613)
  sort renovate packages in config
  Spaces - fix flakey api tests (elastic#54154)
  Remove dependency that was causing effect to re-execute infinitely. (elastic#54160)
  [dev/run] expose unexpected flags as more than just names (elastic#54080)
  [DOCS] Moves index pattern doc to Discover (elastic#53347)
  [SIEM] Cleanup React imports (elastic#53981)
  Update eslint related packages (elastic#54107)
  [Uptime] Added date range filter into expanded list query (elastic#52609)
  [SIEM] Add react/display-name eslint rule (elastic#53107)
  [SIEM] Enable eslint prefer-template rule (elastic#53983)
  Elasticsearch snapshots automation (elastic#53706)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peteharverson peteharverson peteharverson approved these changes

Assignees

No one assigned

Labels

:ml release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.6.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lcawl @elasticmachine @kibanamachine @peteharverson