Allow User to Cleanup Repository from UI by cuff-links · Pull Request #53047 · elastic/kibana

cuff-links · 2019-12-13T21:54:10Z

Closes #43904

This PR adds an additional button to the flyout for repositories to allow for cleaning up of unreferenced data.

…g, added new repository request, type and telemetry metric.

cuff-links · 2019-12-13T21:54:54Z

@elasticmachine merge upstream

elasticmachine · 2019-12-13T21:59:14Z

Pinging @elastic/es-ui (Team:Elasticsearch UI)

cuff-links · 2019-12-13T22:01:08Z

Currently, hitting the snapshot.cleanupRepository endpoint does not run successfully and produces no error code. The docs for 7.x shows that this endpoint is in fact in the ES Javascript client. Not sure what's wrong.

src/core/server/elasticsearch/api_types.ts

… fixed a broken inport of RepositoryCleanup.

cuff-links · 2019-12-18T06:24:46Z

@elasticmachine merge upstream

…anup_Action_To_UI

…ight now so we need to get those green. Added a functional test. Need to set up kbn-es to be able to set up a file repository before being able to run the functional tests.

kibanamachine · 2019-12-21T01:24:06Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 4d2b85f

History

💚 Build #16779 succeeded c6cac4a
💚 Build #16342 succeeded 34d2a69
💔 Build #16086 failed a3f48b6
💔 Build #15549 failed bdd834f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…anup_Action_To_UI

…itory list table so that columns can be individually identified. Added functional test to allow checking the details of repositories.

…anup_Action_To_UI

kibanamachine · 2019-12-27T00:48:28Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 1296528

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2019-12-27T04:42:26Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 6ad982d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cuff-links · 2019-12-29T04:01:19Z

@elasticmachine merge upstream

cjcenizal · 2020-01-08T01:05:30Z

@alisonelizabeth I think your proposed UI/UX changes are spot-on. As long as we can still display info about the error in the callout so the user can figure out what went wrong, a danger callout will make it clearer to the user that there's a problem.

alisonelizabeth

@cuff-links thanks for the quick turnaround on addressing my comments! Retested and works great. I left a few additional comments - mostly nits - but there were a few strings missing i18n that should be addressed before merging.

...t_restore/public/app/sections/home/repository_list/repository_details/repository_details.tsx

alisonelizabeth · 2020-01-08T13:58:00Z

...t_restore/public/app/sections/home/repository_list/repository_details/repository_details.tsx

+            </div>
+          ) : (
+            <EuiCallOut
+              title="Sorry, there was an error cleaning the repository."


...t_restore/public/app/sections/home/repository_list/repository_details/repository_details.tsx

x-pack/legacy/plugins/snapshot_restore/public/app/services/http/repository_requests.ts

x-pack/test/functional/apps/snapshot_restore/home_page.ts

alisonelizabeth · 2020-01-08T14:08:29Z

x-pack/test/functional/page_objects/snapshot_restore_page.ts

+    async getRepoList() {
+      const table = await testSubjects.find('repositoryTable');
+      const rows = await table.findAllByCssSelector('[data-test-subj="row"]');
+      return await mapAsync(rows, async row => {


could you use Promise.all here instead of importing bluebird?

x-pack/legacy/plugins/snapshot_restore/__jest__/client_integration/helpers/http_requests.ts

…Bird and used Promise.all(). Fixed all nits in PR comments.

cuff-links · 2020-01-09T02:57:26Z

jenkins test this

cuff-links · 2020-01-09T03:17:44Z

@elasticmachine merge upstream

cuff-links · 2020-01-09T04:41:09Z

@alisonelizabeth I think we are good now.

...t_restore/public/app/sections/home/repository_list/repository_details/repository_details.tsx

…s/kibana into 43904_Add_Cleanup_Action_To_UI

alisonelizabeth

LGTM. Great job on this! I left one comment around your use of JSON.stringify(), but going to go ahead and approve so I don't block you.

...t_restore/public/app/sections/home/repository_list/repository_details/repository_details.tsx

…ing.

cuff-links · 2020-01-11T05:56:56Z

@elasticmachine merge upstream

kibanamachine · 2020-01-11T07:10:44Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: a8b21c7

History

💚 Build #19500 succeeded 558ff5e
💚 Build #19158 succeeded da765a0
💚 Build #18901 succeeded ce69496
💔 Build #18888 failed dae7208
💔 Build #18864 failed f61a139

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* master: (69 commits) [Graph] Fix various a11y issues (elastic#54097) Add ApplicationService app status management (elastic#50223) logs in one time (elastic#54447) Deprecate using `elasticsearch.ssl.certificate` without `elasticsearch.ssl.key` and vice versa (elastic#54392) [Optimizer] Fix a stack overflow with watch_cache when it attempts to delete very large folders. (elastic#54457) Security - Role Mappings UI (elastic#53620) [SIEM] [Detection engine] Permission II (elastic#54292) Allow User to Cleanup Repository from UI (elastic#53047) [Detection engine] Some UX for rule creation (elastic#54471) share specific instances of some ui packages (elastic#54079) [ML] APM modules configs for RUM Javascript and NodeJS (elastic#53792) [APM] Delay rendering invalid license notification (elastic#53924) [Graph] Improve error message on graph requests (elastic#54230) [ILM] Kibana should allow a min_age setting of 0ms in ILM policy phases (elastic#53719) Unit Tests for common/lib (elastic#53736) [Graph] Only show explorable fields (elastic#54101) remove linting rule exception for markdown (elastic#54232) [Monitoring] Fetch shard data more efficiently (elastic#54028) [Maps] Add hiddenLayers option to embeddable map input (elastic#54355) Pass termOrder and hasTermsAgg properties to serializeThresholdWatch function (elastic#54391) ...

* Added repository cleanup button. Added logic for spinner while loading, added new repository request, type and telemetry metric. * Added additional bindings for server side to hit the cleanup endpoint. * fix cleanup request * Added data test subject to the code editors to differentiate them and fixed a broken inport of RepositoryCleanup. * Added files for a component integration test. The tests are failing right now so we need to get those green. Added a functional test. Need to set up kbn-es to be able to set up a file repository before being able to run the functional tests. * Added change to the way data-test-subjects were created for the repository list table so that columns can be individually identified. Added functional test to allow checking the details of repositories. * Removed the jest tests for repository details until we get jest fixed. * Fixed jest test to reflect updated test subjects. * Made changes per feedback in PR comments. * Fixed i10n issues using <FormattedMessage>. Removed reference to blueBird and used Promise.all(). Fixed all nits in PR comments. * Added i10n fixes for header. * Added i10n fixes for header. * Added name parameter for i18n strings. * Removed i18n string from JSON.stringify call since it's already a string. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Alison Goryachev <alisonmllr20@gmail.com>

* Added repository cleanup button. Added logic for spinner while loading, added new repository request, type and telemetry metric.

* Added repository cleanup button. Added logic for spinner while loading, added new repository request, type and telemetry metric. * Added additional bindings for server side to hit the cleanup endpoint. * fix cleanup request * Added data test subject to the code editors to differentiate them and fixed a broken inport of RepositoryCleanup. * Added files for a component integration test. The tests are failing right now so we need to get those green. Added a functional test. Need to set up kbn-es to be able to set up a file repository before being able to run the functional tests. * Added change to the way data-test-subjects were created for the repository list table so that columns can be individually identified. Added functional test to allow checking the details of repositories. * Removed the jest tests for repository details until we get jest fixed. * Fixed jest test to reflect updated test subjects. * Made changes per feedback in PR comments. * Fixed i10n issues using <FormattedMessage>. Removed reference to blueBird and used Promise.all(). Fixed all nits in PR comments. * Added i10n fixes for header. * Added i10n fixes for header. * Added name parameter for i18n strings. * Removed i18n string from JSON.stringify call since it's already a string. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Alison Goryachev <alisonmllr20@gmail.com>

John Dorlus added 2 commits December 12, 2019 23:04

Added repository cleanup button. Added logic for spinner while loadin…

a0e1773

…g, added new repository request, type and telemetry metric.

Added additional bindings for server side to hit the cleanup endpoint.

77c9076

cuff-links requested a review from alisonelizabeth December 13, 2019 21:54

cuff-links requested a review from a team as a code owner December 13, 2019 21:54

Merge branch 'master' into 43904_Add_Cleanup_Action_To_UI

bdd834f

cuff-links added v7.6.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// labels Dec 13, 2019

cuff-links added Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI release_note:enhancement labels Dec 13, 2019

mshustov reviewed Dec 16, 2019

View reviewed changes

src/core/server/elasticsearch/api_types.ts Outdated Show resolved Hide resolved

alisonelizabeth and others added 2 commits December 17, 2019 09:15

fix cleanup request

a3f48b6

Added data test subject to the code editors to differentiate them and…

004b93f

… fixed a broken inport of RepositoryCleanup.

elasticmachine and others added 2 commits December 17, 2019 22:24

Merge branch 'master' into 43904_Add_Cleanup_Action_To_UI

34d2a69

Merge branch 'master' of github.com:elastic/kibana into 43904_Add_Cle…

c6cac4a

…anup_Action_To_UI

cuff-links added the v8.0.0 label Dec 20, 2019

cuff-links changed the title ~~43904 Allow User to Cleanup Repository from UI~~ Allow User to Cleanup Repository from UI Dec 20, 2019

Added files for a component integration test. The tests are failing r…

4d2b85f

…ight now so we need to get those green. Added a functional test. Need to set up kbn-es to be able to set up a file repository before being able to run the functional tests.

elastic deleted a comment from elasticmachine Dec 21, 2019

John Dorlus added 3 commits December 23, 2019 11:12

Merge branch 'master' of github.com:elastic/kibana into 43904_Add_Cle…

2307730

…anup_Action_To_UI

Added change to the way data-test-subjects were created for the repos…

f86725a

…itory list table so that columns can be individually identified. Added functional test to allow checking the details of repositories.

Merge branch 'master' of github.com:elastic/kibana into 43904_Add_Cle…

1296528

…anup_Action_To_UI

Removed the jest tests for repository details until we get jest fixed.

6ad982d

John Dorlus added 2 commits January 7, 2020 20:14

Fixed jest test to reflect updated test subjects.

0d0c470

Made changes per feedback in PR comments.

e9e9dbf

alisonelizabeth reviewed Jan 8, 2020

View reviewed changes

John Dorlus added 3 commits January 8, 2020 17:14

Fixed i10n issues using <FormattedMessage>. Removed reference to blue…

f61a139

…Bird and used Promise.all(). Fixed all nits in PR comments.

Added i10n fixes for header.

590a904

Added i10n fixes for header.

dae7208

Merge branch 'master' into 43904_Add_Cleanup_Action_To_UI

ce69496

alisonelizabeth reviewed Jan 9, 2020

View reviewed changes

...t_restore/public/app/sections/home/repository_list/repository_details/repository_details.tsx Outdated Show resolved Hide resolved

John Dorlus added 2 commits January 9, 2020 15:59

Added name parameter for i18n strings.

c065f88

Merge branch '43904_Add_Cleanup_Action_To_UI' of github.com:cuff-link…

da765a0

…s/kibana into 43904_Add_Cleanup_Action_To_UI

alisonelizabeth approved these changes Jan 10, 2020

View reviewed changes

...t_restore/public/app/sections/home/repository_list/repository_details/repository_details.tsx Outdated Show resolved Hide resolved

Removed i18n string from JSON.stringify call since it's already a str…

558ff5e

…ing.

Merge branch 'master' into 43904_Add_Cleanup_Action_To_UI

a8b21c7

cuff-links merged commit 10733b5 into elastic:master Jan 11, 2020

cuff-links deleted the 43904_Add_Cleanup_Action_To_UI branch January 11, 2020 07:51

cjcenizal mentioned this pull request Jan 13, 2020

[7.x] Allow User to Cleanup Repository from UI (#53047) #54616

Merged

cjcenizal added a commit that referenced this pull request Jan 13, 2020

Allow User to Cleanup Repository from UI (#53047) (#54616)

55efa3b

* Added repository cleanup button. Added logic for spinner while loading, added new repository request, type and telemetry metric.

cjcenizal mentioned this pull request Nov 8, 2021

Improve Clean Repository error message. #117947

Merged

Conversation

cuff-links commented Dec 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cuff-links commented Dec 13, 2019

Uh oh!

elasticmachine commented Dec 13, 2019

Uh oh!

cuff-links commented Dec 13, 2019

Uh oh!

Uh oh!

cuff-links commented Dec 18, 2019

Uh oh!

kibanamachine commented Dec 21, 2019

💔 Build Failed

History

Uh oh!

kibanamachine commented Dec 27, 2019

💔 Build Failed

Uh oh!

kibanamachine commented Dec 27, 2019

💚 Build Succeeded

Uh oh!

cuff-links commented Dec 29, 2019

Uh oh!

cjcenizal commented Jan 8, 2020

Uh oh!

alisonelizabeth left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alisonelizabeth Jan 8, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alisonelizabeth Jan 8, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cuff-links commented Jan 9, 2020

Uh oh!

cuff-links commented Jan 9, 2020

Uh oh!

cuff-links commented Jan 9, 2020

Uh oh!

Uh oh!

alisonelizabeth left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cuff-links commented Jan 11, 2020

Uh oh!

kibanamachine commented Jan 11, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

cuff-links commented Dec 13, 2019 •

edited

Loading