Unit Tests for common/lib#53736
Merged
timductive merged 6 commits intoelastic:masterfrom Jan 10, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-canvas (Team:Canvas) |
timductive
commented
Dec 20, 2019
Member
Author
There was a problem hiding this comment.
I'm sure there's a better way to do this...
Contributor
💔 Build Failed
To update your PR or re-run it, just comment with: |
31adcf9 to
a4839d8
Compare
Member
Author
|
@elasticmachine merge upstream |
poffdeluxe
approved these changes
Jan 8, 2020
Contributor
poffdeluxe
left a comment
There was a problem hiding this comment.
Overall looks good, just a couple of comments re:test result descriptions
Contributor
There was a problem hiding this comment.
minor but if we're switching to use the it syntax, I think we should make the descriptions match that. For example, changing invalid hex here to should return null for invalid hex values
Contributor
There was a problem hiding this comment.
same comment as the hex tests
crob611
approved these changes
Jan 8, 2020
Contributor
There was a problem hiding this comment.
This path is weird with a leading single dot. Can you just do ../../ instead?
8b72aae to
9439c3e
Compare
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
timductive
added a commit
to timductive/kibana
that referenced
this pull request
Jan 10, 2020
* converting mocha tests to jest * adding a few lib tests * adding more lib tests * moving test files and adding autocomplete tests * updating test definition * fixing import and test definitions
timductive
added a commit
that referenced
this pull request
Jan 11, 2020
* converting mocha tests to jest * adding a few lib tests * adding more lib tests * moving test files and adding autocomplete tests * updating test definition * fixing import and test definitions Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 13, 2020
* master: (69 commits) [Graph] Fix various a11y issues (elastic#54097) Add ApplicationService app status management (elastic#50223) logs in one time (elastic#54447) Deprecate using `elasticsearch.ssl.certificate` without `elasticsearch.ssl.key` and vice versa (elastic#54392) [Optimizer] Fix a stack overflow with watch_cache when it attempts to delete very large folders. (elastic#54457) Security - Role Mappings UI (elastic#53620) [SIEM] [Detection engine] Permission II (elastic#54292) Allow User to Cleanup Repository from UI (elastic#53047) [Detection engine] Some UX for rule creation (elastic#54471) share specific instances of some ui packages (elastic#54079) [ML] APM modules configs for RUM Javascript and NodeJS (elastic#53792) [APM] Delay rendering invalid license notification (elastic#53924) [Graph] Improve error message on graph requests (elastic#54230) [ILM] Kibana should allow a min_age setting of 0ms in ILM policy phases (elastic#53719) Unit Tests for common/lib (elastic#53736) [Graph] Only show explorable fields (elastic#54101) remove linting rule exception for markdown (elastic#54232) [Monitoring] Fetch shard data more efficiently (elastic#54028) [Maps] Add hiddenLayers option to embeddable map input (elastic#54355) Pass termOrder and hasTermsAgg properties to serializeThresholdWatch function (elastic#54391) ...
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 13, 2020
* master: (69 commits) [Graph] Fix various a11y issues (elastic#54097) Add ApplicationService app status management (elastic#50223) logs in one time (elastic#54447) Deprecate using `elasticsearch.ssl.certificate` without `elasticsearch.ssl.key` and vice versa (elastic#54392) [Optimizer] Fix a stack overflow with watch_cache when it attempts to delete very large folders. (elastic#54457) Security - Role Mappings UI (elastic#53620) [SIEM] [Detection engine] Permission II (elastic#54292) Allow User to Cleanup Repository from UI (elastic#53047) [Detection engine] Some UX for rule creation (elastic#54471) share specific instances of some ui packages (elastic#54079) [ML] APM modules configs for RUM Javascript and NodeJS (elastic#53792) [APM] Delay rendering invalid license notification (elastic#53924) [Graph] Improve error message on graph requests (elastic#54230) [ILM] Kibana should allow a min_age setting of 0ms in ILM policy phases (elastic#53719) Unit Tests for common/lib (elastic#53736) [Graph] Only show explorable fields (elastic#54101) remove linting rule exception for markdown (elastic#54232) [Monitoring] Fetch shard data more efficiently (elastic#54028) [Maps] Add hiddenLayers option to embeddable map input (elastic#54355) Pass termOrder and hasTermsAgg properties to serializeThresholdWatch function (elastic#54391) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adding jest tests for common/lib directory.
Closes #23076
CODE COVERAGE BEFORE:
CODE COVERAGE AFTER:
Checklist
- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers