[Maps] Add hiddenLayers option to embeddable map input#54355
Merged
crob611 merged 3 commits intoelastic:masterfrom Jan 10, 2020
Merged
[Maps] Add hiddenLayers option to embeddable map input#54355crob611 merged 3 commits intoelastic:masterfrom
crob611 merged 3 commits intoelastic:masterfrom
Conversation
nreese
reviewed
Jan 9, 2020
Contributor
nreese
left a comment
There was a problem hiding this comment.
Please update map embeddable input documentation for the new parameter at https://github.com/elastic/kibana/blob/master/x-pack/legacy/plugins/maps/public/embeddable/README.md
| }); | ||
| } | ||
|
|
||
| const hiddenLayerIds = this._store |
Contributor
There was a problem hiding this comment.
Can you please move this logic to a selector in https://github.com/elastic/kibana/blob/master/x-pack/legacy/plugins/maps/public/selectors/map_selectors.js
Contributor
Author
|
@nreese updated with changes. Let me know specifically if you think I'm handling the |
nreese
reviewed
Jan 10, 2020
Contributor
nreese
left a comment
There was a problem hiding this comment.
Thanks for creating actions and selectors. Can you please remove the now unused action TOGGLE_LAYER_VISIBLE?
| } | ||
| ); | ||
|
|
||
| export const getHiddenLayers = state => getLayerListRaw(state).filter(layer => !layer.visible); |
Contributor
There was a problem hiding this comment.
Can you use reselect for this selector definition since it needs to derive its state from getLayerListRaw?
export const getHiddenLayers = createSelector(
getLayerListRaw,
(layerDescriptorList) => {
return layerDescriptorList.filter(layer => !layer.visible);
}
);
| } | ||
|
|
||
| const hiddenLayerIds = getHiddenLayers(this._store.getState()) | ||
| .map(layer => layer.id) |
Contributor
There was a problem hiding this comment.
Can you move .map and .sort to the selector? The selector should return the data in the format needed here.
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
nreese
approved these changes
Jan 10, 2020
Contributor
nreese
left a comment
There was a problem hiding this comment.
Thanks for making all the changes
lgtm
code review
crob611
pushed a commit
to crob611/kibana
that referenced
this pull request
Jan 10, 2020
* Add hiddenLayers option to embeddable map input * Move hiddenLayers logic to actions and reducers. Adds Documentation * Address code review suggestions
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 13, 2020
* master: (69 commits) [Graph] Fix various a11y issues (elastic#54097) Add ApplicationService app status management (elastic#50223) logs in one time (elastic#54447) Deprecate using `elasticsearch.ssl.certificate` without `elasticsearch.ssl.key` and vice versa (elastic#54392) [Optimizer] Fix a stack overflow with watch_cache when it attempts to delete very large folders. (elastic#54457) Security - Role Mappings UI (elastic#53620) [SIEM] [Detection engine] Permission II (elastic#54292) Allow User to Cleanup Repository from UI (elastic#53047) [Detection engine] Some UX for rule creation (elastic#54471) share specific instances of some ui packages (elastic#54079) [ML] APM modules configs for RUM Javascript and NodeJS (elastic#53792) [APM] Delay rendering invalid license notification (elastic#53924) [Graph] Improve error message on graph requests (elastic#54230) [ILM] Kibana should allow a min_age setting of 0ms in ILM policy phases (elastic#53719) Unit Tests for common/lib (elastic#53736) [Graph] Only show explorable fields (elastic#54101) remove linting rule exception for markdown (elastic#54232) [Monitoring] Fetch shard data more efficiently (elastic#54028) [Maps] Add hiddenLayers option to embeddable map input (elastic#54355) Pass termOrder and hasTermsAgg properties to serializeThresholdWatch function (elastic#54391) ...
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 13, 2020
* master: (69 commits) [Graph] Fix various a11y issues (elastic#54097) Add ApplicationService app status management (elastic#50223) logs in one time (elastic#54447) Deprecate using `elasticsearch.ssl.certificate` without `elasticsearch.ssl.key` and vice versa (elastic#54392) [Optimizer] Fix a stack overflow with watch_cache when it attempts to delete very large folders. (elastic#54457) Security - Role Mappings UI (elastic#53620) [SIEM] [Detection engine] Permission II (elastic#54292) Allow User to Cleanup Repository from UI (elastic#53047) [Detection engine] Some UX for rule creation (elastic#54471) share specific instances of some ui packages (elastic#54079) [ML] APM modules configs for RUM Javascript and NodeJS (elastic#53792) [APM] Delay rendering invalid license notification (elastic#53924) [Graph] Improve error message on graph requests (elastic#54230) [ILM] Kibana should allow a min_age setting of 0ms in ILM policy phases (elastic#53719) Unit Tests for common/lib (elastic#53736) [Graph] Only show explorable fields (elastic#54101) remove linting rule exception for markdown (elastic#54232) [Monitoring] Fetch shard data more efficiently (elastic#54028) [Maps] Add hiddenLayers option to embeddable map input (elastic#54355) Pass termOrder and hasTermsAgg properties to serializeThresholdWatch function (elastic#54391) ...
crob611
pushed a commit
that referenced
this pull request
Jan 13, 2020
* Add hiddenLayers option to embeddable map input * Move hiddenLayers logic to actions and reducers. Adds Documentation * Address code review suggestions Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR allows a MapEmbeddable to accept a new key on its input
hiddenLayers. This array of ids are used to set the initial visibility of all of the maps layers.The use case for this is in Canvas, when a map is embedded and layers are made visible or invisible, we want capture those state changes in the expression backing the embed, so that the map can be configured and remain consistent on reloading of the workpad.
This PR only includes the changes to map embeddable, but if you would like to see it in action, you can check out this branch which integrates this with canvas so that toggling layers will be represented in the expression https://github.com/crob611/kibana/tree/map-embeddable-hidden-layers