Skip to content

[ML] Fix anomaly detection test suite#51712

Merged
pheyos merged 4 commits intoelastic:masterfrom
pheyos:fix_anomaly_detection_suite
Nov 27, 2019
Merged

[ML] Fix anomaly detection test suite#51712
pheyos merged 4 commits intoelastic:masterfrom
pheyos:fix_anomaly_detection_suite

Conversation

@pheyos
Copy link
Copy Markdown
Member

@pheyos pheyos commented Nov 26, 2019 •
edited
Loading

Summary

This PR re-enables the anomaly detection test suite and disables Firefox test execution for now. It also increases stability for clickEditDetector and removes unneeded retries.

Fixes #51669

Closes #51143
Closes #50866
Closes #50836
Closes #51521
Closes #51561

@pheyos pheyos requested a review from a team as a code owner November 26, 2019 13:22
@pheyos pheyos self-assigned this Nov 26, 2019
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 26, 2019

Pinging @elastic/ml-ui (:ml)

@pheyos pheyos added the release_note:skip Skip the PR/issue when compiling release notes label Nov 26, 2019
@pheyos
Copy link
Copy Markdown
Member Author

pheyos commented Nov 26, 2019 •
edited
Loading

Testing stability of the ML tests with 30 executions in https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/25/

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 26, 2019

💔 Build Failed

peteharverson
peteharverson approved these changes Nov 26, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 26, 2019

💚 Build Succeeded

@pheyos
Copy link
Copy Markdown
Member Author

pheyos commented Nov 26, 2019

ML tests (in x-pack ciGroup3) passed 30x here: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/25/

@pheyos
Copy link
Copy Markdown
Member Author

pheyos commented Nov 27, 2019

ML tests (in x-pack ciGroup3) passed another 30x here: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/26/

@pheyos
Copy link
Copy Markdown
Member Author

pheyos commented Nov 27, 2019

ML tests (in x-pack ciGroup3) passed another 40x here: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/27/ (the 2 failures it shows are unrelated dashboard test failures).

In summary, ML tests passed 100x in a row with the changes made in this PR.

@pheyos pheyos merged commit 93654d5 into elastic:master Nov 27, 2019
@pheyos pheyos deleted the fix_anomaly_detection_suite branch November 27, 2019 08:50
This was referenced Nov 27, 2019
Closed
Merged
pheyos added a commit to pheyos/kibana that referenced this pull request Nov 27, 2019
@pheyos
[ML] Fix anomaly detection test suite (elastic#51712)
111680e 
This PR re-enables the anomaly detection test suite and disables Firefox test execution for now. It also increases stability for `clickEditDetector` and removes unneeded retries.
pheyos added a commit that referenced this pull request Nov 27, 2019
@pheyos
[ML] Fix anomaly detection test suite (#51712) (#51795)
ef43d3d 
This PR re-enables the anomaly detection test suite and disables Firefox test execution for now. It also increases stability for `clickEditDetector` and removes unneeded retries.
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 27, 2019
@jloleysens
Merge remote-tracking branch 'upstream/7.x' into backport/7.x/pr-50163
bc6197f 
* upstream/7.x:
  Fix infinite redirect loop when multiple cookies are sent (elastic#50452) (elastic#51821)
  [Console] Proxy fallback (elastic#50185) (elastic#51814)
  Added endgame-* index and new heading 3 Elastic Endpoint SMP. (elastic#51071) (elastic#51828)
  [Maps] Added options to disable zoom, hide tool tips, widgets/overlays in embeddable maps (elastic#50663) (elastic#51811)
  Move errors and validate index pattern ⇒ NP (elastic#51805) (elastic#51831)
  [SIEM][Detection Engine] Adds ecs threat properties to rules (elastic#51782) (elastic#51827)
  [Lens] Remove client-side reference to server source code (elastic#51763) (elastic#51825)
  fixes drag and drop in tests (elastic#51806) (elastic#51813)
  [Uptime] Redesign/44541  new monitor list expanded row (elastic#46567) (elastic#51809)
  [7.x] [Telemetry] collector set to np (elastic#51618) (elastic#51787)
  [Uptime] added test for chart wrapper (elastic#50399) (elastic#51808)
  Expressions service fixes: better error and loading states handling (elastic#51183) (elastic#51800)
  Query String(Bar) Input - cleanup (elastic#51598) (elastic#51804)
  [ML] Adjust and re-enable categorization advanced wizard test (elastic#51005) (elastic#51017)
  fixes url state tests (elastic#51746) (elastic#51798)
  fixes browser field tests (elastic#51738) (elastic#51799)
  [Task Manager] Tests for the ability to run tasks of varying durations in parallel (elastic#51572) (elastic#51701)
  [ML] Fix anomaly detection test suite (elastic#51712) (elastic#51795)
  [SIEM] Fix Timeline drag and drop behavior (elastic#51558) (elastic#51793)
mbondyra added a commit to mbondyra/kibana that referenced this pull request Nov 28, 2019
@mbondyra
Merge branch 'IS-46410_remove-@kbn/ui-framework' of github.com:mbondy…
4b0ac16 
…ra/kibana into IS-46410_remove-@kbn/ui-framework

* 'IS-46410_remove-@kbn/ui-framework' of github.com:mbondyra/kibana: (49 commits)
  [ML] Re-activate after method in transform test (elastic#51815)
  [SIEM] [Detection Engine] Add edit on rule creation (elastic#51670)
  De-angularize visLegend (elastic#50613)
  [SIEM][Detection Engine] Change security model to use SIEM permissions
  [Monitoring] Sass cleanup (elastic#51100)
  Move errors and validate index pattern ⇒ NP (elastic#51805)
  fixes pagination tests (elastic#51822)
  Split legacy plugin discovery, expose SavedObjects scopedClient, wrappers, repository (elastic#48882)
  [SIEM][Detection Engine] Adds ecs threat properties to rules (elastic#51782)
  [Lens] Remove client-side reference to server source code (elastic#51763)
  Fix infinite redirect loop when multiple cookies are sent (elastic#50452)
  fixes drag and drop in tests (elastic#51806)
  [Console] Proxy fallback (elastic#50185)
  Query String(Bar) Input - cleanup (elastic#51598)
  shim visualizations plugin (elastic#50624)
  Expressions service fixes: better error and loading states handling (elastic#51183)
  fixes url state tests (elastic#51746)
  fixes browser field tests (elastic#51738)
  [ML] Fix anomaly detection test suite (elastic#51712)
  [SIEM] Fix Timeline drag and drop behavior (elastic#51558)
  ...
@pheyos pheyos mentioned this pull request Dec 3, 2019
Merged
pheyos added a commit to pheyos/kibana that referenced this pull request Dec 3, 2019
@pheyos
[ML] Fix anomaly detection test suite (elastic#51712)
d0eb714 
This PR re-enables the anomaly detection test suite and disables Firefox test execution for now. It also increases stability for `clickEditDetector` and removes unneeded retries.
pheyos added a commit that referenced this pull request Dec 3, 2019
@pheyos
[7.5] [ML] Fix anomaly detection test suite (#51712) (#52050)
3bfe9f9 
* [ML] Fix anomaly detection test suite (#51712)

This PR re-enables the anomaly detection test suite and disables Firefox test execution for now. It also increases stability for `clickEditDetector` and removes unneeded retries.

* Add retry for add detector as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peteharverson peteharverson peteharverson approved these changes

@darnautov darnautov Awaiting requested review from darnautov

Assignees

@pheyos pheyos

Labels

:ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v7.5.1 v7.6.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/machine_learning/anomaly_detection/advanced_job·ts - machine learning anomaly detection advanced job with multiple metric detectors and custom datafeed settings job cloning pre-fills detectors Failing test: Firefox XPack UI Functional Tests.x-pack/test/functional/apps/machine_learning/anomaly_detection/saved_search_job·ts - machine learning anomaly detection saved search with kuery query job creation creates the job and finishes processing Failing test: Firefox XPack UI Functional Tests.x-pack/test/functional/apps/machine_learning/anomaly_detection/saved_search_job·ts - machine learning anomaly detection saved search with kuery query job creation displays the created job in the job list Failing test: Firefox XPack UI Functional Tests.x-pack/test/functional/apps/machine_learning/anomaly_detection/saved_search_job·ts - machine learning anomaly detection saved search with filter and lucene query job creation loads the job management page Failing test: Firefox XPack UI Functional Tests.x-pack/test/functional/apps/machine_learning/anomaly_detection/saved_search_job·ts - machine learning anomaly detection saved search with filter and kuery query job creation displays the created job in the job list
Flaky Suite: machine learning anomaly detection

3 participants

@pheyos @elasticmachine @peteharverson