[Monitoring] Sass cleanup by andreadelrio · Pull Request #51100 · elastic/kibana

andreadelrio · 2019-11-19T19:21:59Z

Summary

This PR is an alternative to #44148 that excludes the Shard Legend redesign which we can leave for a later time. This PR is limited to:

Adding sass lint to Monitoring
Cleaning up unused sass code, adding better classNames
Removing Bootstrap wherever possible and replacing it with Eui
Improving Shard Legend color scheme (related to (Accessibility) - Dark Mode - Shard Allocation #39408)

Light mode (before)

Light mode (after)

Dark mode (before)

Dark mode (after)

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

[x ] This was checked for cross-browser compatibility, including a check against IE11
~~- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support~~
~~- [ ] Documentation was added for features that require explanation or tutorials~~
~~- [ ] Unit or functional tests were updated or added to match the most common scenarios~~
~~- [ ] This was checked for keyboard-only and screenreader accessibility~~

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

elasticmachine · 2019-11-19T21:25:04Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 5b39d0b

snide

Code review only. Assume monitoring team can double check the functionality.

x-pack/legacy/plugins/monitoring/public/components/chart/horizontal_legend.js

...y/plugins/monitoring/public/components/elasticsearch/shard_allocation/_shard_allocation.scss

...y/plugins/monitoring/public/components/elasticsearch/shard_allocation/components/assigned.js

x-pack/legacy/plugins/monitoring/public/components/table/_table.scss

x-pack/legacy/plugins/monitoring/public/components/chart/_chart.scss

snide · 2019-11-21T22:00:54Z

Added @cchaos as a reviewer on this since I'll be out next week.

…leanup

elasticmachine · 2019-11-25T00:28:53Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 4e4a7cb

pgayvallet · 2019-11-25T07:09:18Z

Not seeing anything owned by platform team, therefor removing from reviewers.

chrisronline

LGTM!

elasticmachine · 2019-11-27T01:07:27Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 1b46852

cchaos

Just a few small notes and I found an error.

Also, you'll need to add some PR labels to this, I can help you with that when you're ready.

x-pack/legacy/plugins/monitoring/public/components/chart/_chart.scss

...y/plugins/monitoring/public/components/elasticsearch/shard_allocation/_shard_allocation.scss

x-pack/legacy/plugins/monitoring/public/components/table/_table.scss

x-pack/legacy/plugins/monitoring/public/components/chart/horizontal_legend.js

...y/plugins/monitoring/public/components/elasticsearch/shard_allocation/_shard_allocation.scss

x-pack/legacy/plugins/monitoring/public/components/elasticsearch/nodes/nodes.js

andreadelrio · 2019-11-27T19:03:17Z

@cchaos submitted the changes. Can you help me with the labels? For my previous (related) PR I had EUI, Team:Monitoring, release_note:skip and v8.0.0.

elasticmachine · 2019-11-27T19:13:39Z

Pinging @elastic/stack-monitoring (Team:Monitoring)

andreadelrio · 2019-11-27T19:16:29Z

@elasticmachine merge upstream

@cchaos

Finished up by @cchaos

cchaos

Thanks for making those changes! 👍

elasticmachine · 2019-11-27T20:32:01Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 0dc0e62

…ra/kibana into IS-46410_remove-@kbn/ui-framework * 'IS-46410_remove-@kbn/ui-framework' of github.com:mbondyra/kibana: (49 commits) [ML] Re-activate after method in transform test (elastic#51815) [SIEM] [Detection Engine] Add edit on rule creation (elastic#51670) De-angularize visLegend (elastic#50613) [SIEM][Detection Engine] Change security model to use SIEM permissions [Monitoring] Sass cleanup (elastic#51100) Move errors and validate index pattern ⇒ NP (elastic#51805) fixes pagination tests (elastic#51822) Split legacy plugin discovery, expose SavedObjects scopedClient, wrappers, repository (elastic#48882) [SIEM][Detection Engine] Adds ecs threat properties to rules (elastic#51782) [Lens] Remove client-side reference to server source code (elastic#51763) Fix infinite redirect loop when multiple cookies are sent (elastic#50452) fixes drag and drop in tests (elastic#51806) [Console] Proxy fallback (elastic#50185) Query String(Bar) Input - cleanup (elastic#51598) shim visualizations plugin (elastic#50624) Expressions service fixes: better error and loading states handling (elastic#51183) fixes url state tests (elastic#51746) fixes browser field tests (elastic#51738) [ML] Fix anomaly detection test suite (elastic#51712) [SIEM] Fix Timeline drag and drop behavior (elastic#51558) ...

…license-management * 'master' of github.com:elastic/kibana: (48 commits) Enable alerting and actions plugin by default (elastic#51254) Fix error returned when creating an alert with ES security disabled (elastic#51639) [Discover] Improve Percy functional tests (elastic#51699) fixes timeline data providers tests (elastic#51862) [Dependencies]: upgrade react to latest v16.12.0 (elastic#51145) Allow routes to define some payload config values (elastic#50783) Move saved queries service + language switcher ⇒ NP (elastic#51812) [ML] Re-activate after method in transform test (elastic#51815) [SIEM] [Detection Engine] Add edit on rule creation (elastic#51670) De-angularize visLegend (elastic#50613) [SIEM][Detection Engine] Change security model to use SIEM permissions [Monitoring] Sass cleanup (elastic#51100) Move errors and validate index pattern ⇒ NP (elastic#51805) fixes pagination tests (elastic#51822) Split legacy plugin discovery, expose SavedObjects scopedClient, wrappers, repository (elastic#48882) [SIEM][Detection Engine] Adds ecs threat properties to rules (elastic#51782) [Lens] Remove client-side reference to server source code (elastic#51763) Fix infinite redirect loop when multiple cookies are sent (elastic#50452) fixes drag and drop in tests (elastic#51806) [Console] Proxy fallback (elastic#50185) ...

andreadelrio added 4 commits November 18, 2019 21:04

no sass lint warnings

b333620

gathering changes to sass

0b5fbb4

snaps

4e4a7cb

rename one class

5b39d0b

andreadelrio marked this pull request as ready for review November 20, 2019 18:28

andreadelrio requested a review from a team as a code owner November 20, 2019 18:28

andreadelrio requested review from chrisronline and snide November 20, 2019 18:29

snide previously requested changes Nov 20, 2019

View reviewed changes

snide requested a review from cchaos November 21, 2019 22:00

andreadelrio added 2 commits November 22, 2019 08:35

Merge remote-tracking branch 'upstream/master' into monitoring-sass-c…

beef29b

…leanup

Merge remote-tracking branch 'upstream/master' into monitoring-sass-c…

65b535a

…leanup

andreadelrio requested review from a team November 24, 2019 23:18

andreadelrio requested review from a team as code owners November 24, 2019 23:18

andreadelrio requested a review from a team November 24, 2019 23:18

andreadelrio requested review from a team as code owners November 24, 2019 23:18

andreadelrio force-pushed the monitoring-sass-cleanup branch from bd7a9ee to 4e4a7cb Compare November 24, 2019 23:22

Merge remote-tracking branch 'upstream/master' into monitoring-sass-c…

3c104da

…leanup

pgayvallet removed the request for review from a team November 25, 2019 07:08

weltenwort removed the request for review from a team November 25, 2019 11:45

jbudz requested review from a team and removed request for a team November 25, 2019 12:13

chrisronline approved these changes Nov 25, 2019

View reviewed changes

andreadelrio added 4 commits November 26, 2019 14:16

better class names and some more cleanup

94dc9ec

renamed monTitle

1e48f4e

removed unused sass class

d00e95d

removed another unused class

1b46852

cchaos suggested changes Nov 27, 2019

View reviewed changes

PR feedback

6292d22

andreadelrio requested a review from cchaos November 27, 2019 19:01

andreadelrio added EUI Team:Monitoring Stack Monitoring team labels Nov 27, 2019

andreadelrio added release_note:skip Skip the PR/issue when compiling release notes v8.0.0 v7.6.0 labels Nov 27, 2019

Merge branch 'master' into monitoring-sass-cleanup

0dc0e62

cchaos approved these changes Nov 27, 2019

View reviewed changes

andreadelrio merged commit 2ce0f78 into elastic:master Nov 27, 2019

andreadelrio mentioned this pull request Nov 27, 2019

[7.x] [Monitoring] Sass cleanup (#51100) #51846

Merged

andreadelrio added a commit that referenced this pull request Dec 3, 2019

[Monitoring] Sass cleanup (#51100)

fbf5514

Conversation

andreadelrio commented Nov 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Nov 19, 2019

💔 Build Failed

Uh oh!

snide left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

snide commented Nov 21, 2019

Uh oh!

elasticmachine commented Nov 25, 2019

💔 Build Failed

Uh oh!

pgayvallet commented Nov 25, 2019

Uh oh!

chrisronline left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Nov 27, 2019

💔 Build Failed

Uh oh!

cchaos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

andreadelrio commented Nov 27, 2019

Uh oh!

elasticmachine commented Nov 27, 2019

Uh oh!

andreadelrio commented Nov 27, 2019

Uh oh!

cchaos left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Nov 27, 2019

💚 Build Succeeded

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

andreadelrio commented Nov 19, 2019 •

edited

Loading