Query String(Bar) Input - cleanup by lizozom · Pull Request #51598 · elastic/kibana

lizozom · 2019-11-25T13:07:50Z

Summary

Part of #51023

Rename QueryBarInput to QueryStringInput
Moved typeahead to ui/typeahead
Use IIndexPattern

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

elasticmachine · 2019-11-25T13:07:53Z

Pinging @elastic/kibana-app-arch (Team:AppArch)

elasticmachine · 2019-11-25T15:09:21Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 29700cef2febc76269e831c02600749939054892

Renamed QueryBarInput to QueryStringInput Changed IndexPattern to IIndexPattern

elasticmachine · 2019-11-25T16:09:31Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: baf8872d4b41c17696272093d2a8a81da201b38a

elasticmachine · 2019-11-25T17:04:21Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 0f12b53f5a5ffcc80ee07b4b51b18b7d2f6a7f7a

cchaos

I would assume that the old import of the query_bar/components/typeahead/_index.scss is now broken somewhere as I'm not seeing an import change to ui/typeahead/_index.scss

elasticmachine · 2019-11-25T18:00:44Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 99d026c

…-string-input/cleanup

lizozom · 2019-11-25T20:51:19Z

@cchaos fixed

lizozom · 2019-11-25T20:55:42Z

@elastic/kibana-platform migration.md changes
@elastic/kibana-app import changes

cchaos

Thanks 👍

elasticmachine · 2019-11-25T22:53:05Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: c874d81

lizozom · 2019-11-26T07:38:21Z

@elasticmachine merge upstream

elasticmachine · 2019-11-26T09:40:25Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 51781a42cece45a46401f9b8b585528e143b75c1

lizozom · 2019-11-26T09:51:21Z

retest

…-string-input/cleanup

elasticmachine · 2019-11-26T11:13:52Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 0e8f680

kertal

Code LGTM 👍

kertal

Code LGTM, and now I've pressed the right button

elasticmachine · 2019-11-26T13:25:17Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: ee8db3c

elasticmachine · 2019-11-26T15:09:06Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 70aea61e06ae901eac65e7e06afae6d4f7558dbc

x-pack/legacy/plugins/graph/public/components/search_bar.tsx

…-string-input/cleanup

elasticmachine · 2019-11-27T10:44:01Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 3cfb98c

* Moved Suggestions to NP Renamed QueryBarInput to QueryStringInput Changed IndexPattern to IIndexPattern * fix import * Update snapshot * css import * scss * eslint

* upstream/7.x: Fix infinite redirect loop when multiple cookies are sent (elastic#50452) (elastic#51821) [Console] Proxy fallback (elastic#50185) (elastic#51814) Added endgame-* index and new heading 3 Elastic Endpoint SMP. (elastic#51071) (elastic#51828) [Maps] Added options to disable zoom, hide tool tips, widgets/overlays in embeddable maps (elastic#50663) (elastic#51811) Move errors and validate index pattern ⇒ NP (elastic#51805) (elastic#51831) [SIEM][Detection Engine] Adds ecs threat properties to rules (elastic#51782) (elastic#51827) [Lens] Remove client-side reference to server source code (elastic#51763) (elastic#51825) fixes drag and drop in tests (elastic#51806) (elastic#51813) [Uptime] Redesign/44541 new monitor list expanded row (elastic#46567) (elastic#51809) [7.x] [Telemetry] collector set to np (elastic#51618) (elastic#51787) [Uptime] added test for chart wrapper (elastic#50399) (elastic#51808) Expressions service fixes: better error and loading states handling (elastic#51183) (elastic#51800) Query String(Bar) Input - cleanup (elastic#51598) (elastic#51804) [ML] Adjust and re-enable categorization advanced wizard test (elastic#51005) (elastic#51017) fixes url state tests (elastic#51746) (elastic#51798) fixes browser field tests (elastic#51738) (elastic#51799) [Task Manager] Tests for the ability to run tasks of varying durations in parallel (elastic#51572) (elastic#51701) [ML] Fix anomaly detection test suite (elastic#51712) (elastic#51795) [SIEM] Fix Timeline drag and drop behavior (elastic#51558) (elastic#51793)

…ra/kibana into IS-46410_remove-@kbn/ui-framework * 'IS-46410_remove-@kbn/ui-framework' of github.com:mbondyra/kibana: (49 commits) [ML] Re-activate after method in transform test (elastic#51815) [SIEM] [Detection Engine] Add edit on rule creation (elastic#51670) De-angularize visLegend (elastic#50613) [SIEM][Detection Engine] Change security model to use SIEM permissions [Monitoring] Sass cleanup (elastic#51100) Move errors and validate index pattern ⇒ NP (elastic#51805) fixes pagination tests (elastic#51822) Split legacy plugin discovery, expose SavedObjects scopedClient, wrappers, repository (elastic#48882) [SIEM][Detection Engine] Adds ecs threat properties to rules (elastic#51782) [Lens] Remove client-side reference to server source code (elastic#51763) Fix infinite redirect loop when multiple cookies are sent (elastic#50452) fixes drag and drop in tests (elastic#51806) [Console] Proxy fallback (elastic#50185) Query String(Bar) Input - cleanup (elastic#51598) shim visualizations plugin (elastic#50624) Expressions service fixes: better error and loading states handling (elastic#51183) fixes url state tests (elastic#51746) fixes browser field tests (elastic#51738) [ML] Fix anomaly detection test suite (elastic#51712) [SIEM] Fix Timeline drag and drop behavior (elastic#51558) ...

lizozom added v8.0.0 Team:AppArch release_note:skip Skip the PR/issue when compiling release notes Feature:NP Migration v7.6.0 labels Nov 25, 2019

lizozom self-assigned this Nov 25, 2019

lizozom mentioned this pull request Nov 25, 2019

Move QueryBarInput ⇒ NP #51023

Closed

3 tasks

Liza K added 3 commits November 25, 2019 17:59

Moved Suggestions to NP

a8f2cc9

Renamed QueryBarInput to QueryStringInput Changed IndexPattern to IIndexPattern

fix import

6040347

Update snapshot

99d026c

lizozom force-pushed the newplatform/query-string-input/cleanup branch from 0f12b53 to 99d026c Compare November 25, 2019 15:59

lizozom marked this pull request as ready for review November 25, 2019 16:00

lizozom requested a review from a team November 25, 2019 16:00

lizozom requested review from a team as code owners November 25, 2019 16:00

lizozom requested a review from lukeelmers November 25, 2019 16:05

cchaos suggested changes Nov 25, 2019

View reviewed changes

Liza K added 2 commits November 25, 2019 22:44

Merge remote-tracking branch 'upstream/master' into newplatform/query…

920ac3b

…-string-input/cleanup

css import

c874d81

pgayvallet approved these changes Nov 25, 2019

View reviewed changes

cchaos approved these changes Nov 25, 2019

View reviewed changes

scss

b411543

Merge remote-tracking branch 'upstream/master' into newplatform/query…

0e8f680

…-string-input/cleanup

lizozom force-pushed the newplatform/query-string-input/cleanup branch from 51781a4 to 0e8f680 Compare November 26, 2019 09:53

kertal reviewed Nov 26, 2019

View reviewed changes

kertal self-requested a review November 26, 2019 11:25

kertal approved these changes Nov 26, 2019

View reviewed changes

Liza Katz added 2 commits November 26, 2019 13:47

Merge branch 'master' into newplatform/query-string-input/cleanup

65126f6

eslint

ee8db3c

lukeelmers approved these changes Nov 27, 2019

View reviewed changes

x-pack/legacy/plugins/graph/public/components/search_bar.tsx Outdated Show resolved Hide resolved

Merge remote-tracking branch 'upstream/master' into newplatform/query…

3cfb98c

…-string-input/cleanup

lizozom force-pushed the newplatform/query-string-input/cleanup branch from 70aea61 to 3cfb98c Compare November 27, 2019 09:29

lizozom merged commit 8797e68 into elastic:master Nov 27, 2019

lizozom mentioned this pull request Nov 27, 2019

[7.x] Query String(Bar) Input - cleanup (#51598) #51804

Merged

Conversation

lizozom commented Nov 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Nov 25, 2019

Uh oh!

elasticmachine commented Nov 25, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Nov 25, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Nov 25, 2019

💔 Build Failed

Uh oh!

cchaos left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Nov 25, 2019

💔 Build Failed

Uh oh!

lizozom commented Nov 25, 2019

Uh oh!

lizozom commented Nov 25, 2019

Uh oh!

cchaos left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Nov 25, 2019

💔 Build Failed

Uh oh!

lizozom commented Nov 26, 2019

Uh oh!

elasticmachine commented Nov 26, 2019

💔 Build Failed

Uh oh!

lizozom commented Nov 26, 2019

Uh oh!

elasticmachine commented Nov 26, 2019

💚 Build Succeeded

Uh oh!

kertal left a comment

Choose a reason for hiding this comment

Uh oh!

kertal left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Nov 26, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Nov 26, 2019

💚 Build Succeeded

Uh oh!

Uh oh!

elasticmachine commented Nov 27, 2019

💚 Build Succeeded

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

lizozom commented Nov 25, 2019 •

edited

Loading