[SIEM] Fix Timeline drag and drop behavior by patrykkopycinski · Pull Request #51558 · elastic/kibana

patrykkopycinski · 2019-11-24T22:39:48Z

Summary

https://recordit.co/Z8W3npnMKT

Fixes:

drag and drop bouncing effect
auto-scroll timeline field dragging issue

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

elasticmachine · 2019-11-24T22:41:03Z

Pinging @elastic/siem (Team:SIEM)

elasticmachine · 2019-11-25T00:04:21Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: a78786a

…line-drag-and-drop # Conflicts: # package.json

elasticmachine · 2019-11-25T10:06:22Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 48fb916

elasticmachine · 2019-11-25T11:29:56Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 03cab12

…line-drag-and-drop

elasticmachine · 2019-11-25T15:13:17Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 847d33c

elasticmachine · 2019-11-25T16:30:59Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: acae0d4

elasticmachine · 2019-11-25T17:51:05Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 93cde19

…line-drag-and-drop # Conflicts: # x-pack/legacy/plugins/siem/public/components/page/index.tsx

XavierM · 2019-11-26T20:29:11Z

x-pack/legacy/plugins/siem/public/components/drag_and_drop/helpers.test.ts

    test('it returns false when the draggable is NOT content', () => {
      expect(
        draggableIsContent({
-          destination: null,


I am wondering why there is a difference between null and undefined there

XavierM · 2019-11-26T20:35:52Z

FYI @andrew-goldstein, I think @patrykkopycinski is our Hero here because he fixed this issue 460 for us with his work on this PR

XavierM · 2019-11-26T20:46:05Z

Also resizing columns is not working anymore. I do not know if I have been introduced by this PR, it does not seem like it

elasticmachine · 2019-11-26T20:47:21Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: a7d426d

XavierM · 2019-11-26T20:48:32Z

@patrykkopycinski and @andrew-goldstein I do not know what is going on but it seems that the timeline is not functional as it used to be. Lets' talk about it and see how we want to go about that. but I think that there is some work here to be done before we can ship 7.6. First, we should determine what happened and see which PR did that to the timeline. @patrykkopycinski are you ready for the challenge ;)?

patrykkopycinski · 2019-11-26T20:59:00Z

@elasticmachine merge upstream

XavierM

I talked to @patrykkopycinski over slack, he will create another PR to resolve this issue 51780
🎉 This pr is resolving the drag and drop behavior as expected. 🎉

elasticmachine · 2019-11-26T22:13:04Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: f09a74a

* upstream/7.x: Fix infinite redirect loop when multiple cookies are sent (elastic#50452) (elastic#51821) [Console] Proxy fallback (elastic#50185) (elastic#51814) Added endgame-* index and new heading 3 Elastic Endpoint SMP. (elastic#51071) (elastic#51828) [Maps] Added options to disable zoom, hide tool tips, widgets/overlays in embeddable maps (elastic#50663) (elastic#51811) Move errors and validate index pattern ⇒ NP (elastic#51805) (elastic#51831) [SIEM][Detection Engine] Adds ecs threat properties to rules (elastic#51782) (elastic#51827) [Lens] Remove client-side reference to server source code (elastic#51763) (elastic#51825) fixes drag and drop in tests (elastic#51806) (elastic#51813) [Uptime] Redesign/44541 new monitor list expanded row (elastic#46567) (elastic#51809) [7.x] [Telemetry] collector set to np (elastic#51618) (elastic#51787) [Uptime] added test for chart wrapper (elastic#50399) (elastic#51808) Expressions service fixes: better error and loading states handling (elastic#51183) (elastic#51800) Query String(Bar) Input - cleanup (elastic#51598) (elastic#51804) [ML] Adjust and re-enable categorization advanced wizard test (elastic#51005) (elastic#51017) fixes url state tests (elastic#51746) (elastic#51798) fixes browser field tests (elastic#51738) (elastic#51799) [Task Manager] Tests for the ability to run tasks of varying durations in parallel (elastic#51572) (elastic#51701) [ML] Fix anomaly detection test suite (elastic#51712) (elastic#51795) [SIEM] Fix Timeline drag and drop behavior (elastic#51558) (elastic#51793)

…ra/kibana into IS-46410_remove-@kbn/ui-framework * 'IS-46410_remove-@kbn/ui-framework' of github.com:mbondyra/kibana: (49 commits) [ML] Re-activate after method in transform test (elastic#51815) [SIEM] [Detection Engine] Add edit on rule creation (elastic#51670) De-angularize visLegend (elastic#50613) [SIEM][Detection Engine] Change security model to use SIEM permissions [Monitoring] Sass cleanup (elastic#51100) Move errors and validate index pattern ⇒ NP (elastic#51805) fixes pagination tests (elastic#51822) Split legacy plugin discovery, expose SavedObjects scopedClient, wrappers, repository (elastic#48882) [SIEM][Detection Engine] Adds ecs threat properties to rules (elastic#51782) [Lens] Remove client-side reference to server source code (elastic#51763) Fix infinite redirect loop when multiple cookies are sent (elastic#50452) fixes drag and drop in tests (elastic#51806) [Console] Proxy fallback (elastic#50185) Query String(Bar) Input - cleanup (elastic#51598) shim visualizations plugin (elastic#50624) Expressions service fixes: better error and loading states handling (elastic#51183) fixes url state tests (elastic#51746) fixes browser field tests (elastic#51738) [ML] Fix anomaly detection test suite (elastic#51712) [SIEM] Fix Timeline drag and drop behavior (elastic#51558) ...

[SIEM] Fix Timeline DnD behaviour

a78786a

patrykkopycinski self-assigned this Nov 24, 2019

patrykkopycinski added release_note:skip Skip the PR/issue when compiling release notes v7.6.0 v8.0.0 Team:SIEM labels Nov 24, 2019

TimelineBodyGlobalStyle

48fb916

patrykkopycinski changed the title ~~[SIEM] Fix Timeline drag and drop behaviour~~ [SIEM] Fix Timeline drag and drop behavior Nov 25, 2019

Merge branch 'master' of github.com:elastic/kibana into fix/siem-time…

03cab12

…line-drag-and-drop # Conflicts: # package.json

patrykkopycinski added 3 commits November 25, 2019 14:08

Merge branch 'master' of github.com:elastic/kibana into fix/siem-time…

6ca281f

…line-drag-and-drop

update unit tests

847d33c

update tests

acae0d4

fix tests

93cde19

Merge branch 'master' of github.com:elastic/kibana into fix/siem-time…

a7d426d

…line-drag-and-drop # Conflicts: # x-pack/legacy/plugins/siem/public/components/page/index.tsx

XavierM reviewed Nov 26, 2019

View reviewed changes

This comment has been minimized.

Sign in to view

Merge branch 'master' into fix/siem-timeline-drag-and-drop

f09a74a

XavierM approved these changes Nov 26, 2019

View reviewed changes

patrykkopycinski merged commit 517fcb9 into elastic:master Nov 27, 2019

patrykkopycinski deleted the fix/siem-timeline-drag-and-drop branch November 27, 2019 08:35

patrykkopycinski mentioned this pull request Nov 27, 2019

[7.x] [SIEM] Fix Timeline drag and drop behavior (#51558) #51793

Merged

patrykkopycinski added a commit that referenced this pull request Nov 27, 2019

[SIEM] Fix Timeline drag and drop behavior (#51558) (#51793)

a44ccb7

Conversation

patrykkopycinski commented Nov 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Nov 24, 2019

Uh oh!

elasticmachine commented Nov 25, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Nov 25, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Nov 25, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Nov 25, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Nov 25, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Nov 25, 2019

💚 Build Succeeded

Uh oh!

XavierM Nov 26, 2019

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

XavierM commented Nov 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

XavierM commented Nov 26, 2019

Uh oh!

elasticmachine commented Nov 26, 2019

💚 Build Succeeded

Uh oh!

XavierM commented Nov 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

patrykkopycinski commented Nov 26, 2019

Uh oh!

XavierM left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Nov 26, 2019

💚 Build Succeeded

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

patrykkopycinski commented Nov 24, 2019 •

edited

Loading

XavierM commented Nov 26, 2019 •

edited

Loading

XavierM commented Nov 26, 2019 •

edited

Loading

XavierM left a comment •

edited

Loading