Grokdebugger UI improvement#50683
Merged
elizabetdev merged 2 commits intoelastic:masterfrom Nov 15, 2019
Merged
Conversation
Contributor
💚 Build Succeeded |
Contributor
|
How do you feel about also removing the wrapper panel? Console doesn't have one either: |
Contributor
Author
|
@flash1293 I think it would look like very empty:
But I'm working on the Search Profiler tab #49772 and I might review all the 3 tabs to make them more consistent. |
jloleysens
approved these changes
Nov 15, 2019
Contributor
jloleysens
left a comment
There was a problem hiding this comment.
Happy with the visual changes, did not test locally - code also looks good!
Contributor
|
@miukimiu Let me know if you need assistance with those merge conflicts, as far as I know this is a pretty good summary of the additions from another contribution: https://github.com/elastic/kibana/pull/50473/files |
Contributor
💚 Build Succeeded |
elizabetdev
added a commit
to elizabetdev/kibana
that referenced
this pull request
Nov 15, 2019
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 18, 2019
…her [skip ci] * upstream/master: (54 commits) allows plugins to define validation schema for "enabled" flag (elastic#50286) Add retry to find.existsByDisplayedByCssSelector (elastic#48734) [i18n] integrate latest translations (elastic#50864) ui/resize_checker 👉 src/plugins/kibana_utils (elastic#44750) Fix @reach/router types (elastic#50863) [ML] Adding ML node warning to overview and analytics pages (elastic#50766) Bump storybook dependencies (elastic#50752) [APM Replace usage of idx with optional chaining (elastic#50849) [SIEM] Fix eslint errors (elastic#49713) Improve "Browser client is out of date" error message (elastic#50296) [SIEM][Detection Engine] REST API improvements and changes from UI/UX feedback (elastic#50797) Move @kbn/es-query into data plugin - es-query folder (elastic#50182) Index Management new platform migration (elastic#49359) Increase retry for cloud snapshot to finish (elastic#50781) Removing EuiCode from inside EuiPanel (elastic#50683) [SIEM] Tests for search_after and bulk index (elastic#50129) Make babel understand TypeScript 3.7 syntax (elastic#50772) Fixing mocha tests and broken password change status codes (elastic#50704) [Canvas] Use compressed forms in sidebar (elastic#49419) Add labels to shell scripts in Jenkins (elastic#49657) ...
elizabetdev
added a commit
that referenced
this pull request
Nov 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While reviewing the #49349 I noticed in the Dev Tools Grokdebugger tab the component
EuiCodebeing used insideEuiPanel. In Eui we try to avoid cards inside cards. So I'm doing this PR to fix this.The original PR was made in @flash1293 repo but we since this change was Grok Debugger specific we decided to open a PR against elastic master.