Add retry to find.existsByDisplayedByCssSelector by pheyos · Pull Request #48734 · elastic/kibana

pheyos · 2019-10-21T09:46:59Z

Summary

There are scenarios where testSubjects.existOrFail fails earlier than the provided timeout because the timeout is only applied to the find operation and not to the filter for displayed elements, e.g.

await testSubjects.existOrFail('myTestSubject', { timeout: 5000 });

may fail after a few milliseconds, if myTestSubject is found that fast but is not visible yet.
In order to make the whole existOrFail operation follow the provided timeout, this PR adds a retry to the underlying find.existsByDisplayedByCssSelector.

elasticmachine · 2019-10-21T10:58:16Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 070aaa3

test/functional/services/test_subjects.ts

elasticmachine · 2019-10-23T14:48:31Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: b284bb9

elasticmachine · 2019-10-23T16:28:01Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 39633a0

elasticmachine · 2019-10-24T09:45:33Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: dd71980

pheyos · 2019-10-24T11:15:51Z

retest

elasticmachine · 2019-10-24T12:31:18Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: dd71980

spalger · 2019-10-30T22:24:17Z

@elasticmachine merge upstream

elasticmachine · 2019-10-30T23:42:18Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 044ca61

elasticmachine · 2019-11-13T10:44:15Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 89043cd

pheyos · 2019-11-15T12:14:37Z

retest

dmlemeshko

Code LGTM, as we discussed - let's do more run on CI to feel safe :)

elasticmachine · 2019-11-15T13:35:31Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: df16f37

pheyos · 2019-11-15T13:36:18Z

Dashboard snapshot test (oss ciGroup3) passed 20x with this PR, see https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/5/

pheyos · 2019-11-15T13:37:04Z

retest

elasticmachine · 2019-11-15T15:00:13Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: df16f37

pheyos · 2019-11-15T15:00:27Z

Dashboard snapshot test (oss ciGroup3) passed another 20x with this PR, see https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/6/

pheyos · 2019-11-15T15:00:43Z

retest

LeeDr

LGTM and Thanks for making this improvement!

At some point we should refactor the save visualization functionality to be consistent with this;
https://github.com/elastic/kibana/blob/master/test/functional/page_objects/visualize_page.js#L766

elasticmachine · 2019-11-15T16:19:00Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: df16f37

pheyos · 2019-11-18T06:58:50Z

@elasticmachine merge upstream

elasticmachine · 2019-11-18T08:29:46Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 8f32078

This PR fixes timeout handling in `find.existsByDisplayedByCssSelector` for elements that are found but (not yet) displayed.

…her [skip ci] * upstream/master: (54 commits) allows plugins to define validation schema for "enabled" flag (elastic#50286) Add retry to find.existsByDisplayedByCssSelector (elastic#48734) [i18n] integrate latest translations (elastic#50864) ui/resize_checker 👉 src/plugins/kibana_utils (elastic#44750) Fix @reach/router types (elastic#50863) [ML] Adding ML node warning to overview and analytics pages (elastic#50766) Bump storybook dependencies (elastic#50752) [APM Replace usage of idx with optional chaining (elastic#50849) [SIEM] Fix eslint errors (elastic#49713) Improve "Browser client is out of date" error message (elastic#50296) [SIEM][Detection Engine] REST API improvements and changes from UI/UX feedback (elastic#50797) Move @kbn/es-query into data plugin - es-query folder (elastic#50182) Index Management new platform migration (elastic#49359) Increase retry for cloud snapshot to finish (elastic#50781) Removing EuiCode from inside EuiPanel (elastic#50683) [SIEM] Tests for search_after and bulk index (elastic#50129) Make babel understand TypeScript 3.7 syntax (elastic#50772) Fixing mocha tests and broken password change status codes (elastic#50704) [Canvas] Use compressed forms in sidebar (elastic#49419) Add labels to shell scripts in Jenkins (elastic#49657) ...

This PR fixes timeout handling in `find.existsByDisplayedByCssSelector` for elements that are found but (not yet) displayed.

Add retry to testSubjects.existOrFail

070aaa3

pheyos added test_ui_functional v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.5.0 labels Oct 21, 2019

pheyos requested a review from spalger October 21, 2019 09:46

pheyos self-assigned this Oct 21, 2019

kertal mentioned this pull request Oct 21, 2019

Kibana app migration: Extension points #48735

Closed

9 tasks

pheyos requested a review from dmlemeshko October 22, 2019 06:07

dmlemeshko reviewed Oct 22, 2019

View reviewed changes

test/functional/services/test_subjects.ts Outdated Show resolved Hide resolved

pheyos added 3 commits October 22, 2019 16:44

Merge branch 'master' into fix_existOrFail

9e2052c

Merge branch 'master' into fix_existOrFail

e8121ac

Move retry logiv to find.existsByDisplayedByCssSelector

b284bb9

pheyos requested a review from dmlemeshko October 23, 2019 13:33

Merge branch 'master' into fix_existOrFail

39633a0

Merge branch 'master' into fix_existOrFail

dd71980

pheyos changed the title ~~Add retry to testSubjects.existOrFail~~ Add retry to find.existsByDisplayedByCssSelector Oct 24, 2019

Merge branch 'master' into fix_existOrFail

044ca61

pheyos added 2 commits November 13, 2019 10:26

Merge branch 'master' into fix_existOrFail

77354bf

Move toast handling to saveDashboard

89043cd

pheyos requested a review from LeeDr November 13, 2019 09:40

dmlemeshko approved these changes Nov 15, 2019

View reviewed changes

LeeDr approved these changes Nov 15, 2019

View reviewed changes

Merge branch 'master' into fix_existOrFail

8f32078

pheyos added v7.5.1 and removed v7.5.0 labels Nov 18, 2019

pheyos merged commit 39aeaaa into elastic:master Nov 18, 2019

pheyos deleted the fix_existOrFail branch November 18, 2019 08:37

pheyos added v7.6.0 backport pending labels Nov 18, 2019

pheyos mentioned this pull request Nov 18, 2019

[7.x] Add retry to find.existsByDisplayedByCssSelector (#48734) #50883

Merged

pheyos added a commit to pheyos/kibana that referenced this pull request Nov 18, 2019

Add retry to find.existsByDisplayedByCssSelector (elastic#48734)

d7c9b54

This PR fixes timeout handling in `find.existsByDisplayedByCssSelector` for elements that are found but (not yet) displayed.

pheyos added a commit that referenced this pull request Nov 18, 2019

Add retry to find.existsByDisplayedByCssSelector (#48734) (#50883)

a5b3efa

This PR fixes timeout handling in `find.existsByDisplayedByCssSelector` for elements that are found but (not yet) displayed.

pheyos added a commit to pheyos/kibana that referenced this pull request Dec 3, 2019

Add retry to find.existsByDisplayedByCssSelector (elastic#48734)

418fd49

This PR fixes timeout handling in `find.existsByDisplayedByCssSelector` for elements that are found but (not yet) displayed.

pheyos mentioned this pull request Dec 3, 2019

[7.5] Add retry to find.existsByDisplayedByCssSelector (#48734) #52062

Merged

pheyos added a commit that referenced this pull request Dec 3, 2019

Add retry to find.existsByDisplayedByCssSelector (#48734) (#52062)

d334777

This PR fixes timeout handling in `find.existsByDisplayedByCssSelector` for elements that are found but (not yet) displayed.

pheyos removed the backport pending label Dec 3, 2019

Conversation

pheyos commented Oct 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

elasticmachine commented Oct 21, 2019

💚 Build Succeeded

Uh oh!

Uh oh!

elasticmachine commented Oct 23, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Oct 23, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Oct 24, 2019

💔 Build Failed

Uh oh!

pheyos commented Oct 24, 2019

Uh oh!

elasticmachine commented Oct 24, 2019

💔 Build Failed

Uh oh!

spalger commented Oct 30, 2019

Uh oh!

elasticmachine commented Oct 30, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Nov 13, 2019

💔 Build Failed

Uh oh!

pheyos commented Nov 15, 2019

Uh oh!

dmlemeshko left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Nov 15, 2019

💚 Build Succeeded

Uh oh!

pheyos commented Nov 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pheyos commented Nov 15, 2019

Uh oh!

elasticmachine commented Nov 15, 2019

💚 Build Succeeded

Uh oh!

pheyos commented Nov 15, 2019

Uh oh!

pheyos commented Nov 15, 2019

Uh oh!

LeeDr left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Nov 15, 2019

💚 Build Succeeded

Uh oh!

pheyos commented Nov 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Nov 18, 2019

💚 Build Succeeded

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pheyos commented Oct 21, 2019 •

edited

Loading

pheyos commented Nov 15, 2019 •

edited

Loading

pheyos commented Nov 18, 2019 •

edited

Loading