Index Management new platform migration by alisonelizabeth · Pull Request #49359 · elastic/kibana

This was largely borrowed from https://github.com/elastic/kibana/blob/master/src/plugins/es_ui_shared/public/request/request.ts, but updated to work with the NP http service.

alisonelizabeth · 2019-11-12T00:18:15Z

x-pack/legacy/plugins/index_management/public/app/services/api.ts


  return result;
 }
-
-export async function loadTemplateToClone(name: Template['name']) {


this was not being used

alisonelizabeth · 2019-11-12T00:21:14Z

@elasticmachine merge upstream

elasticmachine · 2019-11-12T01:37:40Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 96156ad

alisonelizabeth · 2019-11-12T18:58:01Z

@elasticmachine merge upstream

elasticmachine · 2019-11-12T20:18:19Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 7a69c78

joshdover

Just reviewed the shims and plugin classes, things look good for the first part of the migration 👍

joshdover · 2019-11-12T21:03:29Z

x-pack/legacy/plugins/index_management/public/plugin.ts

+
+    // Register management section and Angular route
+    registerManagementSection(management.getSection('elasticsearch'));
+    registerRoutes(core as CoreStart);


nit: this cast is unnecessary

joshdover · 2019-11-12T21:05:16Z

x-pack/legacy/plugins/index_management/index.ts

+      const pluginsSetup = {};
+
+      const __LEGACY: LegacySetup = {
+        router: createRouter(server, PLUGIN.ID, `${API_BASE_PATH}/`),


I'm guessing the bulk of the work for migrating the server-side code in this plugin will be adapting the router interface to work with the New Platform's router.

jloleysens

Overall this contribution looks in really good shape!

I gave a smoke test locally and was able to perform all actions I attempted, did not do an in-depth regression test but given that notifications and http are working I think we are mostly safe!

Left some non-blocking comments.

jloleysens · 2019-11-14T11:21:45Z

x-pack/legacy/plugins/index_management/public/app/services/breadcrumbs.ts

+import { BASE_PATH } from '../../../common/constants';
+
+class BreadcrumbService {
+  private chrome: any;


We should have types for this, from here: src/core/public/chrome/chrome_service.tsx. I'm guessing the ChromeStart interface is the one we want.

jloleysens · 2019-11-14T11:29:45Z

x-pack/legacy/plugins/index_management/public/app/services/notification.ts

+  }
+
+  public showSuccessToast(title: string, text?: string) {
+    this.addToasts(title, 'success', text);


nit: looks like the toasts service API has methods like addSuccess we could use (I think it may add an icon too - so if it's not what we want ignore this entirely).

Same for above warning and danger instances.

Ah, I somehow missed that. I'll look into it - thanks!

I added this as an item to fix for the next phase of NP work.

jloleysens · 2019-11-14T11:49:55Z

x-pack/legacy/plugins/index_management/server/routes/api/indices/register_freeze_route.ts

+  indices: string[];
+}
+
+const handler: RouterRouteHandler = async (request, callWithRequest, h) => {


@joshdover is there a plan for migration of ../../../../../../server/lib/create_router? Specifically looking at h 😄 , but also the other values passed in.

Ok, I see the plan is to move over to http.route NP service, right?

That's my understanding

alisonelizabeth · 2019-11-14T17:36:30Z

@elasticmachine merge upstream

elasticmachine · 2019-11-14T18:52:34Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: d4dcf72

elasticmachine · 2019-11-14T19:43:13Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 97fd3c8

alisonelizabeth · 2019-11-15T17:25:31Z

@elasticmachine merge upstream

elasticmachine · 2019-11-15T18:42:32Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 46e3795

…her [skip ci] * upstream/master: (54 commits) allows plugins to define validation schema for "enabled" flag (elastic#50286) Add retry to find.existsByDisplayedByCssSelector (elastic#48734) [i18n] integrate latest translations (elastic#50864) ui/resize_checker 👉 src/plugins/kibana_utils (elastic#44750) Fix @reach/router types (elastic#50863) [ML] Adding ML node warning to overview and analytics pages (elastic#50766) Bump storybook dependencies (elastic#50752) [APM Replace usage of idx with optional chaining (elastic#50849) [SIEM] Fix eslint errors (elastic#49713) Improve "Browser client is out of date" error message (elastic#50296) [SIEM][Detection Engine] REST API improvements and changes from UI/UX feedback (elastic#50797) Move @kbn/es-query into data plugin - es-query folder (elastic#50182) Index Management new platform migration (elastic#49359) Increase retry for cloud snapshot to finish (elastic#50781) Removing EuiCode from inside EuiPanel (elastic#50683) [SIEM] Tests for search_after and bulk index (elastic#50129) Make babel understand TypeScript 3.7 syntax (elastic#50772) Fixing mocha tests and broken password change status codes (elastic#50704) [Canvas] Use compressed forms in sidebar (elastic#49419) Add labels to shell scripts in Jenkins (elastic#49657) ...

alisonelizabeth added Feature:Index Management Index and index templates UI v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes v7.6.0 labels Oct 25, 2019

server np migration phase i

739edd8

alisonelizabeth force-pushed the np_migration/index_management branch from b2f518f to 739edd8 Compare October 25, 2019 18:12

prep client code for np migration

82df866

alisonelizabeth added 4 commits October 28, 2019 16:41

create plugin definition for client

96174a4

move to use client http service from core

90bf7e6

move to use chrome service from core

e4d273e

move to use documentation service from core

e55805a

use notification service from core

04e3001

alisonelizabeth added 2 commits October 30, 2019 11:14

use i18n context from core

16c751d

move ui_metric service to shim

e903a50

fix error messages

c15fe78

fix build errors

1be3a10

clean up request logic

e31dba7

fix tests

534bd0c

alisonelizabeth force-pushed the np_migration/index_management branch from 9d47441 to 534bd0c Compare November 11, 2019 16:35

alisonelizabeth changed the title ~~[WIP] Index Management new platform migration~~ Index Management new platform migration Nov 11, 2019

alisonelizabeth marked this pull request as ready for review November 11, 2019 20:29

alisonelizabeth commented Nov 11, 2019

View reviewed changes

fix ilm integration, remove unused scss

9acf906

alisonelizabeth commented Nov 12, 2019

View reviewed changes

alisonelizabeth requested review from jloleysens and joshdover November 12, 2019 00:20

Merge branch 'master' into np_migration/index_management

96156ad

Merge branch 'master' into np_migration/index_management

7a69c78

joshdover reviewed Nov 12, 2019

View reviewed changes

jloleysens approved these changes Nov 14, 2019

View reviewed changes

elasticmachine and others added 2 commits November 14, 2019 09:36

Merge branch 'master' into np_migration/index_management

d4dcf72

fix ts

97fd3c8

fix ts

1138eb5

Merge branch 'master' into np_migration/index_management

46e3795

alisonelizabeth merged commit 03e2a68 into elastic:master Nov 15, 2019

alisonelizabeth deleted the np_migration/index_management branch November 15, 2019 18:54

alisonelizabeth mentioned this pull request Nov 15, 2019

[7.x] Index Management new platform migration (#49359) #50812

Merged

alisonelizabeth added a commit that referenced this pull request Nov 15, 2019

Index Management new platform migration (#49359) (#50812)

f530fec

Conversation

alisonelizabeth commented Oct 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to review

Uh oh!

elasticmachine commented Oct 25, 2019

Uh oh!

elasticmachine commented Oct 25, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Oct 25, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Oct 25, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Oct 29, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Oct 30, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Oct 30, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Oct 30, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Oct 30, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Nov 8, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Nov 11, 2019

💔 Build Failed

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alisonelizabeth commented Nov 12, 2019

Uh oh!

elasticmachine commented Nov 12, 2019

💔 Build Failed

Uh oh!

alisonelizabeth commented Nov 12, 2019

Uh oh!

elasticmachine commented Nov 12, 2019

💔 Build Failed

Uh oh!

joshdover left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jloleysens left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alisonelizabeth commented Nov 14, 2019

Uh oh!

elasticmachine commented Nov 14, 2019

💔 Build Failed

alisonelizabeth commented Oct 25, 2019 •

edited

Loading

jloleysens left a comment •

edited

Loading