Conversation
💔 Build Failed |
…pplication-service
…h1293/kibana into flash1293/local-application-service
kertal
left a comment
There was a problem hiding this comment.
Code LGTM, there are some browser console errors that should be investigated
The Console settings seem to have some problems. no error in master
The grok debugger also throws some errors, but these are unrelated to this PR, are also on master, seems the EuiCodeEditors are missing the theme setting.
This one looks kinda weird, was Kibana server running?
Fwiw, it looks like may be an EUI problem; created this issue: elastic/eui#2517 Update: |
joshdover
left a comment
There was a problem hiding this comment.
Platform glue code LGTM
| }); | ||
| } | ||
|
|
||
| start(core: CoreStart, { newPlatformDevTools }: DevToolsPluginStartDependencies) { |
There was a problem hiding this comment.
| start(core: CoreStart, { newPlatformDevTools }: DevToolsPluginStartDependencies) { | |
| public start(core: CoreStart, { newPlatformDevTools }: DevToolsPluginStartDependencies) { |
| start(core: CoreStart, { newPlatformDevTools }: DevToolsPluginStartDependencies) { | ||
| this.getSortedDevTools = newPlatformDevTools.getSortedDevTools; | ||
| if (this.getSortedDevTools().length === 0) { | ||
| core.chrome.navLinks.update('kibana:dev_tools', { |
There was a problem hiding this comment.
FYI this API will be replaced by the AppUpdater mechanism proposed in #45291
| if (!this.getSortedDevTools) { | ||
| throw new Error('not started yet'); | ||
| } | ||
| const { renderApp } = await import('./render_app'); |
There was a problem hiding this comment.
By convention, this module should live in ./application
There was a problem hiding this comment.
@maryia-lapata @kertal we probably have to fix that in a few places ;)
could be the case, I |
|
@elasticmachine merge upstream |
kertal
left a comment
There was a problem hiding this comment.
Code LGTM 👍 , tested today, a kbn bootstrap in between, works
💔 Build Failed |
💔 Build Failed |
|
@elasticmachine merge upstream |
💚 Build Succeeded |
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
elizabetdev
left a comment
There was a problem hiding this comment.
LGTM!
I just created a PR with a design suggestion.
|
Merging this, @miukimiu s suggestion can get in as a separate PR. |
This PR shims the dev tools app and removes the last bits of angular. By providing a registry similar to the application service dev tools can register themselves without using
uiRoutesor directives.Dev docs
The
ui/registry/dev_toolsis removed in favor of theDevToolsplugin which exposes aregistermethod in the setup contract. Registering app works mostly the same as registering apps incore.application.register. Routing will be handled by the id of the dev tool - your dev tool will be mounted when the URL matches/app/kibana#/dev_tools/<YOUR ID>. This API doesn't support angular, for registering angular dev tools, bootstrap a local module on mount into the given HTML element.