[Telemetry] Remove telemetry splash page and add conditional messaging by joelgriffith · Pull Request #50189 · elastic/kibana

joelgriffith · 2019-11-11T19:03:38Z

Summary

Drops the telemetry splash page, removes most of the UI treatments but still leaves some services (client-side) intact just in case.

Screenie:

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

…sh-page

joelgriffith · 2019-11-11T19:04:50Z

src/legacy/core_plugins/kibana/public/home/components/welcome.tsx

+                  onDecline={this.onSampleDataDecline}
+                />
+                <EuiSpacer size="s" />
+                <EuiTextColor className="euiText--small" color="subdued">


This part is a bit hectic, but I couldn't find a better mechanism for embedding links into a formatted message. Would love to know if folks have a better alternative as this is super noisy.

elasticmachine · 2019-11-11T20:19:50Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: ddf7260

gmmorris

All looks good except the click here leads nowhere... so, that's obviously a blocker. :)

gmmorris · 2019-11-11T21:24:03Z

src/legacy/core_plugins/kibana/public/home/components/welcome.tsx

+                    <FormattedMessage
+                      id="kbn.home.dataManagementDisableCollectionLink"
+                      defaultMessage="click here."
+                    />


Clicking here just causes the page to refresh and ends up in the same place. 🤔

Same with the privacy policy link, which seems like it should go to https://www.elastic.co/legal/telemetry-privacy-statement , but perhaps we're waiting for updated links ...

Yup, these are just placeholders for now, thanks for calling it out!

Added links!

elasticmachine · 2019-11-11T21:41:24Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: b69142c

elasticmachine · 2019-11-11T22:38:42Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 46b9f5c

elasticmachine · 2019-11-11T23:43:53Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 440a373

…sh-page

elasticmachine · 2019-11-12T01:10:25Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 9188ce8

…sh-page

elasticmachine · 2019-11-12T19:24:37Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: fe98b93

elasticmachine · 2019-11-12T20:41:22Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: b84c88f

tsullivan

LGTM it looks like it simplifies things a bit

Reviewed the code only

tsullivan · 2019-11-12T21:05:37Z

@joelgriffith can you update the PR title to something more meaningful please? 😺

pmuellr

LGTM, but I'm pretty unfamiliar with our UI bits (but now learning!)

Agree that the PR title should be changed tho :-)

gmmorris

Looks good 👍

alexfrancoeur · 2019-11-12T21:49:09Z

LGTM overall. A few quick comments and questions.

Text is good, links work. @cchaos @ryankeairns this is super minor, but do we need more padding between the card and the usage data text?

I realize we can't deep link directly, but is there any way to pre-populate the search bar with usage to filter down the list? I don't see any network calls being made and it seems to be purely UI based, but I thought I'd ask 😄

I tried loading with telemetry.allowChangingOptInStatus: false and received this bug in Chrome (incognito) with a fresh es snapshot. I'm pretty sure this config is in master. Has anyone else run into similar problems?

alexfrancoeur · 2019-11-12T21:50:18Z

Already merged 😄 I type too slow

joelgriffith · 2019-11-12T21:53:58Z

@alexfrancoeur good catch on that issue, we did track that and need to alter our Joi validation. I'll follow up in another PR

* upstream/master: Remove internal platform types exports (elastic#50427) [APM] Document `apm_oss.metricsIndices` and `apm_oss.sourcemap… (elastic#50312) [Telemetry] Server side fetcher (elastic#50015) [SIEM] Detection engine placeholders (elastic#50220) [Uptime] Donut chart loader position centered vertically (elastic#50219) update telemetry banner notice text (elastic#50403) Fix aborting when searching without batching (elastic#49966) [Telemetry] Remove telemetry splash page and add conditional messaging (elastic#50189) Revert chromedriver update (elastic#50324) Remove deprecated argument include_type_name from ES calls (elastic#50285) [Maps] add settings to maps telemetry (elastic#50161) remove visualize loader (elastic#46910) Fix misuse of react-router and react-router-dom (elastic#50120)

…-fallback * 'master' of github.com:elastic/kibana: Remove internal platform types exports (elastic#50427) [APM] Document `apm_oss.metricsIndices` and `apm_oss.sourcemap… (elastic#50312) [Telemetry] Server side fetcher (elastic#50015) [SIEM] Detection engine placeholders (elastic#50220) [Uptime] Donut chart loader position centered vertically (elastic#50219) update telemetry banner notice text (elastic#50403) Fix aborting when searching without batching (elastic#49966) [Telemetry] Remove telemetry splash page and add conditional messaging (elastic#50189) Revert chromedriver update (elastic#50324) Remove deprecated argument include_type_name from ES calls (elastic#50285) [Maps] add settings to maps telemetry (elastic#50161) remove visualize loader (elastic#46910) Fix misuse of react-router and react-router-dom (elastic#50120) Move table-list-view to kibana-react (elastic#50046) [ML] Stats bar for data frame analytics (elastic#49464)

…ger-ace-theme * 'master' of github.com:elastic/kibana: (56 commits) [ML] Server info service refactor (elastic#50302) Remove internal platform types exports (elastic#50427) [APM] Document `apm_oss.metricsIndices` and `apm_oss.sourcemap… (elastic#50312) [Telemetry] Server side fetcher (elastic#50015) [SIEM] Detection engine placeholders (elastic#50220) [Uptime] Donut chart loader position centered vertically (elastic#50219) update telemetry banner notice text (elastic#50403) Fix aborting when searching without batching (elastic#49966) [Telemetry] Remove telemetry splash page and add conditional messaging (elastic#50189) Revert chromedriver update (elastic#50324) Remove deprecated argument include_type_name from ES calls (elastic#50285) [Maps] add settings to maps telemetry (elastic#50161) remove visualize loader (elastic#46910) Fix misuse of react-router and react-router-dom (elastic#50120) Move table-list-view to kibana-react (elastic#50046) [ML] Stats bar for data frame analytics (elastic#49464) [ML] Make navigation in tests more stable (elastic#50132) Migrate authorization subsystem to the new platform. (elastic#46145) Bugfix: Interpreter conversion of string to number should throw on NaN elastic#27788 (elastic#50063) Update dependency @elastic/charts to v14 (elastic#49947) ...

alexfrancoeur · 2019-11-13T15:42:07Z

Closes #49518 when backported

LeeDr · 2019-11-13T15:46:53Z

@tsullivan @gmmorris @pmuellr why are we approving PRs where none of these checkboxes are checked or striked-through?

…ssaging (#50189) (#50429) * [Telemetry] Remove telemetry splash page and add conditional messaging (#50189) * Removing tel splash page in UI layer * Removing more components * New disclaimer text * Removing telemetry i18n text * More i18n text removals * Snapshot updates * Snapshot tests + quick links for tel opt-out when possible * Fixing TS issues in test * i18n updates

…ssaging (#50189) (#50430) * [Telemetry] Remove telemetry splash page and add conditional messaging (#50189) * Removing tel splash page in UI layer * Removing more components * New disclaimer text * Removing telemetry i18n text * More i18n text removals * Snapshot updates * Snapshot tests + quick links for tel opt-out when possible * Fixing TS issues in test * Fixing broken telemetry updates * [ML] Removes ChartTooltip component, artefact from backport gone wrong. (#50300) * [7.5] [ML] Skip advanced wizard categorization test (#50141) (#50156) * [ML] Skip advanced wizard categorization test (#50141) * Re-enable other advanced tests * [DOCS] Adds link to 7.5 breaking changes doc (#50496) * Fixing mock interface in jest

Joel Griffith added 4 commits November 11, 2019 09:40

Removing tel splash page in UI layer

30b339a

Removing more components

774bd42

New disclaimer text

ce837aa

Merge remote-tracking branch 'upstream/master' into chore/tel-no-spla…

ddf7260

…sh-page

joelgriffith added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.5.0 labels Nov 11, 2019

joelgriffith commented Nov 11, 2019

View reviewed changes

Joel Griffith added 2 commits November 11, 2019 12:26

Removing telemetry i18n text

b69142c

More i18n text removals

46b9f5c

gmmorris suggested changes Nov 11, 2019

View reviewed changes

Snapshot updates

440a373

Merge remote-tracking branch 'upstream/master' into chore/tel-no-spla…

9188ce8

…sh-page

Joel Griffith added 4 commits November 12, 2019 08:23

Merge remote-tracking branch 'upstream/master' into chore/tel-no-spla…

a76794f

…sh-page

Snapshot tests + quick links for tel opt-out when possible

6faff3e

Fixing TS issues in test

fe98b93

Merge remote-tracking branch 'upstream/master' into chore/tel-no-spla…

b84c88f

…sh-page

tsullivan approved these changes Nov 12, 2019

View reviewed changes

pmuellr approved these changes Nov 12, 2019

View reviewed changes

joelgriffith changed the title ~~Chore/tel no splash page~~ [Telemetry] Remove telemetry splash page and add conditional messaging Nov 12, 2019

gmmorris approved these changes Nov 12, 2019

View reviewed changes

joelgriffith merged commit fada20d into elastic:master Nov 12, 2019

This was referenced Nov 12, 2019

[7.x] [Telemetry] Remove telemetry splash page and add conditional messaging (#50189) #50429

Merged

[7.5] [Telemetry] Remove telemetry splash page and add conditional messaging (#50189) #50430

Merged

alexfrancoeur mentioned this pull request Nov 15, 2019

[DOCS] 7.5.0 Release Notes #50425

Merged

1 task

Conversation

joelgriffith commented Nov 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

joelgriffith Nov 11, 2019

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Nov 11, 2019

💔 Build Failed

Uh oh!

gmmorris left a comment

Choose a reason for hiding this comment

Uh oh!

gmmorris Nov 11, 2019

Choose a reason for hiding this comment

Uh oh!

pmuellr Nov 11, 2019

Choose a reason for hiding this comment

Uh oh!

joelgriffith Nov 11, 2019

Choose a reason for hiding this comment

Uh oh!

joelgriffith Nov 12, 2019

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Nov 11, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Nov 11, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Nov 11, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Nov 12, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Nov 12, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Nov 12, 2019

💚 Build Succeeded

Uh oh!

tsullivan left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tsullivan commented Nov 12, 2019

Uh oh!

pmuellr left a comment

Choose a reason for hiding this comment

Uh oh!

gmmorris left a comment

Choose a reason for hiding this comment

Uh oh!

alexfrancoeur commented Nov 12, 2019

Uh oh!

alexfrancoeur commented Nov 12, 2019

Uh oh!

joelgriffith commented Nov 12, 2019

Uh oh!

alexfrancoeur commented Nov 13, 2019

Uh oh!

LeeDr commented Nov 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

joelgriffith commented Nov 11, 2019 •

edited

Loading

tsullivan left a comment •

edited

Loading

LeeDr commented Nov 13, 2019 •

edited

Loading