[ML] Fixes error on first tooltip hover in Single Metric Viewer.#50300
Merged
peteharverson merged 11 commits intoelastic:7.5from Nov 13, 2019
Merged
[ML] Fixes error on first tooltip hover in Single Metric Viewer.#50300peteharverson merged 11 commits intoelastic:7.5from
peteharverson merged 11 commits intoelastic:7.5from
Conversation
Contributor
|
Pinging @elastic/ml-ui (:ml) |
darnautov
approved these changes
Nov 12, 2019
Contributor
darnautov
left a comment
There was a problem hiding this comment.
LGTM! Sorry my PR messed up the chart tooltip 😬
pheyos
approved these changes
Nov 12, 2019
Member
pheyos
left a comment
There was a problem hiding this comment.
Tested locally and the issue didn't occur any more. LGTM
Contributor
💔 Build Failed |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💔 Build Failed |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💔 Build Failed |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💔 Build Failed |
Contributor
Author
|
@elasticmachine merge upstream |
Member
|
@elasticmachine merge upstream |
Contributor
💔 Build Failed |
Member
|
retest |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Member
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded |
joelgriffith
pushed a commit
that referenced
this pull request
Nov 13, 2019
…ssaging (#50189) (#50430) * [Telemetry] Remove telemetry splash page and add conditional messaging (#50189) * Removing tel splash page in UI layer * Removing more components * New disclaimer text * Removing telemetry i18n text * More i18n text removals * Snapshot updates * Snapshot tests + quick links for tel opt-out when possible * Fixing TS issues in test * Fixing broken telemetry updates * [ML] Removes ChartTooltip component, artefact from backport gone wrong. (#50300) * [7.5] [ML] Skip advanced wizard categorization test (#50141) (#50156) * [ML] Skip advanced wizard categorization test (#50141) * Re-enable other advanced tests * [DOCS] Adds link to 7.5 breaking changes doc (#50496) * Fixing mock interface in jest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #50154. In
7.5only tooltips for the single metric viewer chart were broken, the first hover would trigger an error, the tooltip would stay and not disappear, a second tooltip would appear when hovering other elements.Turns out the
<ChartTooltip />component was moved in the JSX structure in a PR that went only into7.6. The follow up PR for fixing tooltip positioning was backported to7.5again. The backport didn't complain but duplicated the<ChartTooltip />instead of moving it, resulting in the bug.