Skip to content

[ML] Skip advanced wizard categorization test#50141

Merged
pheyos merged 2 commits intoelastic:masterfrom
pheyos:skip_categorization_test
Nov 11, 2019
Merged

[ML] Skip advanced wizard categorization test#50141
pheyos merged 2 commits intoelastic:masterfrom
pheyos:skip_categorization_test

Conversation

@pheyos
Copy link
Copy Markdown
Member

@pheyos pheyos commented Nov 11, 2019

Summary

The changes introduced in elastic/elasticsearch/pull/48770 and elastic/elasticsearch/pull/48885 require adjustments to the categorization test, but this has to wait until Kibana and ES master are in sync again. Until then, this PR disables the categorization test.

@pheyos pheyos added :ml test_ui_functional v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.5.0 labels Nov 11, 2019
@pheyos pheyos requested a review from a team as a code owner November 11, 2019 11:09
@pheyos pheyos self-assigned this Nov 11, 2019
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/ml-ui (:ml)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 11, 2019

💔 Build Failed

A couple unrelated test failures.

@pheyos
Copy link
Copy Markdown
Member Author

pheyos commented Nov 11, 2019

retest

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Copy link
Copy Markdown
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pheyos pheyos merged commit e2d3c87 into elastic:master Nov 11, 2019
@pheyos pheyos deleted the skip_categorization_test branch November 11, 2019 14:33
pheyos added a commit to pheyos/kibana that referenced this pull request Nov 11, 2019
pheyos added a commit to pheyos/kibana that referenced this pull request Nov 11, 2019
pheyos added a commit that referenced this pull request Nov 13, 2019
* [ML] Skip advanced wizard categorization test (#50141)
* Re-enable other advanced tests
joelgriffith pushed a commit that referenced this pull request Nov 13, 2019
…ssaging (#50189) (#50430)

* [Telemetry] Remove telemetry splash page and add conditional messaging (#50189)

* Removing tel splash page in UI layer

* Removing more components

* New disclaimer text

* Removing telemetry i18n text

* More i18n text removals

* Snapshot updates

* Snapshot tests + quick links for tel opt-out when possible

* Fixing TS issues in test

* Fixing broken telemetry updates

* [ML] Removes ChartTooltip component, artefact from backport gone wrong. (#50300)

* [7.5] [ML] Skip advanced wizard categorization test (#50141) (#50156)

* [ML] Skip advanced wizard categorization test (#50141)
* Re-enable other advanced tests

* [DOCS] Adds link to 7.5 breaking changes doc (#50496)

* Fixing mock interface in jest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v7.5.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants