update telemetry banner notice text by pmuellr · Pull Request #50403 · elastic/kibana

pmuellr · 2019-11-12T18:02:02Z

resolves #50245

Summary

changes:

Privacy statement url changed from:

https://www.elastic.co/legal/telemetry-privacy-statement

to:

  https://www.elastic.co/legal/privacy-statement

Note that link is also used on the Management / Advanced settings page (bottom, telemetry section), where the link text was NOT changed (is: "Read our usage data privacy statement")

i18n changes:

i18n telemetry.welcomeBanner.title

removed exclamation point from "Help us improve the Elastic Stack!"
telemetry.welcomeBanner.yesButtonLabel

changed from "Yes" to "Enable"
telemetry.welcomeBanner.noButtonLabel

changed from "No" to "Disable"
telemetry.welcomeBanner.telemetryConfigDetailsDescription.telemetryPrivacyStatementLinkText

changed from "telemetry privacy statement" to "Privacy Statement"
new message telemetry.telemetryBannerDescription; this is very similar to telemetry.telemetryConfigDescription, but that message is reused on the Management / Advanced settings page (bottom, telemetry section), which was left unchanged. The new value is:
- "Want to help us improve the Elastic Stack? Data usage collection is currently disabled. Enabling data usage collection helps us manage and improve our products and services. See our {privacyStatementLink} for more details."

old ui

after clicking "Read More", more text is added at the end of the banner

new ui

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~This was checked for cross-browser compatibility, including a check against IE11~~
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
~~Documentation was added for features that require explanation or tutorials~~
~~Unit or functional tests were updated or added to match the most common scenarios~~
~~This was checked for keyboard-only and screenreader accessibility~~

For maintainers

~~This was checked for breaking API changes and was labeled appropriately~~
~~This includes a feature addition or change that requires a release note and was labeled appropriately~~

resolves elastic#50245

elasticmachine · 2019-11-12T18:02:05Z

Pinging @elastic/kibana-stack-services (Team:Stack Services)

elasticmachine · 2019-11-12T18:38:19Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: f68c610

pmuellr · 2019-11-12T18:39:27Z

@elasticmachine merge upstream

mikecote

Changes looking good so far, just had a question about the translations but I think you're on it. The rest looks good to me.

src/legacy/core_plugins/telemetry/public/components/opt_in_banner_component.tsx

elasticmachine · 2019-11-12T19:57:21Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: e123cc5

elasticmachine · 2019-11-12T20:13:56Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: ec2d19a

alexfrancoeur · 2019-11-12T21:03:59Z

LGTM functionality and content wise. I'll open a separate issue to track the advanced settings text.

gmmorris

Code and functionality LGTM.

elasticmachine · 2019-11-12T21:07:03Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: fdacb5e

tsullivan · 2019-11-12T21:10:58Z

src/legacy/core_plugins/telemetry/public/components/opt_in_message.tsx

 import { FormattedMessage } from '@kbn/i18n/react';

-import { getConfigTelemetryDesc, PRIVACY_STATEMENT_URL } from '../../common/constants';
-import { OptInExampleFlyout } from './opt_in_details_component';


Looks like opt_in_details_component.ts and the test file are still in the code, but can be removed.

nm - it's still used from the Advanced Settings form for telemetry

I think that code is used by some other code that is still around - a license management page? Could be dead code by the time we're done with all the changes, but didn't look like I could just remove the files right now.

tsullivan

LGTM

reviewed the code only

pmuellr · 2019-11-12T21:27:12Z

hmm failed a ML test, so gonna merge master and cross fingers ...

pmuellr · 2019-11-12T21:27:32Z

@elasticmachine merge upstream

elasticmachine · 2019-11-12T22:49:04Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 8647f96

* upstream/master: Remove internal platform types exports (elastic#50427) [APM] Document `apm_oss.metricsIndices` and `apm_oss.sourcemap… (elastic#50312) [Telemetry] Server side fetcher (elastic#50015) [SIEM] Detection engine placeholders (elastic#50220) [Uptime] Donut chart loader position centered vertically (elastic#50219) update telemetry banner notice text (elastic#50403) Fix aborting when searching without batching (elastic#49966) [Telemetry] Remove telemetry splash page and add conditional messaging (elastic#50189) Revert chromedriver update (elastic#50324) Remove deprecated argument include_type_name from ES calls (elastic#50285) [Maps] add settings to maps telemetry (elastic#50161) remove visualize loader (elastic#46910) Fix misuse of react-router and react-router-dom (elastic#50120)

…-fallback * 'master' of github.com:elastic/kibana: Remove internal platform types exports (elastic#50427) [APM] Document `apm_oss.metricsIndices` and `apm_oss.sourcemap… (elastic#50312) [Telemetry] Server side fetcher (elastic#50015) [SIEM] Detection engine placeholders (elastic#50220) [Uptime] Donut chart loader position centered vertically (elastic#50219) update telemetry banner notice text (elastic#50403) Fix aborting when searching without batching (elastic#49966) [Telemetry] Remove telemetry splash page and add conditional messaging (elastic#50189) Revert chromedriver update (elastic#50324) Remove deprecated argument include_type_name from ES calls (elastic#50285) [Maps] add settings to maps telemetry (elastic#50161) remove visualize loader (elastic#46910) Fix misuse of react-router and react-router-dom (elastic#50120) Move table-list-view to kibana-react (elastic#50046) [ML] Stats bar for data frame analytics (elastic#49464)

…ger-ace-theme * 'master' of github.com:elastic/kibana: (56 commits) [ML] Server info service refactor (elastic#50302) Remove internal platform types exports (elastic#50427) [APM] Document `apm_oss.metricsIndices` and `apm_oss.sourcemap… (elastic#50312) [Telemetry] Server side fetcher (elastic#50015) [SIEM] Detection engine placeholders (elastic#50220) [Uptime] Donut chart loader position centered vertically (elastic#50219) update telemetry banner notice text (elastic#50403) Fix aborting when searching without batching (elastic#49966) [Telemetry] Remove telemetry splash page and add conditional messaging (elastic#50189) Revert chromedriver update (elastic#50324) Remove deprecated argument include_type_name from ES calls (elastic#50285) [Maps] add settings to maps telemetry (elastic#50161) remove visualize loader (elastic#46910) Fix misuse of react-router and react-router-dom (elastic#50120) Move table-list-view to kibana-react (elastic#50046) [ML] Stats bar for data frame analytics (elastic#49464) [ML] Make navigation in tests more stable (elastic#50132) Migrate authorization subsystem to the new platform. (elastic#46145) Bugfix: Interpreter conversion of string to number should throw on NaN elastic#27788 (elastic#50063) Update dependency @elastic/charts to v14 (elastic#49947) ...

Simplifies the telemetry banner for customers.

elasticmachine · 2019-11-13T17:33:33Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 8647f96

* remove exclamation from CN telemetry.welcomeBanner.title * remove unused i18n keys via `scripts/i18n_check.js --fix`

update telemetry banner notice text

f68c610

resolves elastic#50245

pmuellr added Feature:Telemetry v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Stack Services v7.5.0 labels Nov 12, 2019

elasticmachine and others added 2 commits November 12, 2019 10:39

Merge branch 'master' into telemetry/update-banner

e123cc5

fix a broken test, add new one for opt_in_message

ec2d19a

mikecote approved these changes Nov 12, 2019

View reviewed changes

src/legacy/core_plugins/telemetry/public/components/opt_in_banner_component.tsx Outdated Show resolved Hide resolved

src/legacy/core_plugins/telemetry/public/components/opt_in_banner_component.tsx Outdated Show resolved Hide resolved

moar i18n changes

fdacb5e

gmmorris self-requested a review November 12, 2019 21:06

gmmorris approved these changes Nov 12, 2019

View reviewed changes

tsullivan reviewed Nov 12, 2019

View reviewed changes

tsullivan approved these changes Nov 12, 2019

View reviewed changes

alexfrancoeur mentioned this pull request Nov 12, 2019

Update advanced settings text for usage data #50428

Closed

Merge branch 'master' into telemetry/update-banner

8647f96

pmuellr merged commit 2c49ce7 into elastic:master Nov 12, 2019

pmuellr added a commit to pmuellr/kibana that referenced this pull request Nov 13, 2019

update telemetry banner notice text (elastic#50403)

8039144

Simplifies the telemetry banner for customers.

This was referenced Nov 13, 2019

[7.x] update telemetry banner notice text (#50403) #50477

Merged

[7.5] update telemetry banner notice text (#50403) #50479

Merged

pmuellr added a commit that referenced this pull request Nov 13, 2019

update telemetry banner notice text (#50403) (#50477)

35644b1

Simplifies the telemetry banner for customers.

pmuellr added a commit that referenced this pull request Nov 13, 2019

[7.5] update telemetry banner notice text (#50403) (#50479)

180d7fc

* remove exclamation from CN telemetry.welcomeBanner.title * remove unused i18n keys via `scripts/i18n_check.js --fix`

pmuellr added the backported label Nov 13, 2019

Conversation

pmuellr commented Nov 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

old ui

new ui

Checklist

For maintainers

Uh oh!

elasticmachine commented Nov 12, 2019

Uh oh!

elasticmachine commented Nov 12, 2019

💔 Build Failed

Uh oh!

pmuellr commented Nov 12, 2019

Uh oh!

mikecote left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Nov 12, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Nov 12, 2019

💔 Build Failed

Uh oh!

alexfrancoeur commented Nov 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gmmorris left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Nov 12, 2019

💔 Build Failed

Uh oh!

tsullivan Nov 12, 2019

Choose a reason for hiding this comment

Uh oh!

tsullivan Nov 12, 2019

Choose a reason for hiding this comment

Uh oh!

pmuellr Nov 12, 2019

Choose a reason for hiding this comment

Uh oh!

tsullivan left a comment

Choose a reason for hiding this comment

Uh oh!

pmuellr commented Nov 12, 2019

Uh oh!

pmuellr commented Nov 12, 2019

Uh oh!

elasticmachine commented Nov 12, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Nov 13, 2019

💚 Build Succeeded

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

pmuellr commented Nov 12, 2019 •

edited

Loading

alexfrancoeur commented Nov 12, 2019 •

edited

Loading