Skip to content

[ML] Add multi metric job wizard test#45279

Merged
pheyos merged 5 commits intoelastic:masterfrom
pheyos:multi_metric_wizard_test
Sep 11, 2019
Merged

[ML] Add multi metric job wizard test#45279
pheyos merged 5 commits intoelastic:masterfrom
pheyos:multi_metric_wizard_test

Conversation

@pheyos
Copy link
Copy Markdown
Member

@pheyos pheyos commented Sep 10, 2019

Summary

This PR adds functional UI tests to create a machine learning job using the multi metric wizard.

Test steps / validations

  • loads the job management page
  • loads the new job source selection page
  • loads the job type selection page
  • loads the single metric job wizard page
  • displays the time range step
  • displays the event rate chart
  • displays the pick fields step
  • selects detectors and displays detector previews
  • inputs the split field and displays split cards
  • displays the influencer field
  • inputs the bucket span
  • displays the job details step
  • inputs the job id
  • inputs the job description
  • inputs job groups
  • opens the advanced section
  • displays the model plot switch
  • enables the dedicated index switch
  • inputs the model memory limit'
  • displays the validation step
  • displays the summary step
  • creates the job and finishes processing
  • displays the created job in the job list
  • displays details for the created job in the job list

@jgowdyelastic
Copy link
Copy Markdown
Member

Tested locally. LGTM

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Copy link
Copy Markdown
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

const xDomain = getXRange(data);
return (
<div style={{ width, height }} data-test-subj="mlAnomalyChart">
<div style={{ width, height }} data-test-subj={`mlAnomalyChart ${CHART_TYPE[chartType]}`}>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that @dmlemeshko is changing the way that test subjects with spaces work, so I want to make sure that this and that PR don't collide for disaster. Can you two coordinate to make sure that your PRs get merged in the right order?

Copy link
Copy Markdown
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pheyos pheyos merged commit 9cd2f6e into elastic:master Sep 11, 2019
@pheyos pheyos deleted the multi_metric_wizard_test branch September 11, 2019 14:57
pheyos added a commit to pheyos/kibana that referenced this pull request Sep 11, 2019
This PR adds functional UI tests to create a machine learning job using the multi metric wizard.
pheyos added a commit to pheyos/kibana that referenced this pull request Sep 11, 2019
This PR adds functional UI tests to create a machine learning job using the multi metric wizard.
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 11, 2019
…-to-np-ready

* 'master' of github.com:elastic/kibana:
  Upgrade EUI to 13.8.1 (elastic#45052)
  [ML] Add multi metric job wizard test (elastic#45279)
  [SIEM] Inject/apply KQL changed in refresh button (elastic#45065)
  [Graph] Type persistence (elastic#44985)
  Functional tests: convert more test/services to TS (elastic#45176)
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 11, 2019
…ditor

* 'master' of github.com:elastic/kibana: (76 commits)
  Upgrade EUI to 13.8.1 (elastic#45052)
  [ML] Add multi metric job wizard test (elastic#45279)
  [SIEM] Inject/apply KQL changed in refresh button (elastic#45065)
  [Graph] Type persistence (elastic#44985)
  Functional tests: convert more test/services to TS (elastic#45176)
  [ML] Fixes display of matching modules in index data visualizer (elastic#45261)
  [Console] Update indentation behaviour (elastic#45249)
  Convert value provided to PhraseValueInput to string to catch Exception (elastic#45259)
  [Region Map] Fix loading default vector map and base layer setting (elastic#43858)
  [ML] Fixing empty time range when cloning jobs (elastic#45286)
  [ML] Fixing wizard validation delay (elastic#45265)
  [Logs UI] Interpret finished analysis jobs as healthy (elastic#45268)
  [Console] SQL template with triple quote in completion (elastic#45248)
  [ML] Data Frames: Cards as links (elastic#45254)
  fix(code/frontend): should show updating instead of cloning when updating (elastic#45238)
  fix(code/frontend): fix document search result from (elastic#45236)
  disable another flaky suite (elastic#45323) (elastic#45330)
  disable flaky suite (elastic#45105)
  skip flaky suite (elastic#43069)
  skip flaky suite (elastic#45089)
  ...
pheyos added a commit that referenced this pull request Sep 11, 2019
This PR adds functional UI tests to create a machine learning job using the multi metric wizard.
pheyos added a commit that referenced this pull request Sep 11, 2019
This PR adds functional UI tests to create a machine learning job using the multi metric wizard.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v7.4.0 v7.5.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants