[ML] Fixing wizard validation delay#45265
Merged
jgowdyelastic merged 2 commits intoelastic:masterfrom Sep 11, 2019
Merged
Conversation
Contributor
|
Pinging @elastic/ml-ui |
bad01fa to
d0e1a9a
Compare
Contributor
💚 Build Succeeded |
walterra
approved these changes
Sep 11, 2019
Contributor
walterra
left a comment
There was a problem hiding this comment.
LGTM, just added 2 small suggestions.
x-pack/legacy/plugins/ml/public/jobs/new_job_new/common/job_validator/job_validator.ts
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/ml/public/jobs/new_job_new/pages/new_job/wizard.tsx
Outdated
Show resolved
Hide resolved
pheyos
approved these changes
Sep 11, 2019
Member
pheyos
left a comment
There was a problem hiding this comment.
Tested and couldn't reproduce the original issue any more.
59824d0 to
5860819
Compare
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Sep 11, 2019
* [ML] Fixing wizard validation delay * changes based on review
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Sep 11, 2019
* [ML] Fixing wizard validation delay * changes based on review
jgowdyelastic
added a commit
that referenced
this pull request
Sep 11, 2019
jgowdyelastic
added a commit
that referenced
this pull request
Sep 11, 2019
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 11, 2019
…-to-np-ready * 'master' of github.com:elastic/kibana: (25 commits) [ML] Fixes display of matching modules in index data visualizer (elastic#45261) [Console] Update indentation behaviour (elastic#45249) Convert value provided to PhraseValueInput to string to catch Exception (elastic#45259) [Region Map] Fix loading default vector map and base layer setting (elastic#43858) [ML] Fixing empty time range when cloning jobs (elastic#45286) [ML] Fixing wizard validation delay (elastic#45265) [Logs UI] Interpret finished analysis jobs as healthy (elastic#45268) [Console] SQL template with triple quote in completion (elastic#45248) [ML] Data Frames: Cards as links (elastic#45254) fix(code/frontend): should show updating instead of cloning when updating (elastic#45238) fix(code/frontend): fix document search result from (elastic#45236) disable another flaky suite (elastic#45323) (elastic#45330) disable flaky suite (elastic#45105) skip flaky suite (elastic#43069) skip flaky suite (elastic#45089) disable jest suite that has no enabled tests (elastic#44250) disable flaky test (elastic#45317) disable flaky test (elastic#45315) [DOCS] Creates developer folder (elastic#45280) [SIEM] Changes ML conditional links to use tabs, fixes a small bug with null filterQuery (elastic#45218) ...
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 11, 2019
…ditor * 'master' of github.com:elastic/kibana: (76 commits) Upgrade EUI to 13.8.1 (elastic#45052) [ML] Add multi metric job wizard test (elastic#45279) [SIEM] Inject/apply KQL changed in refresh button (elastic#45065) [Graph] Type persistence (elastic#44985) Functional tests: convert more test/services to TS (elastic#45176) [ML] Fixes display of matching modules in index data visualizer (elastic#45261) [Console] Update indentation behaviour (elastic#45249) Convert value provided to PhraseValueInput to string to catch Exception (elastic#45259) [Region Map] Fix loading default vector map and base layer setting (elastic#43858) [ML] Fixing empty time range when cloning jobs (elastic#45286) [ML] Fixing wizard validation delay (elastic#45265) [Logs UI] Interpret finished analysis jobs as healthy (elastic#45268) [Console] SQL template with triple quote in completion (elastic#45248) [ML] Data Frames: Cards as links (elastic#45254) fix(code/frontend): should show updating instead of cloning when updating (elastic#45238) fix(code/frontend): fix document search result from (elastic#45236) disable another flaky suite (elastic#45323) (elastic#45330) disable flaky suite (elastic#45105) skip flaky suite (elastic#43069) skip flaky suite (elastic#45089) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue where it is possible to jump to the next step of the wizard immediately after entering some invalid data into an input.
This is caused by the 500ms validation start delay which allows the user to enter continue to type before running the validation.
This change disables the
Nextbutton as soon as the user starts typing. The button remains disabled until the validation returns a success.To test, edit the bucket span, entering a bad value and immediately press the
Nextbutton. you should not be able to move to the next step of the wizard.cc @pheyos
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately