Functional tests: convert more test/services to TS by dmlemeshko · Pull Request #45176 · elastic/kibana

dmlemeshko · 2019-09-09T17:59:54Z

Summary

This PR migrates services located in test/services to typescript.
I added small descriptions to some functions to clarify how they should be used.

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

test/functional/services/combo_box.ts

test/functional/services/table.ts

elasticmachine · 2019-09-09T19:20:19Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-09-10T08:19:07Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

dmlemeshko · 2019-09-10T08:29:40Z

retest

test/functional/services/combo_box.ts

elasticmachine · 2019-09-10T09:42:58Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-09-10T11:05:26Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

test/functional/services/combo_box.ts

Co-Authored-By: Tre' <wayne.seymour@elastic.co>

wayneseymour

Great work @dmlemeshko , lemme know if we need to zoom or discuss the type signatures.

test/functional/services/combo_box.ts

test/functional/services/embedding.ts

wayneseymour · 2019-09-10T15:01:02Z

test/functional/services/filter_bar.ts

-  const testSubjects = getService('testSubjects');
+import { FtrProviderContext } from '../ftr_provider_context';
+
+export function FilterBarProvider({ getService, getPageObjects }: FtrProviderContext) {


Suggested change

export function FilterBarProvider({ getService, getPageObjects }: FtrProviderContext) {

export function FilterBarProvider({ getService, getPageObjects }: FtrProviderContext): InstanceType<FilterBar> {

Again, not sure if this is how to properly type a factory function in TS.

wayneseymour · 2019-09-10T15:03:01Z

test/functional/services/flyout.ts

-export function FlyoutProvider({ getService }) {
+import { FtrProviderContext } from '../ftr_provider_context';
+
+export function FlyoutProvider({ getService }: FtrProviderContext) {


Suggested change

export function FlyoutProvider({ getService }: FtrProviderContext) {

export function FlyoutProvider({ getService }: FtrProviderContext): InstanceType<typeof Flyout> {

Maybe?

wayneseymour · 2019-09-10T15:53:45Z

test/functional/services/renderable.ts

 const DATA_LOADING_SELECTOR = '[data-loading]';

-export function RenderableProvider({ getService }) {
+export function RenderableProvider({ getService }: FtrProviderContext) {


Suggested change

export function RenderableProvider({ getService }: FtrProviderContext) {

export function RenderableProvider({ getService }: FtrProviderContext): InstanceType<typeof Renderable> {

wayneseymour · 2019-09-10T15:57:54Z

test/functional/services/renderable.ts

+          throw new Error(`${
+            completedElements.length
+          } elements completed rendering, still waiting on a total of ${count}
+                specifically:\n${pendingElementNames.join('\n')}`);


I'm curious, did prettier or eslint cause this formatting?
Not interested in bikeshedding on formatting, but it seemed peculiar.

test/functional/services/table.ts

wayneseymour · 2019-09-10T16:01:28Z

test/functional/services/visualize_listing_table.ts

-export function VisualizeListingTableProvider({ getService, getPageObjects }) {
+import { FtrProviderContext } from '../ftr_provider_context';
+
+export function VisualizeListingTableProvider({ getService, getPageObjects }: FtrProviderContext) {


Suggested change

export function VisualizeListingTableProvider({ getService, getPageObjects }: FtrProviderContext) {

export function VisualizeListingTableProvider({ getService, getPageObjects }: FtrProviderContext): InstanceType<typeof VisualizeListingTable> {

test/functional/services/visualize_listing_table.ts

Co-Authored-By: Tre' <wayne.seymour@elastic.co>

spalger

IMO, specifying explicit return values when they can be inferred is unnecessary. But changes LGTM

…o tsfy-test-services

elasticmachine · 2019-09-10T22:11:03Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-09-10T22:58:09Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

wayneseymour · 2019-09-11T13:58:17Z

LGTM

wayneseymour

LGTM

* convert more test/services to TS * Update test/functional/services/combo_box.ts Co-Authored-By: Tre' <wayne.seymour@elastic.co> * Update test/functional/services/combo_box.ts Co-Authored-By: Tre' <wayne.seymour@elastic.co> * Update test/functional/services/combo_box.ts Co-Authored-By: Tre' <wayne.seymour@elastic.co> * fix lint error

…-to-np-ready * 'master' of github.com:elastic/kibana: Upgrade EUI to 13.8.1 (elastic#45052) [ML] Add multi metric job wizard test (elastic#45279) [SIEM] Inject/apply KQL changed in refresh button (elastic#45065) [Graph] Type persistence (elastic#44985) Functional tests: convert more test/services to TS (elastic#45176)

* convert more test/services to TS * Update test/functional/services/combo_box.ts Co-Authored-By: Tre' <wayne.seymour@elastic.co> * Update test/functional/services/combo_box.ts Co-Authored-By: Tre' <wayne.seymour@elastic.co> * Update test/functional/services/combo_box.ts Co-Authored-By: Tre' <wayne.seymour@elastic.co> * fix lint error

…ditor * 'master' of github.com:elastic/kibana: (76 commits) Upgrade EUI to 13.8.1 (elastic#45052) [ML] Add multi metric job wizard test (elastic#45279) [SIEM] Inject/apply KQL changed in refresh button (elastic#45065) [Graph] Type persistence (elastic#44985) Functional tests: convert more test/services to TS (elastic#45176) [ML] Fixes display of matching modules in index data visualizer (elastic#45261) [Console] Update indentation behaviour (elastic#45249) Convert value provided to PhraseValueInput to string to catch Exception (elastic#45259) [Region Map] Fix loading default vector map and base layer setting (elastic#43858) [ML] Fixing empty time range when cloning jobs (elastic#45286) [ML] Fixing wizard validation delay (elastic#45265) [Logs UI] Interpret finished analysis jobs as healthy (elastic#45268) [Console] SQL template with triple quote in completion (elastic#45248) [ML] Data Frames: Cards as links (elastic#45254) fix(code/frontend): should show updating instead of cloning when updating (elastic#45238) fix(code/frontend): fix document search result from (elastic#45236) disable another flaky suite (elastic#45323) (elastic#45330) disable flaky suite (elastic#45105) skip flaky suite (elastic#43069) skip flaky suite (elastic#45089) ...

* convert more test/services to TS * Update test/functional/services/combo_box.ts Co-Authored-By: Tre' <wayne.seymour@elastic.co> * Update test/functional/services/combo_box.ts Co-Authored-By: Tre' <wayne.seymour@elastic.co> * Update test/functional/services/combo_box.ts Co-Authored-By: Tre' <wayne.seymour@elastic.co> * fix lint error

dmlemeshko · 2019-09-11T18:33:03Z

7.x 5c3cd1b
7.4 cb681ed
7.3 d4c28ec

dmlemeshko commented Sep 9, 2019

View reviewed changes

test/functional/services/combo_box.ts Outdated Show resolved Hide resolved

dmlemeshko commented Sep 9, 2019

View reviewed changes

test/functional/services/table.ts Outdated Show resolved Hide resolved

dmlemeshko force-pushed the tsfy-test-services branch from ea00f95 to b9eb1ad Compare September 10, 2019 07:01

dmlemeshko commented Sep 10, 2019

View reviewed changes

test/functional/services/combo_box.ts Outdated Show resolved Hide resolved

convert more test/services to TS

7091caa

dmlemeshko force-pushed the tsfy-test-services branch from b9eb1ad to 7091caa Compare September 10, 2019 09:43

dmlemeshko requested review from spalger and wayneseymour September 10, 2019 11:10

dmlemeshko added release_note:skip Skip the PR/issue when compiling release notes v7.3.2 v7.4.1 v7.5.0 v8.0.0 labels Sep 10, 2019

dmlemeshko marked this pull request as ready for review September 10, 2019 14:19

wayneseymour reviewed Sep 10, 2019

View reviewed changes

test/functional/services/combo_box.ts Outdated Show resolved Hide resolved

Update test/functional/services/combo_box.ts

1011624

Co-Authored-By: Tre' <wayne.seymour@elastic.co>

wayneseymour reviewed Sep 10, 2019

View reviewed changes

dmlemeshko and others added 3 commits September 10, 2019 22:53

Update test/functional/services/combo_box.ts

5778938

Co-Authored-By: Tre' <wayne.seymour@elastic.co>

Update test/functional/services/combo_box.ts

22b3de4

Co-Authored-By: Tre' <wayne.seymour@elastic.co>

Merge remote-tracking branch 'upstream/master' into tsfy-test-services

c1b0af4

spalger approved these changes Sep 10, 2019

View reviewed changes

dmlemeshko added 2 commits September 10, 2019 23:15

Merge branch 'tsfy-test-services' of github.com:dmlemeshko/kibana int…

5cb4866

…o tsfy-test-services

fix lint error

e32b4ee

wayneseymour approved these changes Sep 11, 2019

View reviewed changes

dmlemeshko merged commit 8a900bf into elastic:master Sep 11, 2019

dmlemeshko mentioned this pull request Sep 11, 2019

[7.x] Functional tests: convert more test/services to TS (#45176) #45385

Merged

dmlemeshko mentioned this pull request Sep 11, 2019

[7.4] Functional tests: convert more test/services to TS (#45176) #45386

Merged

dmlemeshko mentioned this pull request Sep 11, 2019

[7.3] Functional tests: convert more test/services to TS (#45176) #45396

Merged

dmlemeshko deleted the tsfy-test-services branch January 31, 2022 12:28

	export function FilterBarProvider({ getService, getPageObjects }: FtrProviderContext) {
	export function FilterBarProvider({ getService, getPageObjects }: FtrProviderContext): InstanceType<FilterBar> {

	export function FlyoutProvider({ getService }: FtrProviderContext) {
	export function FlyoutProvider({ getService }: FtrProviderContext): InstanceType<typeof Flyout> {

	export function RenderableProvider({ getService }: FtrProviderContext) {
	export function RenderableProvider({ getService }: FtrProviderContext): InstanceType<typeof Renderable> {

	export function VisualizeListingTableProvider({ getService, getPageObjects }: FtrProviderContext) {
	export function VisualizeListingTableProvider({ getService, getPageObjects }: FtrProviderContext): InstanceType<typeof VisualizeListingTable> {

Conversation

dmlemeshko commented Sep 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Sep 9, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Sep 10, 2019

💚 Build Succeeded

Uh oh!

dmlemeshko commented Sep 10, 2019

Uh oh!

Uh oh!

elasticmachine commented Sep 10, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Sep 10, 2019

💚 Build Succeeded

Uh oh!

Uh oh!

wayneseymour left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wayneseymour Sep 10, 2019

Choose a reason for hiding this comment

Uh oh!

wayneseymour Sep 10, 2019

Choose a reason for hiding this comment

Uh oh!

wayneseymour Sep 10, 2019

Choose a reason for hiding this comment

Uh oh!

wayneseymour Sep 10, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

wayneseymour Sep 10, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

spalger left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Sep 10, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Sep 10, 2019

💚 Build Succeeded

Uh oh!

wayneseymour commented Sep 11, 2019

Uh oh!

wayneseymour left a comment

Choose a reason for hiding this comment

Uh oh!

dmlemeshko commented Sep 11, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dmlemeshko commented Sep 9, 2019 •

edited

Loading