[Region Map] Fix loading default vector map and base layer setting by sulemanof · Pull Request #43858 · elastic/kibana

sulemanof · 2019-08-23T13:31:41Z

Summary

Should set the default value (actually the first one) from the dropdown.
The reason is caused by separate states in the visualization and the editor.
After loading the vis, the editor watcher updates its state with state from the vis ->

src/legacy/ui/public/vis/editors/default/default.js

The changes are done with eslint react-hooks plugin enabled, so necessary values were added as ~~watchers~~

Also crated a useMount custom effect for invoking callbacks only after the first render.

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

elasticmachine · 2019-08-23T13:32:34Z

Pinging @elastic/kibana-app

elasticmachine · 2019-08-23T14:50:45Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

…p_vector_layer

flash1293 · 2019-08-26T08:27:37Z

@ppisljar could you take this one? Not completely sure about the implications - is this the same thing we discussed in #38644 ?

elasticmachine · 2019-08-26T08:50:41Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

…p_vector_layer

elasticmachine · 2019-08-28T09:09:47Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

sulemanof · 2019-08-28T13:30:19Z

Hi @timroes @ppisljar !
Could you please take a look at this? Thanks in advance!

…p_vector_layer

elasticmachine · 2019-08-30T10:30:25Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

…p_vector_layer

elasticmachine · 2019-09-02T10:01:22Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

ppisljar

while this does seem to fix the bug i don't like the way we are calling forceUpateVis()

the real problem seems to be that vis defaults are not set correctly due to the fact that we need to get the list of layers async. We can either make sure the defaults are correctly set, or have a working fallback in the maps visualization.

i am also not sure if using forceUpdateVis() might have some other side effects that we are not aware of here.

ppisljar · 2019-09-03T07:10:49Z

src/legacy/core_plugins/tile_map/public/components/wms_options.tsx

@@ -75,10 +80,18 @@ function WmsOptions({

        if (!wms.selectedTmsLayer && newBaseLayers.length) {
          setWmsOption('selectedTmsLayer', newBaseLayers[0]);


setting this here will require:

clicking on the "play" button

or calling forceUpdateVis (to send changes down to vis)

however i am wondering, should this happen here ? i see a few options:

have tms stuff preloaded (at the vis registration time) ... then we should be able to set visualization defaults to the first layer.

move the logic into map visualization .... if layer is not set use the first layer

i would prefer the first one.

The code which registers vis is run every time when the app opens (or the page is refreshed) no matter what plugin opened. I think the layers should be fetched only when map visualization opens. For example during redirecting to the editor but before rendering the default editor we can load tms layers and set the first layer. I tried to implement this idea. @ppisljar could you please have a look?

…p_vector_layer

elasticmachine · 2019-09-04T14:46:51Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-09-09T11:57:46Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

ppisljar

code LGTM

…p_vector_layer

elasticmachine · 2019-09-11T10:07:22Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

…lastic#43858) * Fix loading default vector layer * Move layers loading to vis initialization * Move layers loading to editor initialization

…43858) (#45363) * Fix loading default vector layer * Move layers loading to vis initialization * Move layers loading to editor initialization

…-to-np-ready * 'master' of github.com:elastic/kibana: (25 commits) [ML] Fixes display of matching modules in index data visualizer (elastic#45261) [Console] Update indentation behaviour (elastic#45249) Convert value provided to PhraseValueInput to string to catch Exception (elastic#45259) [Region Map] Fix loading default vector map and base layer setting (elastic#43858) [ML] Fixing empty time range when cloning jobs (elastic#45286) [ML] Fixing wizard validation delay (elastic#45265) [Logs UI] Interpret finished analysis jobs as healthy (elastic#45268) [Console] SQL template with triple quote in completion (elastic#45248) [ML] Data Frames: Cards as links (elastic#45254) fix(code/frontend): should show updating instead of cloning when updating (elastic#45238) fix(code/frontend): fix document search result from (elastic#45236) disable another flaky suite (elastic#45323) (elastic#45330) disable flaky suite (elastic#45105) skip flaky suite (elastic#43069) skip flaky suite (elastic#45089) disable jest suite that has no enabled tests (elastic#44250) disable flaky test (elastic#45317) disable flaky test (elastic#45315) [DOCS] Creates developer folder (elastic#45280) [SIEM] Changes ML conditional links to use tabs, fixes a small bug with null filterQuery (elastic#45218) ...

…ditor * 'master' of github.com:elastic/kibana: (76 commits) Upgrade EUI to 13.8.1 (elastic#45052) [ML] Add multi metric job wizard test (elastic#45279) [SIEM] Inject/apply KQL changed in refresh button (elastic#45065) [Graph] Type persistence (elastic#44985) Functional tests: convert more test/services to TS (elastic#45176) [ML] Fixes display of matching modules in index data visualizer (elastic#45261) [Console] Update indentation behaviour (elastic#45249) Convert value provided to PhraseValueInput to string to catch Exception (elastic#45259) [Region Map] Fix loading default vector map and base layer setting (elastic#43858) [ML] Fixing empty time range when cloning jobs (elastic#45286) [ML] Fixing wizard validation delay (elastic#45265) [Logs UI] Interpret finished analysis jobs as healthy (elastic#45268) [Console] SQL template with triple quote in completion (elastic#45248) [ML] Data Frames: Cards as links (elastic#45254) fix(code/frontend): should show updating instead of cloning when updating (elastic#45238) fix(code/frontend): fix document search result from (elastic#45236) disable another flaky suite (elastic#45323) (elastic#45330) disable flaky suite (elastic#45105) skip flaky suite (elastic#43069) skip flaky suite (elastic#45089) ...

Fix loading default vector layer

efc37e4

sulemanof requested a review from maryia-lapata August 23, 2019 13:31

sulemanof added release_note:fix Feature:Region Map Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.4.0 v8.0.0 labels Aug 23, 2019

sulemanof requested review from flash1293, ppisljar and timroes August 23, 2019 13:49

sulemanof changed the title ~~[Region Map] Fix loading default vector map and vase layer setting~~ [Region Map] Fix loading default vector map and base layer setting Aug 26, 2019

Merge branch 'master' of github.com:elastic/kibana into fix/region_ma…

33c5eff

…p_vector_layer

sulemanof requested a review from a team as a code owner August 26, 2019 07:30

flash1293 removed their request for review August 26, 2019 08:36

Merge branch 'master' of github.com:elastic/kibana into fix/region_ma…

61f4515

…p_vector_layer

Merge branch 'master' of github.com:elastic/kibana into fix/region_ma…

9b36b95

…p_vector_layer

timroes requested review from flash1293 and removed request for flash1293 and timroes August 30, 2019 13:05

maryia-lapata added the v7.5.0 label Sep 2, 2019

Merge branch 'master' of github.com:elastic/kibana into fix/region_ma…

ec27c1a

…p_vector_layer

ppisljar requested changes Sep 3, 2019

View reviewed changes

maryia-lapata added 2 commits September 4, 2019 16:25

Move layers loading to vis initialization

62a5b93

Merge branch 'master' of github.com:elastic/kibana into fix/region_ma…

6c0d26c

…p_vector_layer

maryia-lapata added 2 commits September 9, 2019 09:04

Merge branch 'master' into fix/region_map_vector_layer

74bd87e

Move layers loading to editor initialization

f49d569

ppisljar approved these changes Sep 11, 2019

View reviewed changes

Merge branch 'master' of github.com:elastic/kibana into fix/region_ma…

36d9776

…p_vector_layer

maryia-lapata removed the v7.4.0 label Sep 11, 2019

maryia-lapata merged commit 32d98d5 into elastic:master Sep 11, 2019

maryia-lapata mentioned this pull request Sep 11, 2019

[7.x] [Region Map] Fix loading default vector map and base layer setting (#43858) #45363

Merged

maryia-lapata added the backported label Sep 11, 2019

sulemanof deleted the fix/region_map_vector_layer branch September 16, 2019 11:35

		@@ -75,10 +80,18 @@ function WmsOptions({

		if (!wms.selectedTmsLayer && newBaseLayers.length) {
		setWmsOption('selectedTmsLayer', newBaseLayers[0]);

Conversation

sulemanof commented Aug 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Aug 23, 2019

Uh oh!

elasticmachine commented Aug 23, 2019

💚 Build Succeeded

Uh oh!

flash1293 commented Aug 26, 2019

Uh oh!

elasticmachine commented Aug 26, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Aug 28, 2019

💚 Build Succeeded

Uh oh!

sulemanof commented Aug 28, 2019

Uh oh!

elasticmachine commented Aug 30, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Sep 2, 2019

💚 Build Succeeded

Uh oh!

ppisljar left a comment

Choose a reason for hiding this comment

Uh oh!

ppisljar Sep 3, 2019

Choose a reason for hiding this comment

Uh oh!

maryia-lapata Sep 9, 2019

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Sep 4, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Sep 9, 2019

💚 Build Succeeded

Uh oh!

ppisljar left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Sep 11, 2019

💚 Build Succeeded

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sulemanof commented Aug 23, 2019 •

edited

Loading