Skip to content

[optimizer] use more precise cache-busting strategy#44724

Merged
spalger merged 1 commit intoelastic:masterfrom
spalger:implement/more-precise-bundle-caching
Sep 4, 2019
Merged

[optimizer] use more precise cache-busting strategy#44724
spalger merged 1 commit intoelastic:masterfrom
spalger:implement/more-precise-bundle-caching

Conversation

@spalger
Copy link
Copy Markdown
Contributor

@spalger spalger commented Sep 3, 2019

Fixes #42907

In order to prevent server-only plugins from invalidating the bundles, and therefore triggering an optimization, this changes the context object that is printed at the top of every bundle's entry file to only include appExtensions, which are what backs the uiExports/* imports.

All other uiExports are considered to be server-side only, except for new app uiExports, which will produce new bundles that are not found on the file system and always invalidate the cache.

CC @joshdover as this may interact with the way we bundle new platform plugins

@spalger spalger added Team:Operations Kibana-Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.5.0 labels Sep 3, 2019
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-operations

Copy link
Copy Markdown
Contributor

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@spalger spalger merged commit ac68746 into elastic:master Sep 4, 2019
spalger pushed a commit to spalger/kibana that referenced this pull request Sep 4, 2019
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 4, 2019
…-to-np-ready

* 'master' of github.com:elastic/kibana: (45 commits)
  Fixing flaky copy-to-space test (elastic#44656)
  [ML] Enable data visualizer link on job types page for non-time index (elastic#44667)
  [ML] Adding index pattern title to wizard summary step (elastic#44662)
  Convert remaining data.indexPatterns items to use TS (elastic#44654)
  [visualize/_tsvb_time_series] fix flaky test (elastic#44505)
  [SIEM] Updates fields in map tooltip and fixes filtering on undefined values (elastic#44718)
  [SIEM] Remove deprecation warning from momentJS test (elastic#44732)
  [SIEM] Fixes the rendering order and adds unit tests to prevent rendering to get out of order (elastic#44728)
  [optimizer] use more precise cache-busting strategy (elastic#44724)
  [Maps] Reverse the attribution order so left-to-right order matches top-to-bottom (elastic#44415)
  Update sinon related packages (elastic#43952)
  [SIEM] change flag to drag and drop field (elastic#44705)
  Update dependency @types/object-hash to ^1.3.0 (elastic#43954)
  mark eslint config as root (elastic#44699)
  Adds geo_point to normalizeType helper (elastic#44410)
  [Uptime]Feature/38542  align uptime help menu with other apps (elastic#44536)
  Removed unused remove icon component (elastic#44698)
  Update unit tests to remove warnings from test output. (elastic#41840)
  Fix rawChecksums in chromium build and rename for clarity (elastic#44665)
  [Uptime]removed extra slash from integeration urls (elastic#44469)
  ...

# Conflicts:
#	rfcs/text/0004_application_service_mounting.md
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 4, 2019
…ana into chore/console-to-np-ready

* 'chore/console-to-np-ready' of github.com:jloleysens/kibana: (45 commits)
  Fixing flaky copy-to-space test (elastic#44656)
  [ML] Enable data visualizer link on job types page for non-time index (elastic#44667)
  [ML] Adding index pattern title to wizard summary step (elastic#44662)
  Convert remaining data.indexPatterns items to use TS (elastic#44654)
  [visualize/_tsvb_time_series] fix flaky test (elastic#44505)
  [SIEM] Updates fields in map tooltip and fixes filtering on undefined values (elastic#44718)
  [SIEM] Remove deprecation warning from momentJS test (elastic#44732)
  [SIEM] Fixes the rendering order and adds unit tests to prevent rendering to get out of order (elastic#44728)
  [optimizer] use more precise cache-busting strategy (elastic#44724)
  [Maps] Reverse the attribution order so left-to-right order matches top-to-bottom (elastic#44415)
  Update sinon related packages (elastic#43952)
  [SIEM] change flag to drag and drop field (elastic#44705)
  Update dependency @types/object-hash to ^1.3.0 (elastic#43954)
  mark eslint config as root (elastic#44699)
  Adds geo_point to normalizeType helper (elastic#44410)
  [Uptime]Feature/38542  align uptime help menu with other apps (elastic#44536)
  Removed unused remove icon component (elastic#44698)
  Update unit tests to remove warnings from test output. (elastic#41840)
  Fix rawChecksums in chromium build and rename for clarity (elastic#44665)
  [Uptime]removed extra slash from integeration urls (elastic#44469)
  ...
@spalger
Copy link
Copy Markdown
Contributor Author

spalger commented Sep 4, 2019

7.x/7.5: ce2cfc1

@spalger spalger deleted the implement/more-precise-bundle-caching branch September 4, 2019 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.5.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't optimize plugins that only provide extra binaries

3 participants