[Uptime]Feature/38542 align uptime help menu with other apps#44536
Merged
shahzad31 merged 6 commits intoelastic:masterfrom Sep 3, 2019
Merged
Conversation
Contributor
|
Pinging @elastic/uptime |
Contributor
💚 Build Succeeded |
justinkambic
requested changes
Sep 3, 2019
x-pack/legacy/plugins/uptime/public/lib/adapters/framework/kibana_global_help.tsx
Outdated
Show resolved
Hide resolved
Co-Authored-By: Justin Kambic <justin.kambic@elastic.co>
https://github.com/shahzad31/kibana into feature/38542--align-uptime-help-menu-with-other-apps
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 4, 2019
…-to-np-ready * 'master' of github.com:elastic/kibana: (45 commits) Fixing flaky copy-to-space test (elastic#44656) [ML] Enable data visualizer link on job types page for non-time index (elastic#44667) [ML] Adding index pattern title to wizard summary step (elastic#44662) Convert remaining data.indexPatterns items to use TS (elastic#44654) [visualize/_tsvb_time_series] fix flaky test (elastic#44505) [SIEM] Updates fields in map tooltip and fixes filtering on undefined values (elastic#44718) [SIEM] Remove deprecation warning from momentJS test (elastic#44732) [SIEM] Fixes the rendering order and adds unit tests to prevent rendering to get out of order (elastic#44728) [optimizer] use more precise cache-busting strategy (elastic#44724) [Maps] Reverse the attribution order so left-to-right order matches top-to-bottom (elastic#44415) Update sinon related packages (elastic#43952) [SIEM] change flag to drag and drop field (elastic#44705) Update dependency @types/object-hash to ^1.3.0 (elastic#43954) mark eslint config as root (elastic#44699) Adds geo_point to normalizeType helper (elastic#44410) [Uptime]Feature/38542 align uptime help menu with other apps (elastic#44536) Removed unused remove icon component (elastic#44698) Update unit tests to remove warnings from test output. (elastic#41840) Fix rawChecksums in chromium build and rename for clarity (elastic#44665) [Uptime]removed extra slash from integeration urls (elastic#44469) ... # Conflicts: # rfcs/text/0004_application_service_mounting.md
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 4, 2019
…ana into chore/console-to-np-ready * 'chore/console-to-np-ready' of github.com:jloleysens/kibana: (45 commits) Fixing flaky copy-to-space test (elastic#44656) [ML] Enable data visualizer link on job types page for non-time index (elastic#44667) [ML] Adding index pattern title to wizard summary step (elastic#44662) Convert remaining data.indexPatterns items to use TS (elastic#44654) [visualize/_tsvb_time_series] fix flaky test (elastic#44505) [SIEM] Updates fields in map tooltip and fixes filtering on undefined values (elastic#44718) [SIEM] Remove deprecation warning from momentJS test (elastic#44732) [SIEM] Fixes the rendering order and adds unit tests to prevent rendering to get out of order (elastic#44728) [optimizer] use more precise cache-busting strategy (elastic#44724) [Maps] Reverse the attribution order so left-to-right order matches top-to-bottom (elastic#44415) Update sinon related packages (elastic#43952) [SIEM] change flag to drag and drop field (elastic#44705) Update dependency @types/object-hash to ^1.3.0 (elastic#43954) mark eslint config as root (elastic#44699) Adds geo_point to normalizeType helper (elastic#44410) [Uptime]Feature/38542 align uptime help menu with other apps (elastic#44536) Removed unused remove icon component (elastic#44698) Update unit tests to remove warnings from test output. (elastic#41840) Fix rawChecksums in chromium build and rename for clarity (elastic#44665) [Uptime]removed extra slash from integeration urls (elastic#44469) ...
shahzad31
added a commit
to shahzad31/kibana
that referenced
this pull request
Sep 5, 2019
…#44536) * update uptime golabl help menu * update test * Update help label correctly Co-Authored-By: Justin Kambic <justin.kambic@elastic.co> * update snaps for test
shahzad31
added a commit
that referenced
this pull request
Sep 5, 2019
Contributor
💔 Build Failed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolves #38542
resolves #40989
Have updated Uptime global help menu to sync it with other apps, as mentioned in the issue.
Checklist
Have updated the help menu to align it better with other apps, and have added localised look and feel for uptime app docs