fix flaky TSVB test by dmlemeshko · Pull Request #44505 · elastic/kibana

dmlemeshko · 2019-08-30T15:23:45Z

Summary

There is a test that constantly fails locally and somehow more stable on CI.

The issue is failing click on dropdown option on TSVB Series Option tab, it fails with StaleElementException.

           └- ✖ fail: "visualize app  visual builder Time Series should show the correct count in the legend with "Human readable" duration formatter"
           │      StaleElementReferenceError: stale element reference: element is not attached to the page document
           │   (Session info: chrome=76.0.3809.100)
           │   (Driver info: chromedriver=76.0.3809.68 (420c9498db8ce8fcd190a954d51297672c1515d5-refs/branch-heads/3809@{#864}),platform=Mac OS X 10.14.6 x86_64)

The only working option for me was to click with a mouse (works on both Chrome and Firefox)

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

elasticmachine · 2019-08-30T17:05:38Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

dmlemeshko · 2019-08-30T21:39:35Z

retest

elasticmachine · 2019-08-30T23:16:51Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-09-02T18:27:24Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

maryia-lapata

LGTM,
I run tests locally (Mac)

LeeDr

LGTM - I ran all 'visual builder' tests locally on Windows with Chrome browser and all 26 tests passed. I made one comment about finding data-test-subj's that start with the value parameter but it's not really a change in this PR.

Just for fun I re-ran the 'visual builder' tests with this change (= instead of ^=) and they all passed;

diff --git a/test/functional/services/combo_box.ts b/test/functional/services/combo_box.ts
index 2e44e0248c..65270eac98 100644
--- a/test/functional/services/combo_box.ts
+++ b/test/functional/services/combo_box.ts
@@ -74,7 +74,7 @@ export function ComboBoxProvider({ getService, getPageObjects }: FtrProviderCont

       if (value !== undefined) {
         const selectOptions = await find.allByCssSelector(
-          `.euiFilterSelectItem[title^="${value.toString().trim()}"]`,
+          `.euiFilterSelectItem[title="${value.toString().trim()}"]`,
           WAIT_FOR_EXISTS_TIME
         );

But I didn't run all tests so not fully tested.

LeeDr · 2019-09-03T19:20:20Z

test/functional/services/combo_box.ts

      if (value !== undefined) {
-        const options = await find.allByCssSelector(
+        const selectOptions = await find.allByCssSelector(
          `.euiFilterSelectItem[title^="${value.toString().trim()}"]`,


I guess this isn't a change in this PR, but I don't understand why we're only looking for the case where the element's title attribute starts with value. I would think we would want to find the element who's title equals value? Maybe this was an issue with data-test-subj's with spaces in them? If that issue is fixed maybe we could improve this here for exact match?

It is used to match drop-down option that starts with provided text. I remember testing related PR and may confirm we need it for some tests

…-to-np-ready * 'master' of github.com:elastic/kibana: (45 commits) Fixing flaky copy-to-space test (elastic#44656) [ML] Enable data visualizer link on job types page for non-time index (elastic#44667) [ML] Adding index pattern title to wizard summary step (elastic#44662) Convert remaining data.indexPatterns items to use TS (elastic#44654) [visualize/_tsvb_time_series] fix flaky test (elastic#44505) [SIEM] Updates fields in map tooltip and fixes filtering on undefined values (elastic#44718) [SIEM] Remove deprecation warning from momentJS test (elastic#44732) [SIEM] Fixes the rendering order and adds unit tests to prevent rendering to get out of order (elastic#44728) [optimizer] use more precise cache-busting strategy (elastic#44724) [Maps] Reverse the attribution order so left-to-right order matches top-to-bottom (elastic#44415) Update sinon related packages (elastic#43952) [SIEM] change flag to drag and drop field (elastic#44705) Update dependency @types/object-hash to ^1.3.0 (elastic#43954) mark eslint config as root (elastic#44699) Adds geo_point to normalizeType helper (elastic#44410) [Uptime]Feature/38542 align uptime help menu with other apps (elastic#44536) Removed unused remove icon component (elastic#44698) Update unit tests to remove warnings from test output. (elastic#41840) Fix rawChecksums in chromium build and rename for clarity (elastic#44665) [Uptime]removed extra slash from integeration urls (elastic#44469) ... # Conflicts: # rfcs/text/0004_application_service_mounting.md

…ana into chore/console-to-np-ready * 'chore/console-to-np-ready' of github.com:jloleysens/kibana: (45 commits) Fixing flaky copy-to-space test (elastic#44656) [ML] Enable data visualizer link on job types page for non-time index (elastic#44667) [ML] Adding index pattern title to wizard summary step (elastic#44662) Convert remaining data.indexPatterns items to use TS (elastic#44654) [visualize/_tsvb_time_series] fix flaky test (elastic#44505) [SIEM] Updates fields in map tooltip and fixes filtering on undefined values (elastic#44718) [SIEM] Remove deprecation warning from momentJS test (elastic#44732) [SIEM] Fixes the rendering order and adds unit tests to prevent rendering to get out of order (elastic#44728) [optimizer] use more precise cache-busting strategy (elastic#44724) [Maps] Reverse the attribution order so left-to-right order matches top-to-bottom (elastic#44415) Update sinon related packages (elastic#43952) [SIEM] change flag to drag and drop field (elastic#44705) Update dependency @types/object-hash to ^1.3.0 (elastic#43954) mark eslint config as root (elastic#44699) Adds geo_point to normalizeType helper (elastic#44410) [Uptime]Feature/38542 align uptime help menu with other apps (elastic#44536) Removed unused remove icon component (elastic#44698) Update unit tests to remove warnings from test output. (elastic#41840) Fix rawChecksums in chromium build and rename for clarity (elastic#44665) [Uptime]removed extra slash from integeration urls (elastic#44469) ...

[visualize/_tsvb_time_series] fix flaky test

dce2452

dmlemeshko force-pushed the fix/tsvb-time-series-duration-formatter-test branch from f4ccd04 to dce2452 Compare September 2, 2019 16:52

dmlemeshko requested review from LeeDr and maryia-lapata September 2, 2019 16:54

dmlemeshko added release_note:skip Skip the PR/issue when compiling release notes v7.5.0 v8.0.0 labels Sep 3, 2019

dmlemeshko marked this pull request as ready for review September 3, 2019 12:53

maryia-lapata approved these changes Sep 3, 2019

View reviewed changes

LeeDr approved these changes Sep 3, 2019

View reviewed changes

dmlemeshko merged commit 96cd619 into elastic:master Sep 4, 2019

dmlemeshko mentioned this pull request Sep 4, 2019

[7.x] [visualize/_tsvb_time_series] fix flaky test (#44505) #44748

Merged

dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Sep 4, 2019

[visualize/_tsvb_time_series] fix flaky test (elastic#44505)

6a12998

dmlemeshko added a commit that referenced this pull request Sep 4, 2019

[visualize/_tsvb_time_series] fix flaky test (#44505) (#44748)

aa24a33

dmlemeshko mentioned this pull request Sep 6, 2019

[7.4] [visualize/_tsvb_time_series] fix flaky test (#44505) #44971

Merged

dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Sep 6, 2019

[visualize/_tsvb_time_series] fix flaky test (elastic#44505)

8e69ad1

dmlemeshko added a commit that referenced this pull request Sep 6, 2019

[visualize/_tsvb_time_series] fix flaky test (#44505) (#44971)

a5a834a

dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Sep 6, 2019

[visualize/_tsvb_time_series] fix flaky test (elastic#44505)

efb4eec

dmlemeshko mentioned this pull request Sep 6, 2019

[7.3] [visualize/_tsvb_time_series] fix flaky test (#44505) #45018

Merged

dmlemeshko added a commit that referenced this pull request Sep 6, 2019

[visualize/_tsvb_time_series] fix flaky test (#44505) (#45018)

815aa23

dmlemeshko deleted the fix/tsvb-time-series-duration-formatter-test branch January 31, 2022 12:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix flaky TSVB test#44505

fix flaky TSVB test#44505
dmlemeshko merged 1 commit intoelastic:masterfrom
dmlemeshko:fix/tsvb-time-series-duration-formatter-test

dmlemeshko commented Aug 30, 2019 •

edited

Loading

Uh oh!

elasticmachine commented Aug 30, 2019

Uh oh!

dmlemeshko commented Aug 30, 2019

Uh oh!

elasticmachine commented Aug 30, 2019

Uh oh!

elasticmachine commented Sep 2, 2019

Uh oh!

maryia-lapata left a comment

Uh oh!

LeeDr left a comment

Uh oh!

LeeDr Sep 3, 2019

Uh oh!

dmlemeshko Sep 3, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

dmlemeshko commented Aug 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Aug 30, 2019

💚 Build Succeeded

Uh oh!

dmlemeshko commented Aug 30, 2019

Uh oh!

elasticmachine commented Aug 30, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Sep 2, 2019

💚 Build Succeeded

Uh oh!

maryia-lapata left a comment

Choose a reason for hiding this comment

Uh oh!

LeeDr left a comment

Choose a reason for hiding this comment

Uh oh!

LeeDr Sep 3, 2019

Choose a reason for hiding this comment

Uh oh!

dmlemeshko Sep 3, 2019

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dmlemeshko commented Aug 30, 2019 •

edited

Loading