[Canvas] Removes unused remove icon component#44698
Merged
cqliu1 merged 2 commits intoelastic:masterfrom Sep 3, 2019
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-canvas |
Contributor
💚 Build Succeeded |
cqliu1
added a commit
to cqliu1/kibana
that referenced
this pull request
Sep 3, 2019
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 4, 2019
…-to-np-ready * 'master' of github.com:elastic/kibana: (45 commits) Fixing flaky copy-to-space test (elastic#44656) [ML] Enable data visualizer link on job types page for non-time index (elastic#44667) [ML] Adding index pattern title to wizard summary step (elastic#44662) Convert remaining data.indexPatterns items to use TS (elastic#44654) [visualize/_tsvb_time_series] fix flaky test (elastic#44505) [SIEM] Updates fields in map tooltip and fixes filtering on undefined values (elastic#44718) [SIEM] Remove deprecation warning from momentJS test (elastic#44732) [SIEM] Fixes the rendering order and adds unit tests to prevent rendering to get out of order (elastic#44728) [optimizer] use more precise cache-busting strategy (elastic#44724) [Maps] Reverse the attribution order so left-to-right order matches top-to-bottom (elastic#44415) Update sinon related packages (elastic#43952) [SIEM] change flag to drag and drop field (elastic#44705) Update dependency @types/object-hash to ^1.3.0 (elastic#43954) mark eslint config as root (elastic#44699) Adds geo_point to normalizeType helper (elastic#44410) [Uptime]Feature/38542 align uptime help menu with other apps (elastic#44536) Removed unused remove icon component (elastic#44698) Update unit tests to remove warnings from test output. (elastic#41840) Fix rawChecksums in chromium build and rename for clarity (elastic#44665) [Uptime]removed extra slash from integeration urls (elastic#44469) ... # Conflicts: # rfcs/text/0004_application_service_mounting.md
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 4, 2019
…ana into chore/console-to-np-ready * 'chore/console-to-np-ready' of github.com:jloleysens/kibana: (45 commits) Fixing flaky copy-to-space test (elastic#44656) [ML] Enable data visualizer link on job types page for non-time index (elastic#44667) [ML] Adding index pattern title to wizard summary step (elastic#44662) Convert remaining data.indexPatterns items to use TS (elastic#44654) [visualize/_tsvb_time_series] fix flaky test (elastic#44505) [SIEM] Updates fields in map tooltip and fixes filtering on undefined values (elastic#44718) [SIEM] Remove deprecation warning from momentJS test (elastic#44732) [SIEM] Fixes the rendering order and adds unit tests to prevent rendering to get out of order (elastic#44728) [optimizer] use more precise cache-busting strategy (elastic#44724) [Maps] Reverse the attribution order so left-to-right order matches top-to-bottom (elastic#44415) Update sinon related packages (elastic#43952) [SIEM] change flag to drag and drop field (elastic#44705) Update dependency @types/object-hash to ^1.3.0 (elastic#43954) mark eslint config as root (elastic#44699) Adds geo_point to normalizeType helper (elastic#44410) [Uptime]Feature/38542 align uptime help menu with other apps (elastic#44536) Removed unused remove icon component (elastic#44698) Update unit tests to remove warnings from test output. (elastic#41840) Fix rawChecksums in chromium build and rename for clarity (elastic#44665) [Uptime]removed extra slash from integeration urls (elastic#44469) ...
cqliu1
added a commit
that referenced
this pull request
Sep 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I noticed that this component isn't being used anywhere, so we might as well delete it.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers