SQL template with triple quote in completion#44646
SQL template with triple quote in completion#44646jloleysens wants to merge 12 commits intoelastic:masterfrom
Conversation
|
Pinging @elastic/es-ui |
💚 Build Succeeded |
|
Likely this PR needs a reviewer for it to be merged, maybe @cjcenizal ? |
💔 Build Failed |
Update tests for new cases too
Expanded tests
💚 Build Succeeded |
💚 Build Succeeded |
alisonelizabeth
left a comment
There was a problem hiding this comment.
@jloleysens thanks for adding this enhancement!
Tested locally - the autocomplete for sql works great! However, I'm not sure #44729 is resolved. I may be misunderstanding the issue, but I'm still seeing triple quotes converted when I auto-indent.
|
@alisonelizabeth Yeah I think this one is slightly open to interpretation - but I think the issue was describing the previous indentation behaviour:
Where it should only toggle between two different states instead of the second (incorrect state) of: Can you confirm @cjcenizal ? |
…plate * 'master' of github.com:elastic/kibana: (91 commits) [APM] Make number of x ticks responsive to the plot width (elastic#44870) [ML] Single metric viewer: Fix top nav refresh behaviour. (elastic#44860) Replace TSVB timeseries charts with elastic-charts (elastic#33558) [TSVB][Top N aggregation] Unable to deal with negative values (elastic#43581) [alerting] Adds Action Type configuration support and whitelisting (elastic#44483) FTR: fix WebDriver Actions calls (elastic#44605) [Code] add NodeRepositoriesService to watch new repositories on local node (elastic#44677) [skip-ci][Maps] Improve Maps intro page (elastic#44721) [Maps] Update titles and descriptions for data sources (elastic#44833) Types + Extract Integration Util (elastic#44433) Downgrade log level from info to debug for cases when we cannot handle authentication attempt. (elastic#44933) [Reporting] Remove Chome stdout/stderr observables, Add Browser Logger observable (elastic#44359) Update Jest script to output coverage (elastic#44447) [ftr] support --kibana-install-dir flag (elastic#44552) [WATCHER] Allow user to set a threshold value of 0 (elastic#44810) Remove injectI18n in dashboard plugin. (elastic#44580) [Graph] Save modal (elastic#44261) Use external script for the OIDC Implicit flow handler page. (elastic#44866) disable router prefixing with pluginId (elastic#44855) [SIEM] Fix bug on url + inspect functionality on hosts/hostDetails page (elastic#44671) ...
💚 Build Succeeded |
|
I haven't had a chance to review this locally, but yes I believe @jloleysens's interpretation was my original understanding too. However... now I'm having second thoughts. Maybe the original behavior was a feature? Is it possible that users want to cycle from expanded with triple quotes -> expanded with escaped quotes -> condensed and back again? Can we confirm this with @bleskes before merging the fix and/or extract the fix into a separate PR to unblock this one? |
|
@cjcenizal I'm not sure what I'm supposed to check. #44593 makes sense to me. |
cjcenizal
left a comment
There was a problem hiding this comment.
Tested locally, code LGTM! If you decide to extract the bug fix into a separate PR I can re-test this one.
|
Apologies, for the spam - I tried to salvage this by reverting a merge commit and didn't consider the fact that it would create a newer commit undoing a ton of work. Sorry for the spam - please ignore! I'll just cherry-pick changes and create 2 new, clean PRs. |
💚 Build Succeeded |
Summary
See this issue for more more information.
The idea is to give a slightly improved SQL query experience from console with users often running into issues with needing to use
"in their SQL queries.Also adds format param completion.
cc @costin
Demo of new autocomplete with format toggling
Triple quote expansion
[Update] including fix for this issue after all
How to review
GET _sqlendpoint)."""and non"""request bodies.