[WATCHER] Allow user to set a threshold value of 0#44810
Merged
alisonelizabeth merged 2 commits intoelastic:masterfrom Sep 5, 2019
Merged
[WATCHER] Allow user to set a threshold value of 0#44810alisonelizabeth merged 2 commits intoelastic:masterfrom
alisonelizabeth merged 2 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/es-ui |
Contributor
💚 Build Succeeded |
jloleysens
approved these changes
Sep 5, 2019
Contributor
jloleysens
left a comment
There was a problem hiding this comment.
Left some suggestions, but happy for you to make the call - overall LGTM.
| const key = `threshold${i}`; | ||
| errors[key] = []; | ||
| if (!this.threshold[i]) { | ||
| if (typeof this.threshold[i] === 'undefined' || this.threshold[i] === '') { |
Contributor
There was a problem hiding this comment.
Not entirely sure how comparators[this.thresholdComparator] works and what the known values for requiredValues is - but if it ever changes and assigns null this logic won't work anymore. I'd suggest a slightly more defensive check:
if (
this.threshold[i] == null // terse way of checking for `null` and `undefined` at the same time
|| this.threshold[i] === '') {
Contributor
Author
There was a problem hiding this comment.
good point - updated the code!
| find('watchThresholdButton').simulate('click'); | ||
|
|
||
| // Provide invalid value | ||
| form.setInputValue('watchThresholdInput', ''); |
Contributor
There was a problem hiding this comment.
Is there other non-numeric input possible here that we could test for?
Contributor
Author
There was a problem hiding this comment.
Since the UI renders a number input for this, I don't think it would be possible for any other non-numeric values.
| expect(form.getErrorsMessages()).toContain('A value is required.'); | ||
|
|
||
| // Provide valid value | ||
| form.setInputValue('watchThresholdInput', '0'); |
Contributor
There was a problem hiding this comment.
Are there any number values that are disallowed that we could test for?
Contributor
Author
There was a problem hiding this comment.
Not that I'm aware of
Contributor
💚 Build Succeeded |
alisonelizabeth
added a commit
that referenced
this pull request
Sep 5, 2019
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 6, 2019
…ete-for-distance_feature * 'master' of github.com:elastic/kibana: (89 commits) Replace TSVB timeseries charts with elastic-charts (elastic#33558) [TSVB][Top N aggregation] Unable to deal with negative values (elastic#43581) [alerting] Adds Action Type configuration support and whitelisting (elastic#44483) FTR: fix WebDriver Actions calls (elastic#44605) [Code] add NodeRepositoriesService to watch new repositories on local node (elastic#44677) [skip-ci][Maps] Improve Maps intro page (elastic#44721) [Maps] Update titles and descriptions for data sources (elastic#44833) Types + Extract Integration Util (elastic#44433) Downgrade log level from info to debug for cases when we cannot handle authentication attempt. (elastic#44933) [Reporting] Remove Chome stdout/stderr observables, Add Browser Logger observable (elastic#44359) Update Jest script to output coverage (elastic#44447) [ftr] support --kibana-install-dir flag (elastic#44552) [WATCHER] Allow user to set a threshold value of 0 (elastic#44810) Remove injectI18n in dashboard plugin. (elastic#44580) [Graph] Save modal (elastic#44261) Use external script for the OIDC Implicit flow handler page. (elastic#44866) disable router prefixing with pluginId (elastic#44855) [SIEM] Fix bug on url + inspect functionality on hosts/hostDetails page (elastic#44671) [ML] File data viz limiting uploaded doc chunk size (elastic#44768) [code] Append go env variable 'GOCACHE' to go lsp spawn command. (elastic#44864) ...
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 6, 2019
…plate * 'master' of github.com:elastic/kibana: (91 commits) [APM] Make number of x ticks responsive to the plot width (elastic#44870) [ML] Single metric viewer: Fix top nav refresh behaviour. (elastic#44860) Replace TSVB timeseries charts with elastic-charts (elastic#33558) [TSVB][Top N aggregation] Unable to deal with negative values (elastic#43581) [alerting] Adds Action Type configuration support and whitelisting (elastic#44483) FTR: fix WebDriver Actions calls (elastic#44605) [Code] add NodeRepositoriesService to watch new repositories on local node (elastic#44677) [skip-ci][Maps] Improve Maps intro page (elastic#44721) [Maps] Update titles and descriptions for data sources (elastic#44833) Types + Extract Integration Util (elastic#44433) Downgrade log level from info to debug for cases when we cannot handle authentication attempt. (elastic#44933) [Reporting] Remove Chome stdout/stderr observables, Add Browser Logger observable (elastic#44359) Update Jest script to output coverage (elastic#44447) [ftr] support --kibana-install-dir flag (elastic#44552) [WATCHER] Allow user to set a threshold value of 0 (elastic#44810) Remove injectI18n in dashboard plugin. (elastic#44580) [Graph] Save modal (elastic#44261) Use external script for the OIDC Implicit flow handler page. (elastic#44866) disable router prefixing with pluginId (elastic#44855) [SIEM] Fix bug on url + inspect functionality on hosts/hostDetails page (elastic#44671) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where
0wasn't allowed as a threshold value when creating a threshold watch.Fixes #18476